René's URL Explorer Experiment


Title: sqlite: keep sessions alive across SQLite callbacks by TrevorBurnham · Pull Request #65465 · nodejs/node · GitHub

Open Graph Title: sqlite: keep sessions alive across SQLite callbacks by TrevorBurnham · Pull Request #65465 · nodejs/node

X Title: sqlite: keep sessions alive across SQLite callbacks by TrevorBurnham · Pull Request #65465 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Session calls MakeWeak() and DatabaseSync::sessions_ holds raw Session*, so nothing keeps a session alive once JavaScript drops the reference. SQLite runs PRAGMA table_xinfo from inside its pre-upd...

X Description: Session calls MakeWeak() and DatabaseSync::sessions_ holds raw Session*, so nothing keeps a session alive once JavaScript drops the reference. SQLite runs PRAGMA table_xinfo from inside its pre-upd...

Opengraph URL: https://github.com/nodejs/node/pull/65465

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:36b4165b-0e85-0214-cd77-91dbe92f1446
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEC6:39BC20:BDF740:FE374E:6AED3D16
html-safe-nonce5516c18c23bf1d4fc3750a4dc1019e3824259e4e04433b3b7655ca34e7ff921e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUM2OjM5QkMyMDpCREY3NDA6RkUzNzRFOjZBRUQzRDE2IiwidmlzaXRvcl9pZCI6IjU2ODQyODE2MDMzNDkzNjM5OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3aa065340196981c0ba03f37492f3cb32f6d098814c980e1b9e5bdb067741b4a
hovercard-subject-tagpull_request:4334023553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65465/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0107b71a282976df14b3ade68d9b4af975d8939cf9893ef5ff9197815f65d7b4/nodejs/node/pull/65465
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0107b71a282976df14b3ade68d9b4af975d8939cf9893ef5ff9197815f65d7b4/nodejs/node/pull/65465
og:image:altSession calls MakeWeak() and DatabaseSync::sessions_ holds raw Session*, so nothing keeps a session alive once JavaScript drops the reference. SQLite runs PRAGMA table_xinfo from inside its pre-upd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrevorBurnham
hostnamegithub.com
expected-hostnamegithub.com
None26c92a9388ddfad3fa88d132b5d5f0b4747030233dcc4e5efb05f1cbae152184
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec629ad99c254d306375fc8354d04321c2c362236
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65465#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65465
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65465
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65465
Reloadhttps://github.com/nodejs/node/pull/65465
Reloadhttps://github.com/nodejs/node/pull/65465
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
TrevorBurnham:sqlite-session-gc-pinhttps://github.com/TrevorBurnham/node/tree/sqlite-session-gc-pin
Conversationhttps://github.com/nodejs/node/pull/65465
Commits2 (2)https://github.com/nodejs/node/pull/65465/commits
Checkshttps://github.com/nodejs/node/pull/65465/checks
Files changedhttps://github.com/nodejs/node/pull/65465/files
sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/pull/65465#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
TrevorBurnham:sqlite-session-gc-pinhttps://github.com/TrevorBurnham/node/tree/sqlite-session-gc-pin
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 21, 2026https://github.com/nodejs/node/pull/65465#issue-5216721595
Please reload this pagehttps://github.com/nodejs/node/pull/65465
#65460https://github.com/nodejs/node/issues/65460
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/TrevorBurnham
sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/pull/65465/commits/726169cb77a049bd5e869236c237be21b11e3764
726169chttps://github.com/nodejs/node/pull/65465/commits/726169cb77a049bd5e869236c237be21b11e3764
nodejs#65460https://github.com/nodejs/node/issues/65460
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2026https://github.com/nodejs/node/pull/65465#issuecomment-5373312099
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Aug 21, 2026https://github.com/nodejs/node/pull/65465#event-29819698064
https://github.com/TrevorBurnham
fixup! sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/pull/65465/commits/7adc57293023778cafba8544a0c7f26bfd8618d2
7adc572https://github.com/nodejs/node/pull/65465/commits/7adc57293023778cafba8544a0c7f26bfd8618d2
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
August 21, 2026 20:41https://github.com/nodejs/node/pull/65465#event-29827228496
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 21, 2026https://github.com/nodejs/node/pull/65465#issuecomment-5376010522
Please reload this pagehttps://github.com/nodejs/node/pull/65465
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65465?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
21f0f27https://app.codecov.io/gh/nodejs/node/commit/21f0f2786f02f930acd56c0665dc65a8bb1693f5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7adc572https://app.codecov.io/gh/nodejs/node/commit/7adc57293023778cafba8544a0c7f26bfd8618d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65465?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/65465?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65465?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65465?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.hhttps://app.codecov.io/gh/nodejs/node/pull/65465?src=pr&el=tree&filepath=src%2Fnode_sqlite.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmg=
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/65465?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
38 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65465/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 28, 2026 https://github.com/nodejs/node/pull/65465#pullrequestreview-5048079289
View reviewed changes https://github.com/nodejs/node/pull/65465/files/7adc57293023778cafba8544a0c7f26bfd8618d2
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30146154022
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30151131439
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65465#issuecomment-5449718596
https://ci.nodejs.org/job/node-test-pull-request/76621/https://ci.nodejs.org/job/node-test-pull-request/76621/
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30172042981
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30179174473
https://github.com/panva
panvahttps://github.com/panva
Aug 28, 2026https://github.com/nodejs/node/pull/65465#issuecomment-5455810268
#65465 (comment)https://github.com/nodejs/node/pull/65465#event-30179174473
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
76aeacfhttps://github.com/nodejs/node/commit/76aeacf6877dff12e3f0990c40b8d86782c81049
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30188580815
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65465#issuecomment-5457874728
76aeacfhttps://github.com/nodejs/node/commit/76aeacf6877dff12e3f0990c40b8d86782c81049
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
lacks-second-approval https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alacks-second-approval
Aug 28, 2026https://github.com/nodejs/node/pull/65465#event-30188583780
aduh95https://github.com/aduh95
Aug 29, 2026 https://github.com/nodejs/node/pull/65465#ref-commit-9180666
https://github.com/TrevorBurnham
https://github.com/aduh95
sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/commit/9180666ea5388b2f26ea42338fad8d134211fb33
9180666https://github.com/nodejs/node/commit/9180666ea5388b2f26ea42338fad8d134211fb33
#65460https://github.com/nodejs/node/issues/65460
#65465https://github.com/nodejs/node/pull/65465
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65465#ref-commit-035a9b8
https://github.com/TrevorBurnham
https://github.com/aduh95
sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/commit/035a9b8bfd4c62e6f9590b2051d6c45b35d89c90
035a9b8https://github.com/nodejs/node/commit/035a9b8bfd4c62e6f9590b2051d6c45b35d89c90
#65460https://github.com/nodejs/node/issues/65460
#65465https://github.com/nodejs/node/pull/65465
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65465#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65465#ref-commit-5f95032
https://github.com/TrevorBurnham
https://github.com/aduh95
sqlite: keep sessions alive across SQLite callbackshttps://github.com/nodejs/node/commit/5f95032859b4fcb44a975176d6be471d57f86ce5
5f95032https://github.com/nodejs/node/commit/5f95032859b4fcb44a975176d6be471d57f86ce5
#65460https://github.com/nodejs/node/issues/65460
#65465https://github.com/nodejs/node/pull/65465
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65465
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/65465/files/7adc57293023778cafba8544a0c7f26bfd8618d2
Please reload this pagehttps://github.com/nodejs/node/pull/65465
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
sqlite: GC of an unreferenced session frees memory SQLite is still using https://github.com/nodejs/node/issues/65460
Please reload this pagehttps://github.com/nodejs/node/pull/65465
https://github.com/TrevorBurnham
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.