René's URL Explorer Experiment


Title: src: reuse cached strings in CompileSerializeMain by agape1225 · Pull Request #65453 · nodejs/node · GitHub

Open Graph Title: src: reuse cached strings in CompileSerializeMain by agape1225 · Pull Request #65453 · nodejs/node

X Title: src: reuse cached strings in CompileSerializeMain by agape1225 · Pull Request #65453 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: CompileSerializeMain() created new "require", "__filename", and "__dirname" strings via FIXED_ONE_BYTE_STRING() on every call, even though these strings are already ca...

X Description: CompileSerializeMain() created new "require", "__filename", and "__dirname" strings via FIXED_ONE_BYTE_STRING() on every call, even though thes...

Opengraph URL: https://github.com/nodejs/node/pull/65453

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26dc4811-c9bb-c4f3-5191-6355165c85ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB67E:1E45AC:88BA2:B4041:6AED111C
html-safe-nonce7b080fd809cf8666a8ff0b37185e59a3b5c1648911ee5c33b4748d79ab89bfd8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjdFOjFFNDVBQzo4OEJBMjpCNDA0MTo2QUVEMTExQyIsInZpc2l0b3JfaWQiOiI0MzYyOTAwMzEwMTgzNDQ4ODYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac97a60685c7aaa906599442beb1316d8c5e3a3369064ee30a75bf35ced9dc051d
hovercard-subject-tagpull_request:4331916073
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65453/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4649dc3b88f8200ff30e86ad2570c6cba139e8b2fd756c78a8694a1310ebb216/nodejs/node/pull/65453
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4649dc3b88f8200ff30e86ad2570c6cba139e8b2fd756c78a8694a1310ebb216/nodejs/node/pull/65453
og:image:altCompileSerializeMain() created new "require", "__filename", and "__dirname" strings via FIXED_ONE_BYTE_STRING() on every call, even though these strings are already ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameagape1225
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65453#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65453
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65453
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65453
Reloadhttps://github.com/nodejs/node/pull/65453
Reloadhttps://github.com/nodejs/node/pull/65453
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
agape1225:src-snapshotable-reuse-cached-stringshttps://github.com/agape1225/node/tree/src-snapshotable-reuse-cached-strings
Conversationhttps://github.com/nodejs/node/pull/65453
Commits1 (1)https://github.com/nodejs/node/pull/65453/commits
Checkshttps://github.com/nodejs/node/pull/65453/checks
Files changedhttps://github.com/nodejs/node/pull/65453/files
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/pull/65453#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
agape1225:src-snapshotable-reuse-cached-stringshttps://github.com/agape1225/node/tree/src-snapshotable-reuse-cached-strings
https://github.com/agape1225
agape1225https://github.com/agape1225
Aug 21, 2026https://github.com/nodejs/node/pull/65453#issue-5214220177
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5370012710
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 21, 2026https://github.com/nodejs/node/pull/65453#event-29805264799
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 21, 2026 https://github.com/nodejs/node/pull/65453#pullrequestreview-4994293703
View reviewed changes https://github.com/nodejs/node/pull/65453/files
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 21, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5371267024
Please reload this pagehttps://github.com/nodejs/node/pull/65453
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65453?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
21f0f27https://app.codecov.io/gh/nodejs/node/commit/21f0f2786f02f930acd56c0665dc65a8bb1693f5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c01d966https://app.codecov.io/gh/nodejs/node/commit/c01d966404719f175758e9bcd29f62cdf143d526?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65453?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_snapshotable.cchttps://app.codecov.io/gh/nodejs/node/pull/65453?src=pr&el=tree&filepath=src%2Fnode_snapshotable.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc25hcHNob3RhYmxlLmNj
118 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65453/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65453
daeyeonhttps://github.com/daeyeon
Aug 26, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-bac9f50
https://github.com/agape1225
docs: add contribution note forhttps://github.com/ossca-node/board/commit/bac9f50c7a4622ef6ae0ad38d06fa01d598501ba
nodejs/node#65453https://github.com/nodejs/node/pull/65453
bac9f50https://github.com/ossca-node/board/commit/bac9f50c7a4622ef6ae0ad38d06fa01d598501ba
https://github.com/agape1225
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/pull/65453/commits/c01d966404719f175758e9bcd29f62cdf143d526
c01d966https://github.com/nodejs/node/pull/65453/commits/c01d966404719f175758e9bcd29f62cdf143d526
https://github.com/agape1225
agape1225https://github.com/agape1225
force-pushedhttps://github.com/nodejs/node/compare/97f69feda55d79bdab421dd3727671239a024d16..c01d966404719f175758e9bcd29f62cdf143d526
97f69fehttps://github.com/nodejs/node/commit/97f69feda55d79bdab421dd3727671239a024d16
c01d966https://github.com/nodejs/node/commit/c01d966404719f175758e9bcd29f62cdf143d526
Compare https://github.com/nodejs/node/compare/97f69feda55d79bdab421dd3727671239a024d16..c01d966404719f175758e9bcd29f62cdf143d526
August 27, 2026 12:04https://github.com/nodejs/node/pull/65453#event-30101863860
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 27, 2026 https://github.com/nodejs/node/pull/65453#pullrequestreview-5042514019
View reviewed changes https://github.com/nodejs/node/pull/65453/files/c01d966404719f175758e9bcd29f62cdf143d526
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 27, 2026https://github.com/nodejs/node/pull/65453#event-30113322651
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 27, 2026https://github.com/nodejs/node/pull/65453#event-30113627030
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 27, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5441486199
https://ci.nodejs.org/job/node-test-pull-request/76591/https://ci.nodejs.org/job/node-test-pull-request/76591/
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5449303807
https://ci.nodejs.org/job/node-test-pull-request/76617/https://ci.nodejs.org/job/node-test-pull-request/76617/
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/legendecas
legendecashttps://github.com/legendecas
Aug 28, 2026 https://github.com/nodejs/node/pull/65453#pullrequestreview-5054054622
View reviewed changes https://github.com/nodejs/node/pull/65453/files/c01d966404719f175758e9bcd29f62cdf143d526
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5456408022
https://ci.nodejs.org/job/node-test-pull-request/76652/https://ci.nodejs.org/job/node-test-pull-request/76652/
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5465252680
https://ci.nodejs.org/job/node-test-pull-request/76711/https://ci.nodejs.org/job/node-test-pull-request/76711/
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 31, 2026https://github.com/nodejs/node/pull/65453#event-30255058309
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
3a58b2fhttps://github.com/nodejs/node/commit/3a58b2f06de56ae263ab69a33324f7570aa44e89
Aug 31, 2026https://github.com/nodejs/node/pull/65453#event-30255692232
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 31, 2026https://github.com/nodejs/node/pull/65453#issuecomment-5473354445
3a58b2fhttps://github.com/nodejs/node/commit/3a58b2f06de56ae263ab69a33324f7570aa44e89
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 31, 2026https://github.com/nodejs/node/pull/65453#event-30255693733
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-e7c2863
https://github.com/agape1225
https://github.com/aduh95
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/commit/e7c28635d8a7e91eddd963bcfe130b2086c48943
e7c2863https://github.com/nodejs/node/commit/e7c28635d8a7e91eddd963bcfe130b2086c48943
#65453https://github.com/nodejs/node/pull/65453
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65453#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-e260fd1
https://github.com/agape1225
https://github.com/aduh95
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/commit/e260fd146c8a4b54df4e406e94d19cf93ad73b9e
e260fd1https://github.com/nodejs/node/commit/e260fd146c8a4b54df4e406e94d19cf93ad73b9e
#65453https://github.com/nodejs/node/pull/65453
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-824cd80
https://github.com/agape1225
https://github.com/aduh95
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/commit/824cd80a04376b53d0de003829e323fb09d54cd6
824cd80https://github.com/nodejs/node/commit/824cd80a04376b53d0de003829e323fb09d54cd6
#65453https://github.com/nodejs/node/pull/65453
aduh95https://github.com/aduh95
Sep 19, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-49232db
https://github.com/agape1225
https://github.com/aduh95
src: reuse cached strings in CompileSerializeMainhttps://github.com/nodejs/node/commit/49232db71e65537489d2555475d62ef56637a3d2
49232dbhttps://github.com/nodejs/node/commit/49232db71e65537489d2555475d62ef56637a3d2
#65453https://github.com/nodejs/node/pull/65453
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 11, 2026 https://github.com/nodejs/node/pull/65453#ref-pullrequest-5805806867
2026-10-14, Version 24.22.0 'Krypton' (LTS) #66667 https://github.com/nodejs/node/pull/66667
markhardinghttps://github.com/markharding
Oct 19, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-7e9c1d2
https://github.com/markharding
Update Node.js to v24.22.0 (#1833)https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
7e9c1d2https://github.com/futo-org/Harbor/commit/7e9c1d2fd346da653b5f5b3cbdadc19494c1516f
paultibbettshttps://github.com/paultibbetts
Oct 27, 2026 https://github.com/nodejs/node/pull/65453#ref-commit-1cd6b6e
https://github.com/renovate-bot
https://github.com/paultibbetts
chore(deps): update node.js to v24.22.1 (#12)https://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
1cd6b6ehttps://github.com/paultibbetts/indiekit.paultibbetts.uk/commit/1cd6b6eb5f00d6f9cbd77687d68df169241003ad
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65453
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65453/files/97f69feda55d79bdab421dd3727671239a024d16
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/65453/files/c01d966404719f175758e9bcd29f62cdf143d526
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/65453/files/c01d966404719f175758e9bcd29f62cdf143d526
Please reload this pagehttps://github.com/nodejs/node/pull/65453
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65453
https://github.com/agape1225
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/legendecas
https://github.com/daeyeon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.