René's URL Explorer Experiment


Title: sqlite: throw on disposal of an in-use session by araujogui · Pull Request #65449 · nodejs/node · GitHub

Open Graph Title: sqlite: throw on disposal of an in-use session by araujogui · Pull Request #65449 · nodejs/node

X Title: sqlite: throw on disposal of an in-use session by araujogui · Pull Request #65449 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: session[Symbol.dispose]() wrapped Session::Close() in a v8::TryCatch and discarded whatever it threw, so the in-use guard added by #65349 rejected the close but the exception never reached JavaScri...

X Description: session[Symbol.dispose]() wrapped Session::Close() in a v8::TryCatch and discarded whatever it threw, so the in-use guard added by #65349 rejected the close but the exception never reached JavaScri...

Opengraph URL: https://github.com/nodejs/node/pull/65449

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:29839060-5575-1cca-c8f5-5c542cc74a20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD414:27868A:333CE4:461C6D:6AED1383
html-safe-nonce2c630169b8d4c8e5422389656f3e765e12369d34b7ddaaeb47af0b110a5fa545
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDE0OjI3ODY4QTozMzNDRTQ6NDYxQzZEOjZBRUQxMzgzIiwidmlzaXRvcl9pZCI6IjE4ODI5NDc5NjM5NjkxNDc3NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb3266c81b4676e55783e5d4eeaf23963add12fa17e73a80e6da50aca0a5414b5
hovercard-subject-tagpull_request:4327982753
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65449/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5cddfe980ec9a975292e117948504b0aff1d6a23d4003acb4e2991ac66d2aedc/nodejs/node/pull/65449
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5cddfe980ec9a975292e117948504b0aff1d6a23d4003acb4e2991ac66d2aedc/nodejs/node/pull/65449
og:image:altsession[Symbol.dispose]() wrapped Session::Close() in a v8::TryCatch and discarded whatever it threw, so the in-use guard added by #65349 rejected the close but the exception never reached JavaScri...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearaujogui
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65449#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65449
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65449
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65449
Reloadhttps://github.com/nodejs/node/pull/65449
Reloadhttps://github.com/nodejs/node/pull/65449
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
araujogui:sqlite-dispose-in-use-guardhttps://github.com/araujogui/node/tree/sqlite-dispose-in-use-guard
Conversationhttps://github.com/nodejs/node/pull/65449
Commits1 (1)https://github.com/nodejs/node/pull/65449/commits
Checkshttps://github.com/nodejs/node/pull/65449/checks
Files changedhttps://github.com/nodejs/node/pull/65449/files
sqlite: throw on disposal of an in-use sessionhttps://github.com/nodejs/node/pull/65449#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
araujogui:sqlite-dispose-in-use-guardhttps://github.com/araujogui/node/tree/sqlite-dispose-in-use-guard
https://github.com/araujogui
araujoguihttps://github.com/araujogui
Aug 21, 2026https://github.com/nodejs/node/pull/65449#issue-5209549681
#65349https://github.com/nodejs/node/pull/65349
#65447https://github.com/nodejs/node/issues/65447
#65349https://github.com/nodejs/node/pull/65349
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/araujogui
sqlite: throw on disposal of an in-use sessionhttps://github.com/nodejs/node/pull/65449/commits/a15400416c850ec1faf2127e9293edab6e64adcc
a154004https://github.com/nodejs/node/pull/65449/commits/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
August 21, 2026 01:54https://github.com/nodejs/node/pull/65449#event-29778480770
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 21, 2026https://github.com/nodejs/node/pull/65449#issuecomment-5364236347
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Aug 21, 2026 https://github.com/nodejs/node/pull/65449#pullrequestreview-4989061535
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs/node/pull/65449#pullrequestreview-4989061535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Aug 21, 2026https://github.com/nodejs/node/pull/65449#event-29778486589
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 21, 2026https://github.com/nodejs/node/pull/65449#issuecomment-5364859732
Please reload this pagehttps://github.com/nodejs/node/pull/65449
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65449?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9ea6182https://app.codecov.io/gh/nodejs/node/commit/9ea61828c7a9629802efaea69fd49b72878e62bf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a154004https://app.codecov.io/gh/nodejs/node/commit/a15400416c850ec1faf2127e9293edab6e64adcc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65449?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/65449?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65449?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/65449?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
32 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65449/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 21, 2026 https://github.com/nodejs/node/pull/65449#pullrequestreview-4994267370
View reviewed changes https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 22, 2026 https://github.com/nodejs/node/pull/65449#pullrequestreview-5000754583
View reviewed changes https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 27, 2026https://github.com/nodejs/node/pull/65449#event-30113342364
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 27, 2026https://github.com/nodejs/node/pull/65449#event-30113631418
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65449
https://github.com/geeksilva97
geeksilva97https://github.com/geeksilva97
Aug 27, 2026 https://github.com/nodejs/node/pull/65449#pullrequestreview-5043317500
View reviewed changes https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65449#issuecomment-5448432795
https://ci.nodejs.org/job/node-test-pull-request/76610/https://ci.nodejs.org/job/node-test-pull-request/76610/
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 28, 2026https://github.com/nodejs/node/pull/65449#event-30149285176
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
2743045https://github.com/nodejs/node/commit/2743045dc4db58b03f9fa5d8e1ad399436981da8
Aug 28, 2026https://github.com/nodejs/node/pull/65449#event-30156655056
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65449#issuecomment-5450830794
2743045https://github.com/nodejs/node/commit/2743045dc4db58b03f9fa5d8e1ad399436981da8
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 28, 2026https://github.com/nodejs/node/pull/65449#event-30156658092
https://github.com/araujogui
araujoguihttps://github.com/araujogui
August 28, 2026 11:39https://github.com/nodejs/node/pull/65449#event-30162449853
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 28, 2026 https://github.com/nodejs/node/pull/65449#ref-pullrequest-5214354187
sqlite: reject closing a session from a callback #65454 https://github.com/nodejs/node/pull/65454
aduh95https://github.com/aduh95
Aug 29, 2026 https://github.com/nodejs/node/pull/65449#ref-commit-8ab894b
https://github.com/araujogui
https://github.com/aduh95
sqlite: throw on disposal of an in-use sessionhttps://github.com/nodejs/node/commit/8ab894b971812748d22b9fe6f5d011d75d18c96e
8ab894bhttps://github.com/nodejs/node/commit/8ab894b971812748d22b9fe6f5d011d75d18c96e
#65449https://github.com/nodejs/node/pull/65449
#65447https://github.com/nodejs/node/issues/65447
#65349https://github.com/nodejs/node/pull/65349
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65449#ref-commit-09202e8
https://github.com/araujogui
https://github.com/aduh95
sqlite: throw on disposal of an in-use sessionhttps://github.com/nodejs/node/commit/09202e8a6bd99313e82f39b491edb7f3bdbe936e
09202e8https://github.com/nodejs/node/commit/09202e8a6bd99313e82f39b491edb7f3bdbe936e
#65449https://github.com/nodejs/node/pull/65449
#65447https://github.com/nodejs/node/issues/65447
#65349https://github.com/nodejs/node/pull/65349
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65449#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65449#ref-commit-2ce0e2e
https://github.com/araujogui
https://github.com/aduh95
sqlite: throw on disposal of an in-use sessionhttps://github.com/nodejs/node/commit/2ce0e2eb109034180eb0272a9a7efeee839ecbff
2ce0e2ehttps://github.com/nodejs/node/commit/2ce0e2eb109034180eb0272a9a7efeee839ecbff
#65449https://github.com/nodejs/node/pull/65449
#65447https://github.com/nodejs/node/issues/65447
#65349https://github.com/nodejs/node/pull/65349
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65449
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
https://github.com/geeksilva97
geeksilva97 https://github.com/geeksilva97
https://github.com/nodejs/node/pull/65449/files/a15400416c850ec1faf2127e9293edab6e64adcc
Please reload this pagehttps://github.com/nodejs/node/pull/65449
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
sqlite: session[Symbol.dispose]() silently ignores the in-use guard https://github.com/nodejs/node/issues/65447
Please reload this pagehttps://github.com/nodejs/node/pull/65449
https://github.com/araujogui
https://github.com/nodejs-github-bot
https://github.com/cjihrig
https://github.com/Renegade334
https://github.com/geeksilva97
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/addaleax
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.