René's URL Explorer Experiment


Title: ffi: validate DynamicLibrary getter receivers by trivikr · Pull Request #65415 · nodejs/node · GitHub

Open Graph Title: ffi: validate DynamicLibrary getter receivers by trivikr · Pull Request #65415 · nodejs/node

X Title: ffi: validate DynamicLibrary getter receivers by trivikr · Pull Request #65415 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65287 Bind the path, symbols, and functions getter templates to the DynamicLibrary constructor signature. This causes V8 to reject incompatible receivers before invoking the native callback...

X Description: Fixes: #65287 Bind the path, symbols, and functions getter templates to the DynamicLibrary constructor signature. This causes V8 to reject incompatible receivers before invoking the native callback...

Opengraph URL: https://github.com/nodejs/node/pull/65415

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0dfd25c1-8ebf-8c21-5b53-dade0e488cdc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6E4:3C4A99:149F0B1:1AEB970:6AED72CB
html-safe-nonce32f3d9ba8cc4536d73ee98981999e376dc32f8dd4edd845ceef857577a4688cc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkU0OjNDNEE5OToxNDlGMEIxOjFBRUI5NzA6NkFFRDcyQ0IiLCJ2aXNpdG9yX2lkIjoiMzU3NTIwOTUzMTUwNDY4NTc3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b3a60b6c8fc0c99debdca31401f0f0aa428be7d10d2fb9823fa84cf412044a3
hovercard-subject-tagpull_request:4320220714
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65415/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b242c3bd231c44743b8733acd34560389e4ef96ba5ce75ae07dfb6bdb0ecc02c/nodejs/node/pull/65415
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b242c3bd231c44743b8733acd34560389e4ef96ba5ce75ae07dfb6bdb0ecc02c/nodejs/node/pull/65415
og:image:altFixes: #65287 Bind the path, symbols, and functions getter templates to the DynamicLibrary constructor signature. This causes V8 to reject incompatible receivers before invoking the native callback...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65415
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65415
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
Reloadhttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
Reloadhttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:fix-ffi-getter-crash-2https://github.com/trivikr/node/tree/fix-ffi-getter-crash-2
Conversationhttps://github.com/nodejs/node/pull/65415
Commits1 (1)https://github.com/nodejs/node/pull/65415/commits
Checkshttps://github.com/nodejs/node/pull/65415/checks
Files changedhttps://github.com/nodejs/node/pull/65415/files
ffi: validate DynamicLibrary getter receivershttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:fix-ffi-getter-crash-2https://github.com/trivikr/node/tree/fix-ffi-getter-crash-2
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#issue-5200344135
#65287https://github.com/nodejs/node/issues/65287
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#issuecomment-5352174379
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29725647322
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/35d2307849947da2b2455f0679e149796e796b02..cf20171d7592bfa0bf8fa3b44028424595be85e0
35d2307https://github.com/nodejs/node/commit/35d2307849947da2b2455f0679e149796e796b02
cf20171https://github.com/nodejs/node/commit/cf20171d7592bfa0bf8fa3b44028424595be85e0
Compare https://github.com/nodejs/node/compare/35d2307849947da2b2455f0679e149796e796b02..cf20171d7592bfa0bf8fa3b44028424595be85e0
August 20, 2026 06:18https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29725668137
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 20, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#ref-pullrequest-5152993706
ffi: validate DynamicLibrary getter receivers #65288 https://github.com/nodejs/node/pull/65288
https://github.com/trivikr
ffi: validate DynamicLibrary getter receivershttps://github.com/nodejs/node/pull/65415/commits/81501012078250fe50655fc6652f8a469be4d790
8150101https://github.com/nodejs/node/pull/65415/commits/81501012078250fe50655fc6652f8a469be4d790
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/cf20171d7592bfa0bf8fa3b44028424595be85e0..81501012078250fe50655fc6652f8a469be4d790
cf20171https://github.com/nodejs/node/commit/cf20171d7592bfa0bf8fa3b44028424595be85e0
8150101https://github.com/nodejs/node/commit/81501012078250fe50655fc6652f8a469be4d790
Compare https://github.com/nodejs/node/compare/cf20171d7592bfa0bf8fa3b44028424595be85e0..81501012078250fe50655fc6652f8a469be4d790
August 20, 2026 06:28https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29726034086
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Aug 20, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#pullrequestreview-4979781245
View reviewed changes https://github.com/nodejs/node/pull/65415/files/81501012078250fe50655fc6652f8a469be4d790
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29726756248
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29727826996
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#issuecomment-5352632052
https://ci.nodejs.org/job/node-test-pull-request/76037/https://ci.nodejs.org/job/node-test-pull-request/76037/
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#issuecomment-5353228651
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65415?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2899539https://app.codecov.io/gh/nodejs/node/commit/28995396b22b60ab00e467419ba118842059047f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8150101https://app.codecov.io/gh/nodejs/node/commit/81501012078250fe50655fc6652f8a469be4d790?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65415?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/65415?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65415/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 20, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-29749619572
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
abb365ahttps://github.com/nodejs/node/commit/abb365abea80915022c81908bea42d321d8377f4
Aug 27, 2026https://github.com/nodejs/node/pull/65415#event-30087535763
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 27, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#issuecomment-5435499083
abb365ahttps://github.com/nodejs/node/commit/abb365abea80915022c81908bea42d321d8377f4
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 27, 2026https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-30087546753
aduh95https://github.com/aduh95
Aug 29, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#ref-commit-5559e1b
https://github.com/trivikr
https://github.com/aduh95
ffi: validate DynamicLibrary getter receivershttps://github.com/nodejs/node/commit/5559e1b3ae4d45a3461e512a246e14b22c438ecd
5559e1bhttps://github.com/nodejs/node/commit/5559e1b3ae4d45a3461e512a246e14b22c438ecd
#65415https://github.com/nodejs/node/pull/65415
#65287https://github.com/nodejs/node/issues/65287
aduh95https://github.com/aduh95
Sep 3, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#ref-commit-de27fd7
https://github.com/trivikr
https://github.com/aduh95
ffi: validate DynamicLibrary getter receivershttps://github.com/nodejs/node/commit/de27fd7fd34b8591b2a5652e17ebae2e2107aee4
de27fd7https://github.com/nodejs/node/commit/de27fd7fd34b8591b2a5652e17ebae2e2107aee4
#65415https://github.com/nodejs/node/pull/65415
#65287https://github.com/nodejs/node/issues/65287
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 7, 2026 01:16https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#event-30659287821
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#ref-pullrequest-5376777990
Version 26.9.0 (Current) #65881 https://github.com/nodejs/node/pull/65881
aduh95https://github.com/aduh95
Sep 15, 2026 https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}#ref-commit-bdcb6de
https://github.com/trivikr
https://github.com/aduh95
ffi: validate DynamicLibrary getter receivershttps://github.com/nodejs/node/commit/bdcb6def4e6e4abd67842cc88405bb917073040c
bdcb6dehttps://github.com/nodejs/node/commit/bdcb6def4e6e4abd67842cc88405bb917073040c
#65415https://github.com/nodejs/node/pull/65415
#65287https://github.com/nodejs/node/issues/65287
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65415
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/65415/files/81501012078250fe50655fc6652f8a469be4d790
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: DynamicLibrary getters crash on incompatible receivers https://github.com/nodejs/node/issues/65287
Please reload this pagehttps://github.com/nodejs/node/pull/65415/{{ revealButtonHref }}
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.