René's URL Explorer Experiment


Title: module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback by caiolima · Pull Request #65375 · nodejs/node · GitHub

Open Graph Title: module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback by caiolima · Pull Request #65375 · nodejs/node

X Title: module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback by caiolima · Pull Request #65375 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 an...

X Description: This PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/813113...

Opengraph URL: https://github.com/nodejs/node/pull/65375

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f3976acc-a6ec-0397-c23e-588fe83fb3c1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE22A:F5278:7542D:9C7CC:6AED0422
html-safe-nonce569cddc787e12c03f51d6be8d96d960ab6531d212edf7d38d8730abd14f2d44d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjJBOkY1Mjc4Ojc1NDJEOjlDN0NDOjZBRUQwNDIyIiwidmlzaXRvcl9pZCI6Ijg3NjgyMjI3ODc5NDQ2NDU2NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac878a789a00db9e3dedf66aa636f1dfe1669e4cd29125dfdfc20ae78f7999fc94
hovercard-subject-tagpull_request:4303692932
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65375/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8a88f447196393371e54280263efddc365f153cc012e881fc7c8faedc65bf353/nodejs/node/pull/65375
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a88f447196393371e54280263efddc365f153cc012e881fc7c8faedc65bf353/nodejs/node/pull/65375
og:image:altThis PR doesn't change any behavior, and the motivation is to properly align with new V8 Synthetic Module API changes introduced by https://chromium-review.googlesource.com/c/v8/v8/+/8131138 an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecaiolima
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65375#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65375
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65375
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65375
Reloadhttps://github.com/nodejs/node/pull/65375
Reloadhttps://github.com/nodejs/node/pull/65375
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
caiolimahttps://github.com/caiolima
nodejs:mainhttps://github.com/nodejs/node/tree/main
caiolima:prepare-evaluation-stepshttps://github.com/caiolima/node/tree/prepare-evaluation-steps
Conversationhttps://github.com/nodejs/node/pull/65375
Commits3 (3)https://github.com/nodejs/node/pull/65375/commits
Checkshttps://github.com/nodejs/node/pull/65375/checks
Files changedhttps://github.com/nodejs/node/pull/65375/files
module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallbackhttps://github.com/nodejs/node/pull/65375#top
caiolimahttps://github.com/caiolima
nodejs:mainhttps://github.com/nodejs/node/tree/main
caiolima:prepare-evaluation-stepshttps://github.com/caiolima/node/tree/prepare-evaluation-steps
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Aug 18, 2026https://github.com/nodejs/node/pull/65375#issue-5180733073
https://chromium-review.googlesource.com/c/v8/v8/+/8131138https://chromium-review.googlesource.com/c/v8/v8/+/8131138
https://chromium-review.googlesource.com/c/v8/v8/+/8223168https://chromium-review.googlesource.com/c/v8/v8/+/8223168
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5326856705
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 18, 2026https://github.com/nodejs/node/pull/65375#event-29612611587
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Aug 18, 2026 https://github.com/nodejs/node/pull/65375#pullrequestreview-4959954802
View reviewed changes https://github.com/nodejs/node/pull/65375/files
deps/v8/include/v8-script.hhttps://github.com/nodejs/node/pull/65375/files#diff-cca91c8b8b3bbf15522b5e9176dbf57deb837057bafe5cc8b68d7c3fa5830e63
caiolimahttps://github.com/caiolima
Aug 18, 2026https://github.com/nodejs/node/pull/65375#discussion_r3803183847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Aug 18, 2026 https://github.com/nodejs/node/pull/65375#pullrequestreview-4959956981
View reviewed changes https://github.com/nodejs/node/pull/65375/files
deps/v8/src/api/api.cchttps://github.com/nodejs/node/pull/65375/files#diff-60e334fb7186127fb279e7e787b567cf0c6aaca9c993d94391447939a39022aa
caiolimahttps://github.com/caiolima
Aug 18, 2026https://github.com/nodejs/node/pull/65375#discussion_r3803185662
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 18, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5328751838
Please reload this pagehttps://github.com/nodejs/node/pull/65375
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65375?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ccd648ehttps://app.codecov.io/gh/nodejs/node/commit/ccd648eb0cf0bbf1fee0ffa9a6fc91f9101ce508?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e13bcfahttps://app.codecov.io/gh/nodejs/node/commit/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/module_wrap.cchttps://app.codecov.io/gh/nodejs/node/pull/65375?src=pr&el=tree&filepath=src%2Fmodule_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL21vZHVsZV93cmFwLmNj
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65375?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/module_wrap.hhttps://app.codecov.io/gh/nodejs/node/pull/65375?src=pr&el=tree&filepath=src%2Fmodule_wrap.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL21vZHVsZV93cmFwLmg=
src/module_wrap.cchttps://app.codecov.io/gh/nodejs/node/pull/65375?src=pr&el=tree&filepath=src%2Fmodule_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL21vZHVsZV93cmFwLmNj
19 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65375/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Aug 18, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5329261730
https://chromium-review.googlesource.com/c/chromium/src/+/8257345https://chromium-review.googlesource.com/c/chromium/src/+/8257345
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 18, 2026 https://github.com/nodejs/node/pull/65375#pullrequestreview-4962568813
View reviewed changes https://github.com/nodejs/node/pull/65375/files
deps/v8/include/v8-script.hhttps://github.com/nodejs/node/pull/65375/files#diff-cca91c8b8b3bbf15522b5e9176dbf57deb837057bafe5cc8b68d7c3fa5830e63
joyeecheunghttps://github.com/joyeecheung
Aug 18, 2026https://github.com/nodejs/node/pull/65375#discussion_r3805312523
Please reload this pagehttps://github.com/nodejs/node/pull/65375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#65161https://github.com/nodejs/node/pull/65161
Please reload this pagehttps://github.com/nodejs/node/pull/65375
caiolimahttps://github.com/caiolima
Aug 18, 2026https://github.com/nodejs/node/pull/65375#discussion_r3805568386
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
dont-land-on-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v24.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
dont-land-on-v26.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v26.x
Aug 18, 2026https://github.com/nodejs/node/pull/65375#event-29627618357
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Aug 18, 2026 https://github.com/nodejs/node/pull/65375#pullrequestreview-4962585953
View reviewed changes https://github.com/nodejs/node/pull/65375/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 18, 2026https://github.com/nodejs/node/pull/65375#event-29627655248
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 18, 2026https://github.com/nodejs/node/pull/65375#event-29628497551
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5330284243
https://ci.nodejs.org/job/node-test-pull-request/75968/https://ci.nodejs.org/job/node-test-pull-request/75968/
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 3, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5524336756
@caiolimahttps://github.com/caiolima
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Sep 3, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5530445949
@caiolimahttps://github.com/caiolima
Please reload this pagehttps://github.com/nodejs/node/pull/65375
caiolimahttps://github.com/caiolima
September 4, 2026 14:34https://github.com/nodejs/node/pull/65375#commits-pushed-e32d96a
https://github.com/caiolima
deps: V8: backport e7785934cd73https://github.com/nodejs/node/pull/65375/commits/e32d96ad2d2d06209a10ec00dd1450c8b357dcfa
e32d96ahttps://github.com/nodejs/node/pull/65375/commits/e32d96ad2d2d06209a10ec00dd1450c8b357dcfa
https://chromium-review.googlesource.com/c/v8/v8/+/8131138https://chromium-review.googlesource.com/c/v8/v8/+/8131138
v8/v8@e778593https://github.com/v8/v8/commit/e7785934cd7355fe813660140abd73f4d4886290
https://github.com/caiolima
deps: V8: backport 970d651e4f99https://github.com/nodejs/node/pull/65375/commits/1a06647e1f8d617ac6dc40e376061b8886ae4a0f
1a06647https://github.com/nodejs/node/pull/65375/commits/1a06647e1f8d617ac6dc40e376061b8886ae4a0f
https://chromium-review.googlesource.com/c/v8/v8/+/8223168https://chromium-review.googlesource.com/c/v8/v8/+/8223168
v8/v8@970d651https://github.com/v8/v8/commit/970d651e4f9975430f9f4cf7e8c45ba7566f52a2
https://github.com/caiolima
Change ModuleWrap::SyntheticModuleEvaluationStepsCallback to return a…https://github.com/nodejs/node/pull/65375/commits/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
e13bcfahttps://github.com/nodejs/node/pull/65375/commits/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
https://github.com/caiolima
caiolimahttps://github.com/caiolima
force-pushedhttps://github.com/nodejs/node/compare/579df3c898577ebca9bc4069d7ce0d50edeefe6f..e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
579df3chttps://github.com/nodejs/node/commit/579df3c898577ebca9bc4069d7ce0d50edeefe6f
e13bcfahttps://github.com/nodejs/node/commit/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
Compare https://github.com/nodejs/node/compare/579df3c898577ebca9bc4069d7ce0d50edeefe6f..e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
September 4, 2026 18:43https://github.com/nodejs/node/pull/65375#event-30574804183
https://github.com/caiolima
caiolimahttps://github.com/caiolima
Sep 4, 2026https://github.com/nodejs/node/pull/65375#issuecomment-5545040839
@caiolimahttps://github.com/caiolima
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Sep 4, 2026 https://github.com/nodejs/node/pull/65375#pullrequestreview-5117952505
View reviewed changes https://github.com/nodejs/node/pull/65375/files/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65375
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65375/files/e13bcfa1b3881b1c9a6f6b2eb8913b57ba7f43d2
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/65375/files/579df3c898577ebca9bc4069d7ce0d50edeefe6f
Please reload this pagehttps://github.com/nodejs/node/pull/65375
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
dont-land-on-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v24.x
dont-land-on-v26.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v26.x
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65375
https://github.com/caiolima
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.