René's URL Explorer Experiment


Title: vfs: reject rename onto a non-empty directory by dibenkobit · Pull Request #65373 · nodejs/node · GitHub

Open Graph Title: vfs: reject rename onto a non-empty directory by dibenkobit · Pull Request #65373 · nodejs/node

X Title: vfs: reject rename onto a non-empty directory by dibenkobit · Pull Request #65373 · nodejs/node

Description: POSIX requires the destination of a directory rename to be an empty directory. fs.renameSync() reports ENOTEMPTY because the OS enforces it, and RealFSProvider inherits that by delegating to the real filesystem. MemoryProvider has no OS underneath, so it implements these rules itself — it already covers EISDIR, ENOTDIR and EINVAL, but not this one: it renamed over a non-empty directory and silently discarded its contents. Assisted-By: Claude Code (Claude Opus 5)

Open Graph Description: POSIX requires the destination of a directory rename to be an empty directory. fs.renameSync() reports ENOTEMPTY because the OS enforces it, and RealFSProvider inherits that by delegating to the re...

X Description: POSIX requires the destination of a directory rename to be an empty directory. fs.renameSync() reports ENOTEMPTY because the OS enforces it, and RealFSProvider inherits that by delegating to the re...

Opengraph URL: https://github.com/nodejs/node/pull/65373

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a074748-ab21-5278-7167-e99a870db693
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE018:85DE2:340958:487900:6AEDB503
html-safe-nonce4443f26d5d9f794afd0586e51c57f1cd90f1093f478358254ee9b7f92b9c11f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDE4Ojg1REUyOjM0MDk1ODo0ODc5MDA6NkFFREI1MDMiLCJ2aXNpdG9yX2lkIjoiMjQ0MTMxOTM2NjI4ODg0ODEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfcca9bad58f82bf1be1d4762df28beb0e11cc9fa72f51bf2671956e41f38680c
hovercard-subject-tagpull_request:4301994786
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
twitter:imagehttps://avatars.githubusercontent.com/u/52064487?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52064487?s=400&v=4
og:image:altPOSIX requires the destination of a directory rename to be an empty directory. fs.renameSync() reports ENOTEMPTY because the OS enforces it, and RealFSProvider inherits that by delegating to the re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee40242599af5e7da0f281843dec7492c322688d4a48caeea85f9fb8e41c8ea53
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89cbf2bb52a24fc179bf5925abba0ba574b262ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65373%2Ffiles%2F397f5ab3a56007bd30e90c0760fb75f3fbb875bf
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65373%2Ffiles%2F397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Reloadhttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Reloadhttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests664 (664)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
dibenkobithttps://github.com/dibenkobit
nodejs:mainhttps://github.com/nodejs/node/tree/main
dibenkobit:vfs-rename-enotemptyhttps://github.com/dibenkobit/node/tree/vfs-rename-enotempty
Conversation 2 https://github.com/nodejs/node/pull/65373
Commits 1 https://github.com/nodejs/node/pull/65373/commits
Checks 9 https://github.com/nodejs/node/pull/65373/checks
Files changed https://github.com/nodejs/node/pull/65373/files
Please reload this pagehttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
vfs: reject rename onto a non-empty directory https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#top
Show all changes 1 commit https://github.com/nodejs/node/pull/65373/files
397f5ab vfs: reject rename onto a non-empty directory dibenkobit Aug 18, 2026 https://github.com/nodejs/node/pull/65373/commits/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Clear filters https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Please reload this pagehttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
Please reload this pagehttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
memory.js https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
test-vfs-rename.js https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-de692ebae7d07b17e039bdb461d5eaed5f0efb4f9ea750cada2ffae371335d29
lib/internal/vfs/providers/memory.jshttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
View file https://github.com/dibenkobit/node/blob/397f5ab3a56007bd30e90c0760fb75f3fbb875bf/lib/internal/vfs/providers/memory.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65373/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
test/parallel/test-vfs-rename.jshttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-de692ebae7d07b17e039bdb461d5eaed5f0efb4f9ea750cada2ffae371335d29
View file https://github.com/dibenkobit/node/blob/397f5ab3a56007bd30e90c0760fb75f3fbb875bf/test/parallel/test-vfs-rename.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65373/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf#diff-de692ebae7d07b17e039bdb461d5eaed5f0efb4f9ea750cada2ffae371335d29
Please reload this pagehttps://github.com/nodejs/node/pull/65373/files/397f5ab3a56007bd30e90c0760fb75f3fbb875bf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.