René's URL Explorer Experiment


Title: test_runner: fix junit report on empty diagnostic by lazerg · Pull Request #65357 · nodejs/node · GitHub

Open Graph Title: test_runner: fix junit report on empty diagnostic by lazerg · Pull Request #65357 · nodejs/node

X Title: test_runner: fix junit report on empty diagnostic by lazerg · Pull Request #65357 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: context.diagnostic('') makes the junit reporter throw. treeToXML guards the comment branch with if (comment), so an empty message falls through to the element branch and ObjectEntries(attrs...

X Description: context.diagnostic('') makes the junit reporter throw. treeToXML guards the comment branch with if (comment), so an empty message falls through to the element branch and ObjectEntri...

Opengraph URL: https://github.com/nodejs/node/pull/65357

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7539568-5a9a-0128-4ff6-38abe5f79af8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id803A:242B39:1BBFAF:262704:6AED0B8E
html-safe-nonce5447e89343071ab7a2a8fd8930fda5f8cd50bdb1ffab488efe4c14de742d1ba2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDNBOjI0MkIzOToxQkJGQUY6MjYyNzA0OjZBRUQwQjhFIiwidmlzaXRvcl9pZCI6IjM4MjgwODMyOTg3ODkwMzQ4OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1162df03364e5a88c5a5f5697ab0c0f16f2709e9fbf48b44fc18f66e33ea6bfe
hovercard-subject-tagpull_request:4298510703
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65357/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4b1048f647a5307d613d3d49f2550a9826d6da8f9703927cc5eb71a75b7e7420/nodejs/node/pull/65357
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b1048f647a5307d613d3d49f2550a9826d6da8f9703927cc5eb71a75b7e7420/nodejs/node/pull/65357
og:image:altcontext.diagnostic('') makes the junit reporter throw. treeToXML guards the comment branch with if (comment), so an empty message falls through to the element branch and ObjectEntries(attrs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65357#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65357
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65357
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65357
Reloadhttps://github.com/nodejs/node/pull/65357
Reloadhttps://github.com/nodejs/node/pull/65357
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65355-junit-empty-diagnostichttps://github.com/lazerg/node/tree/fix/issue-65355-junit-empty-diagnostic
Conversationhttps://github.com/nodejs/node/pull/65357
Commits1 (1)https://github.com/nodejs/node/pull/65357/commits
Checkshttps://github.com/nodejs/node/pull/65357/checks
Files changedhttps://github.com/nodejs/node/pull/65357/files
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/pull/65357#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65355-junit-empty-diagnostichttps://github.com/lazerg/node/tree/fix/issue-65355-junit-empty-diagnostic
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 17, 2026https://github.com/nodejs/node/pull/65357#issue-5174552541
#65355https://github.com/nodejs/node/issues/65355
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5319052334
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Aug 17, 2026https://github.com/nodejs/node/pull/65357#event-29576793726
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Aug 17, 2026 https://github.com/nodejs/node/pull/65357#pullrequestreview-4953873108
View reviewed changes https://github.com/nodejs/node/pull/65357/files
atlowChemihttps://github.com/atlowChemi
https://github.com/nodejs/node/pull/65357#pullrequestreview-4953873108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
node/test/test-runner/test-output-abort-hooks.mjshttps://github.com/nodejs/node/blob/3781ebc149d58cf4604403f48c6109b6a9833b22/test/test-runner/test-output-abort-hooks.mjs#L1
3781ebchttps://github.com/nodejs/node/commit/3781ebc149d58cf4604403f48c6109b6a9833b22
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/lazerg
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/pull/65357/commits/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
0a00f28https://github.com/nodejs/node/pull/65357/commits/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/lazerg
lazerghttps://github.com/lazerg
force-pushedhttps://github.com/nodejs/node/compare/f70a69336f7fedd7386c8bd0fb66f3efa05cbf06..0a00f2828d883ee34e31f92b7b8ce6b238b5d320
f70a693https://github.com/nodejs/node/commit/f70a69336f7fedd7386c8bd0fb66f3efa05cbf06
0a00f28https://github.com/nodejs/node/commit/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
Compare https://github.com/nodejs/node/compare/f70a69336f7fedd7386c8bd0fb66f3efa05cbf06..0a00f2828d883ee34e31f92b7b8ce6b238b5d320
August 17, 2026 19:43https://github.com/nodejs/node/pull/65357#event-29578486104
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 17, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5319429429
0a00f28https://github.com/nodejs/node/commit/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 17, 2026 https://github.com/nodejs/node/pull/65357#pullrequestreview-4954001505
View reviewed changes https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65357#event-29578578359
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65357#event-29578666074
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5319473020
https://ci.nodejs.org/job/node-test-pull-request/75948/https://ci.nodejs.org/job/node-test-pull-request/75948/
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
Aug 17, 2026 https://github.com/nodejs/node/pull/65357#pullrequestreview-4954174990
View reviewed changes https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/atlowChemi
atlowChemihttps://github.com/atlowChemi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 17, 2026https://github.com/nodejs/node/pull/65357#event-29579653300
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 17, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5320394761
Please reload this pagehttps://github.com/nodejs/node/pull/65357
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65357?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6456418https://app.codecov.io/gh/nodejs/node/commit/6456418ac1751774abacd7b3f05b5916732495a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0a00f28https://app.codecov.io/gh/nodejs/node/commit/0a00f2828d883ee34e31f92b7b8ce6b238b5d320?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65357?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/test_runner/reporter/junit.jshttps://app.codecov.io/gh/nodejs/node/pull/65357?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Freporter%2Fjunit.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL3JlcG9ydGVyL2p1bml0Lmpz
30 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Aug 19, 2026 https://github.com/nodejs/node/pull/65357#pullrequestreview-4971531281
View reviewed changes https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5341419554
https://ci.nodejs.org/job/node-test-pull-request/75989/https://ci.nodejs.org/job/node-test-pull-request/75989/
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/MoLow
MoLowhttps://github.com/MoLow
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 19, 2026https://github.com/nodejs/node/pull/65357#event-29690854001
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
03fb384https://github.com/nodejs/node/commit/03fb38410b23eb7e443bfe586c212e3185aad86e
Aug 19, 2026https://github.com/nodejs/node/pull/65357#event-29703428243
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2026https://github.com/nodejs/node/pull/65357#issuecomment-5346964181
03fb384https://github.com/nodejs/node/commit/03fb38410b23eb7e443bfe586c212e3185aad86e
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 19, 2026https://github.com/nodejs/node/pull/65357#event-29703431145
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65357#ref-commit-af8df85
https://github.com/lazerg
https://github.com/aduh95
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/af8df85278ad9efd67f92e151e2bd28396865829
af8df85https://github.com/nodejs/node/commit/af8df85278ad9efd67f92e151e2bd28396865829
#65357https://github.com/nodejs/node/pull/65357
#65355https://github.com/nodejs/node/issues/65355
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65357#ref-commit-9572a0b
https://github.com/lazerg
https://github.com/aduh95
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/9572a0b15fb36ef2e40e16c454a2e504975bf867
9572a0bhttps://github.com/nodejs/node/commit/9572a0b15fb36ef2e40e16c454a2e504975bf867
#65357https://github.com/nodejs/node/pull/65357
#65355https://github.com/nodejs/node/issues/65355
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65357#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65357#ref-commit-dfaa058
https://github.com/lazerg
https://github.com/aduh95
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/dfaa058f77518102459e71561ae196069666e735
dfaa058https://github.com/nodejs/node/commit/dfaa058f77518102459e71561ae196069666e735
#65357https://github.com/nodejs/node/pull/65357
#65355https://github.com/nodejs/node/issues/65355
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65357#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65357#ref-commit-02d44f2
https://github.com/lazerg
https://github.com/aduh95
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/02d44f2ede6ebbc88fa56cdd1a4b4cc64318cf41
02d44f2https://github.com/nodejs/node/commit/02d44f2ede6ebbc88fa56cdd1a4b4cc64318cf41
#65357https://github.com/nodejs/node/pull/65357
#65355https://github.com/nodejs/node/issues/65355
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65357#ref-commit-6a248ac
https://github.com/lazerg
https://github.com/aduh95
test_runner: fix junit report on empty diagnostichttps://github.com/nodejs/node/commit/6a248acefe2483c67926abe5e237b00661292586
6a248achttps://github.com/nodejs/node/commit/6a248acefe2483c67926abe5e237b00661292586
#65357https://github.com/nodejs/node/pull/65357
#65355https://github.com/nodejs/node/issues/65355
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65357
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
https://github.com/atlowChemi
atlowChemi https://github.com/atlowChemi
https://github.com/nodejs/node/pull/65357/files/0a00f2828d883ee34e31f92b7b8ce6b238b5d320
Please reload this pagehttps://github.com/nodejs/node/pull/65357
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
test_runner: JUnit report is truncated when a failed test triggers empty context.diagnostic() https://github.com/nodejs/node/issues/65355
Please reload this pagehttps://github.com/nodejs/node/pull/65357
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com/MoLow
https://github.com/atlowChemi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.