René's URL Explorer Experiment


Title: stream: reject pull on signal abort during flush by trivikr · Pull Request #65346 · nodejs/node · GitHub

Open Graph Title: stream: reject pull on signal abort during flush by trivikr · Pull Request #65346 · nodejs/node

X Title: stream: reject pull on signal abort during flush by trivikr · Pull Request #65346 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65345 An asynchronous transform can abort the pipeline while its final flush resolves to null. With no final batch yielded, the pipeline previously completed without observing the abort. Ch...

X Description: Fixes: #65345 An asynchronous transform can abort the pipeline while its final flush resolves to null. With no final batch yielded, the pipeline previously completed without observing the abort. Ch...

Opengraph URL: https://github.com/nodejs/node/pull/65346

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f76d3280-cc13-765f-18e5-483166be357f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB81A:2AB5E3:1690A6:1D6D66:6AED1529
html-safe-nonce3f2c2045e68dfcbb027495913a4aea94333e2c47138acb474d6682e7544ca645
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODFBOjJBQjVFMzoxNjkwQTY6MUQ2RDY2OjZBRUQxNTI5IiwidmlzaXRvcl9pZCI6IjY3NTY1ODk0ODM3OTgxMDc0MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7b9973a5adfb59e554f64957c7b60266370ae51c6442827f2e6126b9a1c45edc
hovercard-subject-tagpull_request:4293510337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65346/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ddcf0f6220dbbf91301c7da4f18e8856f260a66572aee13e09b0921446903f86/nodejs/node/pull/65346
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ddcf0f6220dbbf91301c7da4f18e8856f260a66572aee13e09b0921446903f86/nodejs/node/pull/65346
og:image:altFixes: #65345 An asynchronous transform can abort the pipeline while its final flush resolves to null. With no final batch yielded, the pipeline previously completed without observing the abort. Ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65346#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65346
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65346
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65346
Reloadhttps://github.com/nodejs/node/pull/65346
Reloadhttps://github.com/nodejs/node/pull/65346
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-pull-abort-swallowhttps://github.com/trivikr/node/tree/stream-iter-pull-abort-swallow
Conversationhttps://github.com/nodejs/node/pull/65346
Commits1 (1)https://github.com/nodejs/node/pull/65346/commits
Checkshttps://github.com/nodejs/node/pull/65346/checks
Files changedhttps://github.com/nodejs/node/pull/65346/files
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/pull/65346#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-pull-abort-swallowhttps://github.com/trivikr/node/tree/stream-iter-pull-abort-swallow
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 17, 2026https://github.com/nodejs/node/pull/65346#issue-5168592392
#65345https://github.com/nodejs/node/issues/65345
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/trivikr
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/pull/65346/commits/13ab435f11d6112a7edd095d3530c81c0f22e82a
13ab435https://github.com/nodejs/node/pull/65346/commits/13ab435f11d6112a7edd095d3530c81c0f22e82a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65346#issuecomment-5312186305
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 17, 2026https://github.com/nodejs/node/pull/65346#event-29544003539
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65346#event-29544009388
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 17, 2026 https://github.com/nodejs/node/pull/65346#pullrequestreview-4948975003
View reviewed changes https://github.com/nodejs/node/pull/65346/files/13ab435f11d6112a7edd095d3530c81c0f22e82a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65346#event-29546331545
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65346#issuecomment-5312666775
https://ci.nodejs.org/job/node-test-pull-request/75911/https://ci.nodejs.org/job/node-test-pull-request/75911/
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 17, 2026https://github.com/nodejs/node/pull/65346#issuecomment-5312936957
Please reload this pagehttps://github.com/nodejs/node/pull/65346
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65346?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
977c20ehttps://app.codecov.io/gh/nodejs/node/commit/977c20ed675e9c240e841ccf9edd06c5a4b239a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
13ab435https://app.codecov.io/gh/nodejs/node/commit/13ab435f11d6112a7edd095d3530c81c0f22e82a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65346?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/pull.jshttps://app.codecov.io/gh/nodejs/node/pull/65346?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpull.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdWxsLmpz
25 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65346/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 17, 2026 https://github.com/nodejs/node/pull/65346#pullrequestreview-4952121856
View reviewed changes https://github.com/nodejs/node/pull/65346/files/13ab435f11d6112a7edd095d3530c81c0f22e82a
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65346#event-29565800677
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c79868fhttps://github.com/nodejs/node/commit/c79868f1020c0020ca0db328b90e267ba003c91c
Aug 19, 2026https://github.com/nodejs/node/pull/65346#event-29662372721
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2026https://github.com/nodejs/node/pull/65346#issuecomment-5337972384
c79868fhttps://github.com/nodejs/node/commit/c79868f1020c0020ca0db328b90e267ba003c91c
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 19, 2026https://github.com/nodejs/node/pull/65346#event-29662374629
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65346#ref-commit-1878499
https://github.com/trivikr
https://github.com/aduh95
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/commit/18784997b202932ff6d45ae75d6a8162a5c5014c
1878499https://github.com/nodejs/node/commit/18784997b202932ff6d45ae75d6a8162a5c5014c
#65346https://github.com/nodejs/node/pull/65346
#65345https://github.com/nodejs/node/issues/65345
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65346#ref-commit-a9dc50d
https://github.com/trivikr
https://github.com/aduh95
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/commit/a9dc50d275e342b831ff7ee1f02d11c403a4c860
a9dc50dhttps://github.com/nodejs/node/commit/a9dc50d275e342b831ff7ee1f02d11c403a4c860
#65346https://github.com/nodejs/node/pull/65346
#65345https://github.com/nodejs/node/issues/65345
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65346#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65346#ref-commit-b532ba1
https://github.com/trivikr
https://github.com/aduh95
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/commit/b532ba1cda86015fb86949129167251b84889e70
b532ba1https://github.com/nodejs/node/commit/b532ba1cda86015fb86949129167251b84889e70
#65346https://github.com/nodejs/node/pull/65346
#65345https://github.com/nodejs/node/issues/65345
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 7, 2026 01:16https://github.com/nodejs/node/pull/65346#event-30659293476
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65346#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65346#ref-commit-6dc4207
https://github.com/trivikr
https://github.com/aduh95
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/commit/6dc420780411f4d14761c8a7b301a38396c5945b
6dc4207https://github.com/nodejs/node/commit/6dc420780411f4d14761c8a7b301a38396c5945b
#65346https://github.com/nodejs/node/pull/65346
#65345https://github.com/nodejs/node/issues/65345
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65346#ref-commit-b8a7a75
https://github.com/trivikr
https://github.com/aduh95
stream: reject pull on signal abort during flushhttps://github.com/nodejs/node/commit/b8a7a75b19150f305a7639ff05c7853fb3d80e2a
b8a7a75https://github.com/nodejs/node/commit/b8a7a75b19150f305a7639ff05c7853fb3d80e2a
#65346https://github.com/nodejs/node/pull/65346
#65345https://github.com/nodejs/node/issues/65345
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65346
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65346/files/13ab435f11d6112a7edd095d3530c81c0f22e82a
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/65346/files/13ab435f11d6112a7edd095d3530c81c0f22e82a
Please reload this pagehttps://github.com/nodejs/node/pull/65346
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: pull() swallows abort when async transform flush resolves to null https://github.com/nodejs/node/issues/65345
Please reload this pagehttps://github.com/nodejs/node/pull/65346
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.