René's URL Explorer Experiment


Title: ffi: validate the value passed to the float setters by soulee-dev · Pull Request #65342 · nodejs/node · GitHub

Open Graph Title: ffi: validate the value passed to the float setters by soulee-dev · Pull Request #65342 · nodejs/node

X Title: ffi: validate the value passed to the float setters by soulee-dev · Pull Request #65342 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Problem Every other setter in SetValue<T>() requires IsNumber() before it writes, so setInt8(ptr, 0, '5') throws. The floating-point branch calls ToNumber() instead, so setFloat64(ptr...

X Description: Problem Every other setter in SetValue&lt;T&gt;() requires IsNumber() before it writes, so setInt8(ptr, 0, &#39;5&#39;) throws. The floating-point branch calls ToNumber() instead, s...

Opengraph URL: https://github.com/nodejs/node/pull/65342

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aca07686-ac8b-9dfa-e999-304535df85d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C0E:66F8F:35174B:4879FB:6AED13FB
html-safe-noncef0633ab54c4586e04ab7b395a8b96a03ec0f562d05f59cd669190bcd8e777d49
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzBFOjY2RjhGOjM1MTc0Qjo0ODc5RkI6NkFFRDEzRkIiLCJ2aXNpdG9yX2lkIjoiMjgyMzU3MDYxMzgxOTIxNjg5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ac7c129bc070d782070ba6cb3cc9321238630d5c441d05a5dee0ece65de33d0
hovercard-subject-tagpull_request:4292286152
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65342/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2e9b379193f085d4e48f9bfd37ec2d198a2fcc6699d9355ff2012d9637065e63/nodejs/node/pull/65342
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e9b379193f085d4e48f9bfd37ec2d198a2fcc6699d9355ff2012d9637065e63/nodejs/node/pull/65342
og:image:altProblem Every other setter in SetValue<T>() requires IsNumber() before it writes, so setInt8(ptr, 0, '5') throws. The floating-point branch calls ToNumber() instead, so setFloat64(ptr...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesoulee-dev
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65342#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65342
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65342
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65342
Reloadhttps://github.com/nodejs/node/pull/65342
Reloadhttps://github.com/nodejs/node/pull/65342
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
soulee-dev:ffi-validate-float-settershttps://github.com/soulee-dev/node/tree/ffi-validate-float-setters
Conversationhttps://github.com/nodejs/node/pull/65342
Commits1 (1)https://github.com/nodejs/node/pull/65342/commits
Checkshttps://github.com/nodejs/node/pull/65342/checks
Files changedhttps://github.com/nodejs/node/pull/65342/files
ffi: validate the value passed to the float settershttps://github.com/nodejs/node/pull/65342#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
soulee-dev:ffi-validate-float-settershttps://github.com/soulee-dev/node/tree/ffi-validate-float-setters
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
Aug 17, 2026https://github.com/nodejs/node/pull/65342#issue-5167120221
Please reload this pagehttps://github.com/nodejs/node/pull/65342
#65341https://github.com/nodejs/node/issues/65341
#62858https://github.com/nodejs/node/pull/62858
#64614https://github.com/nodejs/node/pull/64614
#64691https://github.com/nodejs/node/pull/64691
#65032https://github.com/nodejs/node/pull/65032
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/soulee-dev
ffi: validate the value passed to the float settershttps://github.com/nodejs/node/pull/65342/commits/f26b00eeaf778be9b649b42dade02fff03928276
f26b00ehttps://github.com/nodejs/node/pull/65342/commits/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65342#issuecomment-5310499139
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65342#event-29536038030
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
Aug 17, 2026 https://github.com/nodejs/node/pull/65342#ref-issue-5167119249
ffi: setFloat32()/setFloat64() coerce their value and discard a pending exception #65341 https://github.com/nodejs/node/issues/65341
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 17, 2026https://github.com/nodejs/node/pull/65342#issuecomment-5310963620
Please reload this pagehttps://github.com/nodejs/node/pull/65342
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65342?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ad7a5b8https://app.codecov.io/gh/nodejs/node/commit/ad7a5b8302ae54b6e6dc77e03eabc5a3218dfb85?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
f26b00ehttps://app.codecov.io/gh/nodejs/node/commit/f26b00eeaf778be9b649b42dade02fff03928276?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65342?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/ffi/data.cchttps://app.codecov.io/gh/nodejs/node/pull/65342?src=pr&el=tree&filepath=src%2Fffi%2Fdata.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2ZmaS9kYXRhLmNj
38 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65342/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 19, 2026https://github.com/nodejs/node/pull/65342#event-29659475328
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 19, 2026 https://github.com/nodejs/node/pull/65342#pullrequestreview-4973235116
View reviewed changes https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 19, 2026https://github.com/nodejs/node/pull/65342#event-29688624708
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65342
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2026https://github.com/nodejs/node/pull/65342#issuecomment-5346232329
https://ci.nodejs.org/job/node-test-pull-request/76006/https://ci.nodejs.org/job/node-test-pull-request/76006/
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Aug 19, 2026 https://github.com/nodejs/node/pull/65342#pullrequestreview-4975456962
View reviewed changes https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Aug 19, 2026 https://github.com/nodejs/node/pull/65342#pullrequestreview-4975955613
View reviewed changes https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 19, 2026https://github.com/nodejs/node/pull/65342#event-29706924093
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
f3a8f1ahttps://github.com/nodejs/node/commit/f3a8f1aaf7c862f3c0fd083e8bb81894ea179124
Aug 19, 2026https://github.com/nodejs/node/pull/65342#event-29707673785
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2026https://github.com/nodejs/node/pull/65342#issuecomment-5347932965
f3a8f1ahttps://github.com/nodejs/node/commit/f3a8f1aaf7c862f3c0fd083e8bb81894ea179124
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 19, 2026https://github.com/nodejs/node/pull/65342#event-29707676073
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
Aug 22, 2026 https://github.com/nodejs/node/pull/65342#ref-pullrequest-5220309204
docs: add contribution note for nodejs/node#65342 ossca-node/board#3 https://github.com/ossca-node/board/pull/3
daeyeonhttps://github.com/daeyeon
Aug 22, 2026 https://github.com/nodejs/node/pull/65342#ref-commit-5f54a06
https://github.com/soulee-dev
docs: add contribution note forhttps://github.com/ossca-node/board/commit/5f54a0665810a55e0d8b715e9e3edd86ba2183e5
nodejs/node#65342https://github.com/nodejs/node/pull/65342
(https://github.com/ossca-node/board/commit/5f54a0665810a55e0d8b715e9e3edd86ba2183e5
#3https://github.com/ossca-node/board/pull/3
)https://github.com/ossca-node/board/commit/5f54a0665810a55e0d8b715e9e3edd86ba2183e5
5f54a06https://github.com/ossca-node/board/commit/5f54a0665810a55e0d8b715e9e3edd86ba2183e5
https://github.com/soulee-dev
soulee-devhttps://github.com/soulee-dev
Aug 23, 2026 https://github.com/nodejs/node/pull/65342#ref-issue-5225813193
ffi: memory helpers return undefined instead of throwing when a required argument is omitted #65499 https://github.com/nodejs/node/issues/65499
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65342#ref-commit-938aad4
https://github.com/soulee-dev
https://github.com/aduh95
ffi: validate the value passed to the float settershttps://github.com/nodejs/node/commit/938aad4f0e4f863c5d0398a3993567a9d30dfbb5
938aad4https://github.com/nodejs/node/commit/938aad4f0e4f863c5d0398a3993567a9d30dfbb5
#65342https://github.com/nodejs/node/pull/65342
#65341https://github.com/nodejs/node/issues/65341
#62858https://github.com/nodejs/node/pull/62858
#64614https://github.com/nodejs/node/pull/64614
#64691https://github.com/nodejs/node/pull/64691
#65032https://github.com/nodejs/node/pull/65032
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65342#ref-commit-1fe7a1c
https://github.com/soulee-dev
https://github.com/aduh95
ffi: validate the value passed to the float settershttps://github.com/nodejs/node/commit/1fe7a1c33dee46943e985a052425a8422164513a
1fe7a1chttps://github.com/nodejs/node/commit/1fe7a1c33dee46943e985a052425a8422164513a
#65342https://github.com/nodejs/node/pull/65342
#65341https://github.com/nodejs/node/issues/65341
#62858https://github.com/nodejs/node/pull/62858
#64614https://github.com/nodejs/node/pull/64614
#64691https://github.com/nodejs/node/pull/64691
#65032https://github.com/nodejs/node/pull/65032
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65342#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65342
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/65342/files/f26b00eeaf778be9b649b42dade02fff03928276
Please reload this pagehttps://github.com/nodejs/node/pull/65342
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: setFloat32()/setFloat64() coerce their value and discard a pending exception https://github.com/nodejs/node/issues/65341
Please reload this pagehttps://github.com/nodejs/node/pull/65342
https://github.com/soulee-dev
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com/trivikr
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.