René's URL Explorer Experiment


Title: stream: drain pending writes before broadcast end by trivikr · Pull Request #65334 · nodejs/node · GitHub

Open Graph Title: stream: drain pending writes before broadcast end by trivikr · Pull Request #65334 · nodejs/node

X Title: stream: drain pending writes before broadcast end by trivikr · Pull Request #65334 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65333 Keep processing writes that were queued before end(). Signal the broadcast end only after those writes enter the shared buffer. Resolve end() after all consumers reach end-of-stream. ...

X Description: Fixes: #65333 Keep processing writes that were queued before end(). Signal the broadcast end only after those writes enter the shared buffer. Resolve end() after all consumers reach end-of-stream. ...

Opengraph URL: https://github.com/nodejs/node/pull/65334

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33ea3d8c-249b-4f30-9884-6b5e4497ff28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB84E:3F64F:1B2C9:23354:6AED0F1C
html-safe-nonce7bb18223bdf49a322fc3bce368cdc6838ce77ae65d9a5427cb0c70cb27563212
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODRFOjNGNjRGOjFCMkM5OjIzMzU0OjZBRUQwRjFDIiwidmlzaXRvcl9pZCI6IjgyOTg1NjUwNTE4MTUzNjY0MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace3bcfd1447142548186471ea7e1cb67fa11e6e661210f7d11d0bfdeab1b95b96
hovercard-subject-tagpull_request:4291353159
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65334/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2c4c6df90a67790fb47ebe54454ec34ba6388b42b642db295bb0365f23e372a8/nodejs/node/pull/65334
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c4c6df90a67790fb47ebe54454ec34ba6388b42b642db295bb0365f23e372a8/nodejs/node/pull/65334
og:image:altFixes: #65333 Keep processing writes that were queued before end(). Signal the broadcast end only after those writes enter the shared buffer. Resolve end() after all consumers reach end-of-stream. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65334#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65334
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65334
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65334
Reloadhttps://github.com/nodejs/node/pull/65334
Reloadhttps://github.com/nodejs/node/pull/65334
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-bc-end-stranding-writes-2https://github.com/trivikr/node/tree/stream-iter-bc-end-stranding-writes-2
Conversationhttps://github.com/nodejs/node/pull/65334
Commits1 (1)https://github.com/nodejs/node/pull/65334/commits
Checkshttps://github.com/nodejs/node/pull/65334/checks
Files changedhttps://github.com/nodejs/node/pull/65334/files
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/pull/65334#top
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-bc-end-stranding-writes-2https://github.com/trivikr/node/tree/stream-iter-bc-end-stranding-writes-2
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 16, 2026https://github.com/nodejs/node/pull/65334#issue-5165941103
#65333https://github.com/nodejs/node/issues/65333
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2026https://github.com/nodejs/node/pull/65334#issuecomment-5309201157
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 16, 2026https://github.com/nodejs/node/pull/65334#event-29530256330
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 16, 2026https://github.com/nodejs/node/pull/65334#event-29531888673
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 16, 2026https://github.com/nodejs/node/pull/65334#issuecomment-5309599862
Please reload this pagehttps://github.com/nodejs/node/pull/65334
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65334?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
453f47ahttps://app.codecov.io/gh/nodejs/node/commit/453f47acda92abf75a17dcd419f4a35610cf661b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c28857ehttps://app.codecov.io/gh/nodejs/node/commit/c28857e64c3bd55346f07582d134cee95091f8ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65334?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/65334?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
9 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65334?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65334?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/65334?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65334/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 17, 2026 https://github.com/nodejs/node/pull/65334#pullrequestreview-4948250282
View reviewed changes https://github.com/nodejs/node/pull/65334/files/c28857e64c3bd55346f07582d134cee95091f8ad
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65334#event-29540868194
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65334
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65334
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65334#issuecomment-5321303877
https://ci.nodejs.org/job/node-test-pull-request/75956/https://ci.nodejs.org/job/node-test-pull-request/75956/
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 23, 2026https://github.com/nodejs/node/pull/65334#event-29863061203
https://github.com/trivikr
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/pull/65334/commits/c28857e64c3bd55346f07582d134cee95091f8ad
c28857ehttps://github.com/nodejs/node/pull/65334/commits/c28857e64c3bd55346f07582d134cee95091f8ad
nodejs#65334https://github.com/nodejs/node/pull/65334
nodejs#65333https://github.com/nodejs/node/issues/65333
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/7e864eac5728286c21ba20ca993015a9042386db..c28857e64c3bd55346f07582d134cee95091f8ad
7e864eahttps://github.com/nodejs/node/commit/7e864eac5728286c21ba20ca993015a9042386db
c28857ehttps://github.com/nodejs/node/commit/c28857e64c3bd55346f07582d134cee95091f8ad
Compare https://github.com/nodejs/node/compare/7e864eac5728286c21ba20ca993015a9042386db..c28857e64c3bd55346f07582d134cee95091f8ad
August 23, 2026 20:26https://github.com/nodejs/node/pull/65334#event-29880607007
https://github.com/trivikr
trivikrhttps://github.com/trivikr
c28857ehttps://github.com/nodejs/node/commit/c28857e64c3bd55346f07582d134cee95091f8ad
Aug 23, 2026https://github.com/nodejs/node/pull/65334#event-29880611172
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 23, 2026https://github.com/nodejs/node/pull/65334#issuecomment-5388283234
c28857ehttps://github.com/nodejs/node/commit/c28857e64c3bd55346f07582d134cee95091f8ad
Please reload this pagehttps://github.com/nodejs/node/pull/65334
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65334#ref-commit-ef7c8a8
https://github.com/trivikr
https://github.com/aduh95
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/commit/ef7c8a879ab51b3f1b0591cc99ccf3859bb89540
ef7c8a8https://github.com/nodejs/node/commit/ef7c8a879ab51b3f1b0591cc99ccf3859bb89540
#65334https://github.com/nodejs/node/pull/65334
#65333https://github.com/nodejs/node/issues/65333
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65334#ref-commit-dc51c79
https://github.com/trivikr
https://github.com/aduh95
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/commit/dc51c7926e4f712b4c6e3cfd0d95468ecd570eb8
dc51c79https://github.com/nodejs/node/commit/dc51c7926e4f712b4c6e3cfd0d95468ecd570eb8
#65334https://github.com/nodejs/node/pull/65334
#65333https://github.com/nodejs/node/issues/65333
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65334#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65334#ref-commit-32dbd80
https://github.com/trivikr
https://github.com/aduh95
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/commit/32dbd80d7c6c0ded9237ef57749e4291e6dfa8ec
32dbd80https://github.com/nodejs/node/commit/32dbd80d7c6c0ded9237ef57749e4291e6dfa8ec
#65334https://github.com/nodejs/node/pull/65334
#65333https://github.com/nodejs/node/issues/65333
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 7, 2026 01:16https://github.com/nodejs/node/pull/65334#event-30659286938
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65334#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65334#ref-commit-feb0d57
https://github.com/trivikr
https://github.com/aduh95
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/commit/feb0d5773b5f282871ab109fdf3852187ce73c24
feb0d57https://github.com/nodejs/node/commit/feb0d5773b5f282871ab109fdf3852187ce73c24
#65334https://github.com/nodejs/node/pull/65334
#65333https://github.com/nodejs/node/issues/65333
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65334#ref-commit-93d822b
https://github.com/trivikr
https://github.com/aduh95
stream: drain pending writes before broadcast endhttps://github.com/nodejs/node/commit/93d822bdc14efe5114a22ca6ebcb2ac2d14ee04f
93d822bhttps://github.com/nodejs/node/commit/93d822bdc14efe5114a22ca6ebcb2ac2d14ee04f
#65334https://github.com/nodejs/node/pull/65334
#65333https://github.com/nodejs/node/issues/65333
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65334
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65334/files/c28857e64c3bd55346f07582d134cee95091f8ad
Please reload this pagehttps://github.com/nodejs/node/pull/65334
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: BroadcastWriter.end() strands backpressured writes and truncates the broadcast https://github.com/nodejs/node/issues/65333
Please reload this pagehttps://github.com/nodejs/node/pull/65334
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.