René's URL Explorer Experiment


Title: test: simplify timers interval rejection assertion by HoonDongKang · Pull Request #65322 · nodejs/node · GitHub

Open Graph Title: test: simplify timers interval rejection assertion by HoonDongKang · Pull Request #65322 · nodejs/node

X Title: test: simplify timers interval rejection assertion by HoonDongKang · Pull Request #65322 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Replace a rejection-only try/catch block in test-timers-interval-promisified.js with assert.rejects(). This simplifies the abort rejection test by verifying both the rejection and the expected erro...

X Description: Replace a rejection-only try/catch block in test-timers-interval-promisified.js with assert.rejects(). This simplifies the abort rejection test by verifying both the rejection and the expected erro...

Opengraph URL: https://github.com/nodejs/node/pull/65322

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:62e371c5-1f2d-88b4-9bcd-2c0cdb6d83ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1AC:1FB218:187A5C:217EF0:6AED0A60
html-safe-nonce99dd842688c9d76c398916518efe20546012b0b939a44380f575ca6c78075488
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUFDOjFGQjIxODoxODdBNUM6MjE3RUYwOjZBRUQwQTYwIiwidmlzaXRvcl9pZCI6IjE2NTk1NTMwODY5NzI5NTUyMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbc98f7d8f4b21dbf321a27e73688a0b37dfe1692cfb19d81bec9c1f661873a55
hovercard-subject-tagpull_request:4289765614
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65322/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f59c1ed89b9015cb20a6065547c3b3e53db30f054275d490fd90118f53c78dd9/nodejs/node/pull/65322
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f59c1ed89b9015cb20a6065547c3b3e53db30f054275d490fd90118f53c78dd9/nodejs/node/pull/65322
og:image:altReplace a rejection-only try/catch block in test-timers-interval-promisified.js with assert.rejects(). This simplifies the abort rejection test by verifying both the rejection and the expected erro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHoonDongKang
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65322#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65322
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65322
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65322
Reloadhttps://github.com/nodejs/node/pull/65322
Reloadhttps://github.com/nodejs/node/pull/65322
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
HoonDongKang:simplify-test-timers-interval-promisifiedhttps://github.com/HoonDongKang/node/tree/simplify-test-timers-interval-promisified
Conversationhttps://github.com/nodejs/node/pull/65322
Commits1 (1)https://github.com/nodejs/node/pull/65322/commits
Checkshttps://github.com/nodejs/node/pull/65322/checks
Files changedhttps://github.com/nodejs/node/pull/65322/files
test: simplify timers interval rejection assertionhttps://github.com/nodejs/node/pull/65322#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
HoonDongKang:simplify-test-timers-interval-promisifiedhttps://github.com/HoonDongKang/node/tree/simplify-test-timers-interval-promisified
https://github.com/HoonDongKang
HoonDongKanghttps://github.com/HoonDongKang
Aug 16, 2026https://github.com/nodejs/node/pull/65322#issue-5163927119
test: simplify test-tls-connect-abort-controller.js #57338https://github.com/nodejs/node/pull/57338
implement TLSSocket and connect from node:tls cloudflare/workerd#3594https://github.com/cloudflare/workerd/pull/3594
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/HoonDongKang
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/pull/65322/commits/4510c52dda44987591b999199a298b36f2db87f8
4510c52https://github.com/nodejs/node/pull/65322/commits/4510c52dda44987591b999199a298b36f2db87f8
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Aug 16, 2026https://github.com/nodejs/node/pull/65322#event-29520578180
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 16, 2026https://github.com/nodejs/node/pull/65322#issuecomment-5307445720
Please reload this pagehttps://github.com/nodejs/node/pull/65322
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65322?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ad7a5b8https://app.codecov.io/gh/nodejs/node/commit/ad7a5b8302ae54b6e6dc77e03eabc5a3218dfb85?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4510c52https://app.codecov.io/gh/nodejs/node/commit/4510c52dda44987591b999199a298b36f2db87f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 32 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65322/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 16, 2026 https://github.com/nodejs/node/pull/65322#pullrequestreview-4946710589
View reviewed changes https://github.com/nodejs/node/pull/65322/files/4510c52dda44987591b999199a298b36f2db87f8
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 16, 2026https://github.com/nodejs/node/pull/65322#event-29527379626
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 16, 2026https://github.com/nodejs/node/pull/65322#event-29527634036
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65322
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65322
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 17, 2026https://github.com/nodejs/node/pull/65322#event-29575170400
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65322#issuecomment-5318714245
https://ci.nodejs.org/job/node-test-pull-request/75943/https://ci.nodejs.org/job/node-test-pull-request/75943/
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 21, 2026https://github.com/nodejs/node/pull/65322#event-29776530541
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
82e7ff4https://github.com/nodejs/node/commit/82e7ff4f84525ba8a54c686275ef88e6c79021e2
Aug 23, 2026https://github.com/nodejs/node/pull/65322#event-29869740394
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 23, 2026https://github.com/nodejs/node/pull/65322#issuecomment-5385650931
82e7ff4https://github.com/nodejs/node/commit/82e7ff4f84525ba8a54c686275ef88e6c79021e2
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 23, 2026https://github.com/nodejs/node/pull/65322#event-29869741191
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65322#ref-commit-8bb20bd
https://github.com/HoonDongKang
https://github.com/aduh95
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/commit/8bb20bdc9128b4fa470593249f63b14b1f28f8eb
8bb20bdhttps://github.com/nodejs/node/commit/8bb20bdc9128b4fa470593249f63b14b1f28f8eb
#65322https://github.com/nodejs/node/pull/65322
#57338https://github.com/nodejs/node/pull/57338
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65322#ref-commit-30f1a19
https://github.com/HoonDongKang
https://github.com/aduh95
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/commit/30f1a19eecfaaa7863091ef0d049fcfa6e6d85df
30f1a19https://github.com/nodejs/node/commit/30f1a19eecfaaa7863091ef0d049fcfa6e6d85df
#65322https://github.com/nodejs/node/pull/65322
#57338https://github.com/nodejs/node/pull/57338
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65322#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65322#ref-commit-5d8194a
https://github.com/HoonDongKang
https://github.com/aduh95
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/commit/5d8194aff2141852eeef9d82f32c572f889c3f1e
5d8194ahttps://github.com/nodejs/node/commit/5d8194aff2141852eeef9d82f32c572f889c3f1e
#65322https://github.com/nodejs/node/pull/65322
#57338https://github.com/nodejs/node/pull/57338
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65322#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65322#ref-commit-01c1263
https://github.com/HoonDongKang
https://github.com/aduh95
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/commit/01c126316ebaa93d0eaf5fa386df3b683f04ed65
01c1263https://github.com/nodejs/node/commit/01c126316ebaa93d0eaf5fa386df3b683f04ed65
#65322https://github.com/nodejs/node/pull/65322
#57338https://github.com/nodejs/node/pull/57338
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65322#ref-commit-f38f154
https://github.com/HoonDongKang
https://github.com/aduh95
test: simplify test-timers-interval-promisified.jshttps://github.com/nodejs/node/commit/f38f154c14e11c4749725a17e65ea0e4a444bbaa
f38f154https://github.com/nodejs/node/commit/f38f154c14e11c4749725a17e65ea0e4a444bbaa
#65322https://github.com/nodejs/node/pull/65322
#57338https://github.com/nodejs/node/pull/57338
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65322
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/65322/files/4510c52dda44987591b999199a298b36f2db87f8
Please reload this pagehttps://github.com/nodejs/node/pull/65322
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/65322
https://github.com/HoonDongKang
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.