René's URL Explorer Experiment


Title: quic: mark drain promise handled by jasnell · Pull Request #65319 · nodejs/node · GitHub

Open Graph Title: quic: mark drain promise handled by jasnell · Pull Request #65319 · nodejs/node

X Title: quic: mark drain promise handled by jasnell · Pull Request #65319 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64290 @nodejs/quic @martenrichter

X Description: Fixes: #64290 @nodejs/quic @martenrichter

Opengraph URL: https://github.com/nodejs/node/pull/65319

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bcd94d66-7f49-d414-dd06-2ffec004b79b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B78:301095:27854F:35BDF9:6AED0FB1
html-safe-nonce13b24843be6c68067d235b188d9e7b515bc3ec364f458e9e6cec2b4e08bf33f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qjc4OjMwMTA5NToyNzg1NEY6MzVCREY5OjZBRUQwRkIxIiwidmlzaXRvcl9pZCI6IjkwMTE2ODE0NjcyMjUxNDkzNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb0bf71f89d0421064e54d76a0a7dd4b6802c1532a629b91cff0cfebb2b6469ef
hovercard-subject-tagpull_request:4288710400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65319/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce5c8b57f955a706ea5bbb16cadc17462d42ccd5447877ac93dd40f9a4c40fdd/nodejs/node/pull/65319
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce5c8b57f955a706ea5bbb16cadc17462d42ccd5447877ac93dd40f9a4c40fdd/nodejs/node/pull/65319
og:image:altFixes: #64290 @nodejs/quic @martenrichter
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65319#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65319
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65319
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65319
Reloadhttps://github.com/nodejs/node/pull/65319
Reloadhttps://github.com/nodejs/node/pull/65319
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:jasnell/mark-drain-promise-handledhttps://github.com/jasnell/node/tree/jasnell/mark-drain-promise-handled
Conversationhttps://github.com/nodejs/node/pull/65319
Commits1 (1)https://github.com/nodejs/node/pull/65319/commits
Checkshttps://github.com/nodejs/node/pull/65319/checks
Files changedhttps://github.com/nodejs/node/pull/65319/files
quic: mark drain promise handledhttps://github.com/nodejs/node/pull/65319#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:jasnell/mark-drain-promise-handledhttps://github.com/jasnell/node/tree/jasnell/mark-drain-promise-handled
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 16, 2026https://github.com/nodejs/node/pull/65319#issue-5162571815
#64290https://github.com/nodejs/node/issues/64290
@martenrichterhttps://github.com/martenrichter
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/jasnell
quic: mark drain promise handledhttps://github.com/nodejs/node/pull/65319/commits/39fa1e05c6f65f02ec48198337ee311ac125e436
39fa1e0https://github.com/nodejs/node/pull/65319/commits/39fa1e05c6f65f02ec48198337ee311ac125e436
nodejs#64290https://github.com/nodejs/node/issues/64290
https://github.com/jasnell
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Aug 16, 2026https://github.com/nodejs/node/pull/65319#event-29514140852
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2026https://github.com/nodejs/node/pull/65319#issuecomment-5305570959
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/jasnell
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Aug 16, 2026https://github.com/nodejs/node/pull/65319#event-29514141573
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
Aug 16, 2026https://github.com/nodejs/node/pull/65319#event-29514142208
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 16, 2026https://github.com/nodejs/node/pull/65319#issuecomment-5305590990
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://ci.nodejs.org/job/node-test-pull-request/75874/https://ci.nodejs.org/job/node-test-pull-request/75874/
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 16, 2026https://github.com/nodejs/node/pull/65319#issuecomment-5305866305
Please reload this pagehttps://github.com/nodejs/node/pull/65319
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65319?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
86c871ehttps://app.codecov.io/gh/nodejs/node/commit/86c871eceda3cdbda53c870851cf6582b928550d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
39fa1e0https://app.codecov.io/gh/nodejs/node/commit/39fa1e05c6f65f02ec48198337ee311ac125e436?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65319?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/quic/quic.jshttps://app.codecov.io/gh/nodejs/node/pull/65319?src=pr&el=tree&filepath=lib%2Finternal%2Fquic%2Fquic.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3F1aWMvcXVpYy5qcw==
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65319/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/martenrichter
martenrichterhttps://github.com/martenrichter
Aug 16, 2026https://github.com/nodejs/node/pull/65319#issuecomment-5306054155
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Qardhttps://github.com/Qard
pimterryhttps://github.com/pimterry
August 16, 2026 13:50https://github.com/nodejs/node/pull/65319#event-29523568107
https://github.com/Qard
Qardhttps://github.com/Qard
Aug 16, 2026 https://github.com/nodejs/node/pull/65319#pullrequestreview-4946550626
View reviewed changes https://github.com/nodejs/node/pull/65319/files/39fa1e05c6f65f02ec48198337ee311ac125e436
https://github.com/jasnell
jasnellhttps://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 17, 2026https://github.com/nodejs/node/pull/65319#event-29542285714
https://github.com/jasnell
jasnellhttps://github.com/jasnell
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Aug 17, 2026https://github.com/nodejs/node/pull/65319#event-29542290463
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 22, 2026https://github.com/nodejs/node/pull/65319#event-29855091153
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c1d3132https://github.com/nodejs/node/commit/c1d3132a1e0f090501aba871e5f984ee366b3cbd
Aug 23, 2026https://github.com/nodejs/node/pull/65319#event-29863238473
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 23, 2026https://github.com/nodejs/node/pull/65319#issuecomment-5384087249
c1d3132https://github.com/nodejs/node/commit/c1d3132a1e0f090501aba871e5f984ee366b3cbd
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
QUIC Teamhttps://github.com/orgs/nodejs/projects/17
Aug 23, 2026https://github.com/nodejs/node/pull/65319#event-29863240026
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 23, 2026https://github.com/nodejs/node/pull/65319#event-29863239470
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65319#ref-commit-ad2ac3f
https://github.com/jasnell
https://github.com/aduh95
quic: mark drain promise handledhttps://github.com/nodejs/node/commit/ad2ac3f0cf8c09ffba85ca10630f524024c1d93f
ad2ac3fhttps://github.com/nodejs/node/commit/ad2ac3f0cf8c09ffba85ca10630f524024c1d93f
#64290https://github.com/nodejs/node/issues/64290
#65319https://github.com/nodejs/node/pull/65319
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65319#ref-commit-9139389
https://github.com/jasnell
https://github.com/aduh95
quic: mark drain promise handledhttps://github.com/nodejs/node/commit/91393898b5be9d19b8bc0c89702f436c0ef08297
9139389https://github.com/nodejs/node/commit/91393898b5be9d19b8bc0c89702f436c0ef08297
#64290https://github.com/nodejs/node/issues/64290
#65319https://github.com/nodejs/node/pull/65319
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65319#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65319#ref-commit-647c8dd
https://github.com/jasnell
https://github.com/aduh95
quic: mark drain promise handledhttps://github.com/nodejs/node/commit/647c8ddb4ee720a05c98053403d91cb080f9ad9d
647c8ddhttps://github.com/nodejs/node/commit/647c8ddb4ee720a05c98053403d91cb080f9ad9d
#64290https://github.com/nodejs/node/issues/64290
#65319https://github.com/nodejs/node/pull/65319
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65319#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65319#ref-commit-eade9c7
https://github.com/jasnell
https://github.com/aduh95
quic: mark drain promise handledhttps://github.com/nodejs/node/commit/eade9c7f1e57e957aed817845dff056c71560af9
eade9c7https://github.com/nodejs/node/commit/eade9c7f1e57e957aed817845dff056c71560af9
#64290https://github.com/nodejs/node/issues/64290
#65319https://github.com/nodejs/node/pull/65319
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65319#ref-commit-a4c770c
https://github.com/jasnell
https://github.com/aduh95
quic: mark drain promise handledhttps://github.com/nodejs/node/commit/a4c770c78eda745dd956ab912708b28aec254908
a4c770chttps://github.com/nodejs/node/commit/a4c770c78eda745dd956ab912708b28aec254908
#64290https://github.com/nodejs/node/issues/64290
#65319https://github.com/nodejs/node/pull/65319
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65319
https://github.com/Qard
Qard https://github.com/Qard
https://github.com/nodejs/node/pull/65319/files/39fa1e05c6f65f02ec48198337ee311ac125e436
https://github.com/pimterry
pimterry https://github.com/pimterry
Please reload this pagehttps://github.com/nodejs/node/pull/65319
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
quic https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquic
QUIC Team https://github.com/orgs/nodejs/projects/17
quic: QuicStream writer creates unhandled error https://github.com/nodejs/node/issues/64290
Please reload this pagehttps://github.com/nodejs/node/pull/65319
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/martenrichter
https://github.com/Qard
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.