René's URL Explorer Experiment


Title: stream: avoid leaking consumers on signal failure by trivikr · Pull Request #65299 · nodejs/node · GitHub

Open Graph Title: stream: avoid leaking consumers on signal failure by trivikr · Pull Request #65299 · nodejs/node

X Title: stream: avoid leaking consumers on signal failure by trivikr · Pull Request #65299 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #65298 Validate Broadcast.push() and Share.pull() signals before registering raw consumers. Return a rejecting iterable for pre-aborted signals without adding a cursor. This prevents failed ...

X Description: Fixes: #65298 Validate Broadcast.push() and Share.pull() signals before registering raw consumers. Return a rejecting iterable for pre-aborted signals without adding a cursor. This prevents failed ...

Opengraph URL: https://github.com/nodejs/node/pull/65299

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4bbb5360-603f-88a9-6191-25adf81c1be6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id976E:3D9AC3:9F030:D386E:6AED07D7
html-safe-noncec446f744a86d288c46750d9a7e40bd572a0a583b59a07164fa32967dcfc155cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzZFOjNEOUFDMzo5RjAzMDpEMzg2RTo2QUVEMDdENyIsInZpc2l0b3JfaWQiOiIyMzIzMDQ4MzQ2NTU3MDI2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc2fd6e0cd0e31c0f25a654cb8c4bfa957edf7c8893345af916915514f22112c4
hovercard-subject-tagpull_request:4284876315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65299/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/83b4b66bc537af1c140fae9429faef72c4ea58180865c6b78cc1ef19ac0d5034/nodejs/node/pull/65299
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/83b4b66bc537af1c140fae9429faef72c4ea58180865c6b78cc1ef19ac0d5034/nodejs/node/pull/65299
og:image:altFixes: #65298 Validate Broadcast.push() and Share.pull() signals before registering raw consumers. Return a rejecting iterable for pre-aborted signals without adding a cursor. This prevents failed ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65299#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65299
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65299
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65299
Reloadhttps://github.com/nodejs/node/pull/65299
Reloadhttps://github.com/nodejs/node/pull/65299
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-bc-share-consumer-leak-invalid-signalhttps://github.com/trivikr/node/tree/stream-iter-bc-share-consumer-leak-invalid-signal
Conversationhttps://github.com/nodejs/node/pull/65299
Commits1 (1)https://github.com/nodejs/node/pull/65299/commits
Checkshttps://github.com/nodejs/node/pull/65299/checks
Files changedhttps://github.com/nodejs/node/pull/65299/files
stream: avoid leaking consumers on signal failurehttps://github.com/nodejs/node/pull/65299#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-bc-share-consumer-leak-invalid-signalhttps://github.com/trivikr/node/tree/stream-iter-bc-share-consumer-leak-invalid-signal
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 15, 2026https://github.com/nodejs/node/pull/65299#issue-5157711204
#65298https://github.com/nodejs/node/issues/65298
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/trivikr
stream: avoid leaking consumers on signal failurehttps://github.com/nodejs/node/pull/65299/commits/309218dd57a98d662b9f204a1225654403943a3c
309218dhttps://github.com/nodejs/node/pull/65299/commits/309218dd57a98d662b9f204a1225654403943a3c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2026https://github.com/nodejs/node/pull/65299#issuecomment-5300600779
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 15, 2026https://github.com/nodejs/node/pull/65299#event-29491420991
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 15, 2026 https://github.com/nodejs/node/pull/65299#pullrequestreview-4943073922
View reviewed changes https://github.com/nodejs/node/pull/65299/files/309218dd57a98d662b9f204a1225654403943a3c
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 15, 2026https://github.com/nodejs/node/pull/65299#issuecomment-5300923591
Please reload this pagehttps://github.com/nodejs/node/pull/65299
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65299?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4551732https://app.codecov.io/gh/nodejs/node/commit/4551732bf1137bdc1e49d26ab6e26bec9c065e8d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
309218dhttps://app.codecov.io/gh/nodejs/node/commit/309218dd57a98d662b9f204a1225654403943a3c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65299?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/65299?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/65299?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2026https://github.com/nodejs/node/pull/65299#event-29493030860
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 15, 2026https://github.com/nodejs/node/pull/65299#event-29493069519
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65299
https://github.com/jazelly
jazellyhttps://github.com/jazelly
Aug 15, 2026 https://github.com/nodejs/node/pull/65299#pullrequestreview-4943790923
View reviewed changes https://github.com/nodejs/node/pull/65299/files/309218dd57a98d662b9f204a1225654403943a3c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 15, 2026https://github.com/nodejs/node/pull/65299#event-29505758057
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65299
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 15, 2026https://github.com/nodejs/node/pull/65299#issuecomment-5304701440
https://ci.nodejs.org/job/node-test-pull-request/75871/https://ci.nodejs.org/job/node-test-pull-request/75871/
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 16, 2026https://github.com/nodejs/node/pull/65299#event-29526186274
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
977c20ehttps://github.com/nodejs/node/commit/977c20ed675e9c240e841ccf9edd06c5a4b239a4
Aug 17, 2026https://github.com/nodejs/node/pull/65299#event-29543349397
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65299#issuecomment-5312054045
977c20ehttps://github.com/nodejs/node/commit/977c20ed675e9c240e841ccf9edd06c5a4b239a4
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65299#event-29543350710
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65299#ref-commit-54d0bf6
https://github.com/trivikr
https://github.com/aduh95
stream: avoid leaking consumers on signal failurehttps://github.com/nodejs/node/commit/54d0bf6044b1d81440b5917d626ac3c47ebbd111
54d0bf6https://github.com/nodejs/node/commit/54d0bf6044b1d81440b5917d626ac3c47ebbd111
#65299https://github.com/nodejs/node/pull/65299
#65298https://github.com/nodejs/node/issues/65298
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65299#ref-commit-815424d
https://github.com/trivikr
https://github.com/aduh95
stream: avoid leaking consumers on signal failurehttps://github.com/nodejs/node/commit/815424db74e53dd3d3adb29b35163e5314165f3b
815424dhttps://github.com/nodejs/node/commit/815424db74e53dd3d3adb29b35163e5314165f3b
#65299https://github.com/nodejs/node/pull/65299
#65298https://github.com/nodejs/node/issues/65298
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65299#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65299#ref-commit-386ed6a
https://github.com/trivikr
https://github.com/aduh95
stream: avoid leaking consumers on signal failurehttps://github.com/nodejs/node/commit/386ed6a06dacfad858522ba7f43e0be2eac9fe81
386ed6ahttps://github.com/nodejs/node/commit/386ed6a06dacfad858522ba7f43e0be2eac9fe81
#65299https://github.com/nodejs/node/pull/65299
#65298https://github.com/nodejs/node/issues/65298
https://github.com/trivikr
trivikrhttps://github.com/trivikr
September 7, 2026 01:16https://github.com/nodejs/node/pull/65299#event-30659292227
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65299#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65299
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65299/files/309218dd57a98d662b9f204a1225654403943a3c
https://github.com/jazelly
jazelly https://github.com/jazelly
https://github.com/nodejs/node/pull/65299/files/309218dd57a98d662b9f204a1225654403943a3c
Please reload this pagehttps://github.com/nodejs/node/pull/65299
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: Broadcast and Share leak consumers for invalid or pre-aborted signals https://github.com/nodejs/node/issues/65298
Please reload this pagehttps://github.com/nodejs/node/pull/65299
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/jazelly
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.