René's URL Explorer Experiment

Title: sqlite: reject reentry while binding parameters by TrevorBurnham · Pull Request #65294 · nodejs/node · GitHub

Open Graph Title: sqlite: reject reentry while binding parameters by TrevorBurnham · Pull Request #65294 · nodejs/node

X Title: sqlite: reject reentry while binding parameters by TrevorBurnham · Pull Request #65294 · nodejs/node

Description: Follow-up for #65156. That PR added tracking for the statements currently being stepped and rejects reentry into them. The guard is established inside the execution helpers, though, which the entry points reach only after resetting the statement and binding its parameters. Binding reads properties off the supplied object, so a named-parameter getter runs JavaScript in that window. On current main: const { DatabaseSync } = require('node:sqlite'); const db = new DatabaseSync(':memory:'); db.exec('CREATE TABLE data (value INTEGER); INSERT INTO data VALUES (1),(2),(3);'); const st = db.prepare('SELECT value FROM data WHERE value >= $min'); let inner; const params = { get $min() { inner ??= st.iterate({ $min: 1 }); return 1; } }; const outer = st.iterate(params); console.log(outer.next(), inner.next(), outer.next(), inner.next()); { done: false, value: { value: 1 } } // outer { done: false, value: { value: 2 } } // inner { done: false, value: { value: 3 } } // outer { done: true, value: null } // inner Two live iterators over one virtual machine. The reset-generation check does not catch it because the inner iterate() bumps the generation before the outer iterator is constructed, so both record the same value and neither is invalidated. This PR hoists the guard to the four StatementSync entry points, before the reset, so it spans binding as well as stepping. The guards inside the helpers are left alone; stepping_statements_ is a stack, so the nested acquisition is balanced. It also adds test cases salvaged from #65106, which was superseded by #65156.

Open Graph Description: Follow-up for #65156. That PR added tracking for the statements currently being stepped and rejects reentry into them. The guard is established inside the execution helpers, though, which the entry...

X Description: Follow-up for #65156. That PR added tracking for the statements currently being stepped and rejects reentry into them. The guard is established inside the execution helpers, though, which the entry...

Opengraph URL: https://github.com/nodejs/node/pull/65294

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width