René's URL Explorer Experiment


Title: stream: skip pipeline callback on sync throw by lazerg · Pull Request #65128 · nodejs/node · GitHub

Open Graph Title: stream: skip pipeline callback on sync throw by lazerg · Pull Request #65128 · nodejs/node

X Title: stream: skip pipeline callback on sync throw by lazerg · Pull Request #65128 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: When pipelineImpl() throws while wiring the streams together, the stages it already wired stay live. As they close they call finish(), finishCount drains to zero and finishImpl() runs with final se...

X Description: When pipelineImpl() throws while wiring the streams together, the stages it already wired stay live. As they close they call finish(), finishCount drains to zero and finishImpl() runs with final se...

Opengraph URL: https://github.com/nodejs/node/pull/65128

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:254ff990-c2e4-d9e2-fb32-df82784e7c2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7CE:1463F:B4DE02:EC3EB3:6AED46CB
html-safe-nonce4f26f925bc7662cf9ed336d03378c4ac3ca47085a66990accd08f259e1aec354
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0NFOjE0NjNGOkI0REUwMjpFQzNFQjM6NkFFRDQ2Q0IiLCJ2aXNpdG9yX2lkIjoiNjUyMDUxMTA3ODc1MDU3MDE4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a5905068cc5bae490b82151f4a4d6b1fa8b8253f2795da39c6a7234035f1ac0
hovercard-subject-tagpull_request:4233462680
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65128/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/376ee2d801f3f92220ca97ffcc62aa60017d7f3b4714bb10c2a9d478572f205d/nodejs/node/pull/65128
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/376ee2d801f3f92220ca97ffcc62aa60017d7f3b4714bb10c2a9d478572f205d/nodejs/node/pull/65128
og:image:altWhen pipelineImpl() throws while wiring the streams together, the stages it already wired stay live. As they close they call finish(), finishCount drains to zero and finishImpl() runs with final se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65128#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65128
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65128
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65128
Reloadhttps://github.com/nodejs/node/pull/65128
Reloadhttps://github.com/nodejs/node/pull/65128
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
lazerghttps://github.com/lazerg
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65127-pipeline-sync-throw-callbackhttps://github.com/lazerg/node/tree/fix/issue-65127-pipeline-sync-throw-callback
Conversationhttps://github.com/nodejs/node/pull/65128
Commits1 (1)https://github.com/nodejs/node/pull/65128/commits
Checkshttps://github.com/nodejs/node/pull/65128/checks
Files changedhttps://github.com/nodejs/node/pull/65128/files
stream: skip pipeline callback on sync throwhttps://github.com/nodejs/node/pull/65128#top
lazerghttps://github.com/lazerg
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65127-pipeline-sync-throw-callbackhttps://github.com/lazerg/node/tree/fix/issue-65127-pipeline-sync-throw-callback
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 8, 2026https://github.com/nodejs/node/pull/65128#issue-5096189186
Please reload this pagehttps://github.com/nodejs/node/pull/65128
#65127https://github.com/nodejs/node/issues/65127
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5224881310
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 8, 2026https://github.com/nodejs/node/pull/65128#event-29152191707
https://github.com/lazerg
stream: skip pipeline callback on sync throwhttps://github.com/nodejs/node/pull/65128/commits/358beaae7e9cadf2452a3db9ad8b64e133f390d4
358beaahttps://github.com/nodejs/node/pull/65128/commits/358beaae7e9cadf2452a3db9ad8b64e133f390d4
https://github.com/lazerg
lazerghttps://github.com/lazerg
force-pushedhttps://github.com/nodejs/node/compare/369726d83569a9324e0d35c722fb3c7a8e33b078..358beaae7e9cadf2452a3db9ad8b64e133f390d4
369726dhttps://github.com/nodejs/node/commit/369726d83569a9324e0d35c722fb3c7a8e33b078
358beaahttps://github.com/nodejs/node/commit/358beaae7e9cadf2452a3db9ad8b64e133f390d4
Compare https://github.com/nodejs/node/compare/369726d83569a9324e0d35c722fb3c7a8e33b078..358beaae7e9cadf2452a3db9ad8b64e133f390d4
August 8, 2026 06:21https://github.com/nodejs/node/pull/65128#event-29152293945
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 8, 2026https://github.com/nodejs/node/pull/65128#event-29152295758
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 8, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5225151484
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 8, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5225219054
Please reload this pagehttps://github.com/nodejs/node/pull/65128
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65128?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e2d7b34https://app.codecov.io/gh/nodejs/node/commit/e2d7b3416402e611fdb023fb4531bf5b861721b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
358beaahttps://app.codecov.io/gh/nodejs/node/commit/358beaae7e9cadf2452a3db9ad8b64e133f390d4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65128?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/pipeline.jshttps://app.codecov.io/gh/nodejs/node/pull/65128?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fpipeline.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvcGlwZWxpbmUuanM=
32 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65128/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/jasnell
jasnellhttps://github.com/jasnell
mcollinahttps://github.com/mcollina
ronaghttps://github.com/ronag
August 8, 2026 15:29https://github.com/nodejs/node/pull/65128#event-29161402427
https://github.com/MILLERMARRU
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65128
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 22, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5379097213
#65165https://github.com/nodejs/node/pull/65165
#65064https://github.com/nodejs/node/pull/65064
@ronaghttps://github.com/ronag
@mcollinahttps://github.com/mcollina
#65064https://github.com/nodejs/node/pull/65064
#65063https://github.com/nodejs/node/issues/65063
#65165https://github.com/nodejs/node/pull/65165
@pacocartoneshttps://github.com/pacocartones
#65128https://github.com/nodejs/node/pull/65128
#65127https://github.com/nodejs/node/issues/65127
#65064https://github.com/nodejs/node/pull/65064
#65063https://github.com/nodejs/node/issues/65063
#65165https://github.com/nodejs/node/pull/65165
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/ronag
ronaghttps://github.com/ronag
Sep 8, 2026 https://github.com/nodejs/node/pull/65128#pullrequestreview-5138155197
View reviewed changes https://github.com/nodejs/node/pull/65128/files/358beaae7e9cadf2452a3db9ad8b64e133f390d4
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Sep 13, 2026 https://github.com/nodejs/node/pull/65128#pullrequestreview-5191999421
View reviewed changes https://github.com/nodejs/node/pull/65128/files/358beaae7e9cadf2452a3db9ad8b64e133f390d4
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65128#pullrequestreview-5191999421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65128#event-31062594150
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 13, 2026https://github.com/nodejs/node/pull/65128#event-31062692701
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 13, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5655678737
https://ci.nodejs.org/job/node-test-pull-request/77437/https://ci.nodejs.org/job/node-test-pull-request/77437/
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/panva
panvahttps://github.com/panva
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Sep 14, 2026https://github.com/nodejs/node/pull/65128#event-31082298181
https://github.com/lazerg
lazerghttps://github.com/lazerg
Sep 17, 2026https://github.com/nodejs/node/pull/65128#issuecomment-5718050502
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/lazerg
lazerghttps://github.com/lazerg
Sep 17, 2026https://github.com/nodejs/node/pull/65128#event-31335851321
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65128
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65128/files/358beaae7e9cadf2452a3db9ad8b64e133f390d4
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/65128/files/358beaae7e9cadf2452a3db9ad8b64e133f390d4
https://github.com/MILLERMARRU
MILLERMARRU https://github.com/MILLERMARRU
https://github.com/nodejs/node/pull/65128/files/358beaae7e9cadf2452a3db9ad8b64e133f390d4
Please reload this pagehttps://github.com/nodejs/node/pull/65128
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream.pipeline() can both throw synchronously and invoke the callback reporting success https://github.com/nodejs/node/issues/65127
Please reload this pagehttps://github.com/nodejs/node/pull/65128
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/ronag
https://github.com/MILLERMARRU
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.