René's URL Explorer Experiment


Title: build: pass target architecture to small-icu genccode · Pull Request #65095 · nodejs/node · GitHub

Open Graph Title: build: pass target architecture to small-icu genccode · Pull Request #65095 · nodejs/node

X Title: build: pass target architecture to small-icu genccode · Pull Request #65095 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #58751. Pass the target architecture to genccode when converting trimmed ICU data into a Windows object file. Windows builds use ClangCL, whose ICU COFF writer requires -c <target_arch>...

X Description: Fixes #58751. Pass the target architecture to genccode when converting trimmed ICU data into a Windows object file. Windows builds use ClangCL, whose ICU COFF writer requires -c &lt;target_arch...

Opengraph URL: https://github.com/nodejs/node/pull/65095

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b53c53c-56c1-e501-e6a2-569ac80bd42b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC866:2BD59E:1FFB56:2B996D:6AED0CB7
html-safe-nonceeab0eead845247a96f9d96917287741ed7a32c16ab007e8fb657efe313407606
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODY2OjJCRDU5RToxRkZCNTY6MkI5OTZEOjZBRUQwQ0I3IiwidmlzaXRvcl9pZCI6IjM4OTk3ODU5Njk2MTQ1MjM1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2b688bbb78683a6a41544350891c6d3ebb4c34fc407dc7667b8de92d108a9cf2
hovercard-subject-tagpull_request:4224964540
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65095/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ae6c2c5ca7ab06ad3adeb752cedd6d3f4fd28b0ac9c20c9a74d6d7d8b8555513/nodejs/node/pull/65095
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ae6c2c5ca7ab06ad3adeb752cedd6d3f4fd28b0ac9c20c9a74d6d7d8b8555513/nodejs/node/pull/65095
og:image:altFixes #58751. Pass the target architecture to genccode when converting trimmed ICU data into a Windows object file. Windows builds use ClangCL, whose ICU COFF writer requires -c <target_arch>...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65095#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65095
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65095
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65095
Reloadhttps://github.com/nodejs/node/pull/65095
Reloadhttps://github.com/nodejs/node/pull/65095
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
Conversationhttps://github.com/nodejs/node/pull/65095
Commits1 (1)https://github.com/nodejs/node/pull/65095/commits
Checkshttps://github.com/nodejs/node/pull/65095/checks
Files changedhttps://github.com/nodejs/node/pull/65095/files
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/pull/65095#top
nodejs-github-bothttps://github.com/nodejs-github-bot
mainhttps://github.com/nodejs/node/tree/main
https://github.com/ghost
ghosthttps://github.com/ghost
Aug 7, 2026https://github.com/nodejs/node/pull/65095#issue-5086036775
#58751https://github.com/nodejs/node/issues/58751
Please reload this pagehttps://github.com/nodejs/node/pull/65095
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/pull/65095/commits/4a819662ae5abdebcad4de3f29ed98629bd8f031
4a81966https://github.com/nodejs/node/pull/65095/commits/4a819662ae5abdebcad4de3f29ed98629bd8f031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 7, 2026https://github.com/nodejs/node/pull/65095#issuecomment-5211033794
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
icu https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aicu
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Aug 7, 2026https://github.com/nodejs/node/pull/65095#event-29094584255
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Aug 7, 2026 https://github.com/nodejs/node/pull/65095#pullrequestreview-4879663114
View reviewed changes https://github.com/nodejs/node/pull/65095/files/4a819662ae5abdebcad4de3f29ed98629bd8f031
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 11, 2026https://github.com/nodejs/node/pull/65095#event-29271063683
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 11, 2026https://github.com/nodejs/node/pull/65095#event-29271624161
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2026https://github.com/nodejs/node/pull/65095#issuecomment-5251526490
https://ci.nodejs.org/job/node-test-pull-request/75772/https://ci.nodejs.org/job/node-test-pull-request/75772/
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/StefanStojanovic
StefanStojanovichttps://github.com/StefanStojanovic
Aug 17, 2026 https://github.com/nodejs/node/pull/65095#pullrequestreview-4949750663
View reviewed changes https://github.com/nodejs/node/pull/65095/files/4a819662ae5abdebcad4de3f29ed98629bd8f031
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65095#issuecomment-5315903816
https://ci.nodejs.org/job/node-test-pull-request/75924/https://ci.nodejs.org/job/node-test-pull-request/75924/
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/richardlau
richardlauhttps://github.com/richardlau
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65095#event-29583337995
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
8b9f89fhttps://github.com/nodejs/node/commit/8b9f89fee0f5d10ae492da90de61030dd3471842
Aug 17, 2026https://github.com/nodejs/node/pull/65095#event-29583763656
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65095#issuecomment-5320624773
8b9f89fhttps://github.com/nodejs/node/commit/8b9f89fee0f5d10ae492da90de61030dd3471842
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65095#event-29583766011
https://github.com/moluopro
moluoprohttps://github.com/moluopro
Aug 21, 2026 https://github.com/nodejs/node/pull/65095#ref-pullrequest-4796238782
build: fix Windows small-icu build with ClangCL #64263 https://github.com/nodejs/node/pull/64263
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65095#ref-commit-5474ecf
https://github.com/aduh95
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/commit/5474ecf40ed286b09a215edbb48e3c70ef5c266e
5474ecfhttps://github.com/nodejs/node/commit/5474ecf40ed286b09a215edbb48e3c70ef5c266e
#65095https://github.com/nodejs/node/pull/65095
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65095#ref-commit-3da555a
https://github.com/aduh95
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/commit/3da555a3ede551b4704284f4db2680d0ffd2552e
3da555ahttps://github.com/nodejs/node/commit/3da555a3ede551b4704284f4db2680d0ffd2552e
#65095https://github.com/nodejs/node/pull/65095
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65095#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65095#ref-commit-a2a91dc
https://github.com/aduh95
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/commit/a2a91dce841418e6a145378ac5ed91c108b71bba
a2a91dchttps://github.com/nodejs/node/commit/a2a91dce841418e6a145378ac5ed91c108b71bba
#65095https://github.com/nodejs/node/pull/65095
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65095#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65095#ref-commit-5a5d73e
https://github.com/aduh95
build: pass target architecture to small-icu genccodehttps://github.com/nodejs/node/commit/5a5d73e4c54c41b55300dc4cfe31c45ed3443c77
5a5d73ehttps://github.com/nodejs/node/commit/5a5d73e4c54c41b55300dc4cfe31c45ed3443c77
#65095https://github.com/nodejs/node/pull/65095
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65095
Please reload this pagehttps://github.com/nodejs/node/pull/65095
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
i18n-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ai18n-api
icu https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aicu
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
window build failure with the latest node v24.2.0 for small-icu https://github.com/nodejs/node/issues/58751
Please reload this pagehttps://github.com/nodejs/node/pull/65095
https://github.com/nodejs-github-bot
https://github.com/StefanStojanovic
https://github.com/avivkeller
https://github.com/richardlau
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.