René's URL Explorer Experiment


Title: src: reuse cached strings in node_locks.cc by agape1225 · Pull Request #65081 · nodejs/node · GitHub

Open Graph Title: src: reuse cached strings in node_locks.cc by agape1225 · Pull Request #65081 · nodejs/node

X Title: src: reuse cached strings in node_locks.cc by agape1225 · Pull Request #65081 · nodejs/node

Description: CreatePerIsolateProperties() in src/node_locks.cc created new "shared" and "exclusive" V8 strings via FIXED_ONE_BYTE_STRING() on every isolate, even though these strings are already cached on IsolateData as shared_string() / exclusive_string() (defined via PER_ISOLATE_STRING_PROPERTIES in src/env_properties.h) and are already reused this way elsewhere in the same file (CreateLockInfoObject()). This replaces the two ad-hoc FIXED_ONE_BYTE_STRING(isolate, "shared"/"exclusive") calls with the existing cached accessors for consistency with the rest of the file and to avoid creating duplicate string instances.

Open Graph Description: CreatePerIsolateProperties() in src/node_locks.cc created new "shared" and "exclusive" V8 strings via FIXED_ONE_BYTE_STRING() on every isolate, even though these strings are alr...

X Description: CreatePerIsolateProperties() in src/node_locks.cc created new "shared" and "exclusive" V8 strings via FIXED_ONE_BYTE_STRING() on every isolate, even though these...

Opengraph URL: https://github.com/nodejs/node/pull/65081

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files/:range(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4f9f34ac-1a73-b656-f0c4-6b6718a5dda6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8136:3AF359:89611E:B66E00:6AEDC7A3
html-safe-nonceb974dd33b32676a9bd899dcadcded3994fa3a6af26a89b392586a9873341c324
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTM2OjNBRjM1OTo4OTYxMUU6QjY2RTAwOjZBRURDN0EzIiwidmlzaXRvcl9pZCI6IjUwMTE3MjM2OTc5ODcxMTA4MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac27fb7f66fd275c799bb1f5463557dd1274ab33c3aa0b0d671fcb6142fa648a9c
hovercard-subject-tagpull_request:4221084689
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
twitter:imagehttps://avatars.githubusercontent.com/u/49804691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49804691?s=400&v=4
og:image:altCreatePerIsolateProperties() in src/node_locks.cc created new "shared" and "exclusive" V8 strings via FIXED_ONE_BYTE_STRING() on every isolate, even though these strings are alr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec7d2f3ac4f4f560c56267b765892ba5b093e8a5fb2c0ed937edd8947746942e9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0cac2d0cb993b0ad48c49b076135ac558c742c30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65081%2Ffiles%2F2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65081%2Ffiles%2F2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Reloadhttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Reloadhttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests663 (663)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
agape1225https://github.com/agape1225
nodejs:mainhttps://github.com/nodejs/node/tree/main
agape1225:src-node-locks-reuse-cached-stringshttps://github.com/agape1225/node/tree/src-node-locks-reuse-cached-strings
Conversation 5 https://github.com/nodejs/node/pull/65081
Commits 1 https://github.com/nodejs/node/pull/65081/commits
Checks 40 https://github.com/nodejs/node/pull/65081/checks
Files changed https://github.com/nodejs/node/pull/65081/files
Please reload this pagehttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
src: reuse cached strings in node_locks.cc https://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32#top
Show all changes 1 commit https://github.com/nodejs/node/pull/65081/files
2bc2f72 src: reuse cached strings in node_locks.cc agape1225 Aug 6, 2026 https://github.com/nodejs/node/pull/65081/commits/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Clear filters https://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Please reload this pagehttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
Please reload this pagehttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
src/node_locks.cchttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32#diff-225b7b934c709c4b336d79d0f5df4b093f42b10667884af03fcae7b6eb13f176
View file https://github.com/agape1225/node/blob/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32/src/node_locks.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/65081/files/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32#diff-225b7b934c709c4b336d79d0f5df4b093f42b10667884af03fcae7b6eb13f176
https://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32#diff-225b7b934c709c4b336d79d0f5df4b093f42b10667884af03fcae7b6eb13f176
Please reload this pagehttps://github.com/nodejs/node/pull/65081/files/2bc2f72e343c744db1e7e93a3ae35a19c6c23d32
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.