René's URL Explorer Experiment


Title: tls: throw on invalid ALPNProtocols instead of aborting by sankalpsthakur · Pull Request #65076 · nodejs/node · GitHub

Open Graph Title: tls: throw on invalid ALPNProtocols instead of aborting by sankalpsthakur · Pull Request #65076 · nodejs/node

X Title: tls: throw on invalid ALPNProtocols instead of aborting by sankalpsthakur · Pull Request #65076 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #65069 tls.connect() with malformed ALPNProtocols (e.g. [''] or invalid wire format buffers like Buffer.from([0])) aborts the process with SIGABRT. The failure is CHECK_EQ(0, SSL_set_...

X Description: Fixes #65069 tls.connect() with malformed ALPNProtocols (e.g. [''] or invalid wire format buffers like Buffer.from([0])) aborts the process with SIGABRT. The failure is CHECK_EQ(0, ...

Mail addresses
sankalphimself@gmail.com

Opengraph URL: https://github.com/nodejs/node/pull/65076

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4d27d7a6-8724-e84e-0495-3a66715968d5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC89C:A2B38:1EA6C:278D3:6AED0F28
html-safe-noncee4ce5ebcc58c9d2a35accb316a989c8e9e1afbef530f9da147ba95a87e55193f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODlDOkEyQjM4OjFFQTZDOjI3OEQzOjZBRUQwRjI4IiwidmlzaXRvcl9pZCI6IjY5OTU0MjE1MTI2MzgyMDU3MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47112ab1f474fea3cefae30ee769902a64a83514b8a3bcb9b00b617c1708bee9
hovercard-subject-tagpull_request:4219711523
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65076/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e0434ed54d88a64edf8f2235976979d910a761b132e577580f75fb668e8b434f/nodejs/node/pull/65076
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0434ed54d88a64edf8f2235976979d910a761b132e577580f75fb668e8b434f/nodejs/node/pull/65076
og:image:altFixes #65069 tls.connect() with malformed ALPNProtocols (e.g. [''] or invalid wire format buffers like Buffer.from([0])) aborts the process with SIGABRT. The failure is CHECK_EQ(0, SSL_set_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesankalpsthakur
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65076#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65076
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65076
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65076
Reloadhttps://github.com/nodejs/node/pull/65076
Reloadhttps://github.com/nodejs/node/pull/65076
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
sankalpsthakur:fix/65069-alpn-sigabrthttps://github.com/sankalpsthakur/node/tree/fix/65069-alpn-sigabrt
Conversationhttps://github.com/nodejs/node/pull/65076
Commits1 (1)https://github.com/nodejs/node/pull/65076/commits
Checkshttps://github.com/nodejs/node/pull/65076/checks
Files changedhttps://github.com/nodejs/node/pull/65076/files
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/pull/65076#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
sankalpsthakur:fix/65069-alpn-sigabrthttps://github.com/sankalpsthakur/node/tree/fix/65069-alpn-sigabrt
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026https://github.com/nodejs/node/pull/65076#issue-5079802320
#65069https://github.com/nodejs/node/issues/65069
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5202952397
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 6, 2026https://github.com/nodejs/node/pull/65076#event-29059937751
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-4873569016
View reviewed changes https://github.com/nodejs/node/pull/65076/files
pimterryhttps://github.com/pimterry
https://github.com/nodejs/node/pull/65076#pullrequestreview-4873569016
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@sankalpsthakurhttps://github.com/sankalpsthakur
Please reload this pagehttps://github.com/nodejs/node/pull/65076
src/crypto/crypto_tls.cchttps://github.com/nodejs/node/pull/65076/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
Please reload this pagehttps://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-bc50a18
tls: validate ALPNProtocols in JS and cover server casehttps://github.com/sankalpsthakur/node/commit/bc50a181a86fe26e98bf974ec65db925e82d09a5
bc50a18https://github.com/sankalpsthakur/node/commit/bc50a181a86fe26e98bf974ec65db925e82d09a5
nodejs#65076https://github.com/nodejs/node/pull/65076
nodejs#65076https://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-dab0602
test: add validation for invalid ALPNProtocolshttps://github.com/sankalpsthakur/node/commit/dab0602126414782a85b78c13a81d2bd66b6a183
dab0602https://github.com/sankalpsthakur/node/commit/dab0602126414782a85b78c13a81d2bd66b6a183
nodejs#65069https://github.com/nodejs/node/issues/65069
nodejs#65076https://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5203644969
Please reload this pagehttps://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-9b9eaca
tls: validate ALPNProtocols in JS and cover server casehttps://github.com/sankalpsthakur/node/commit/9b9eacaefe7a79a47c7808411ecfd3c0d9eb33ad
9b9eacahttps://github.com/sankalpsthakur/node/commit/9b9eacaefe7a79a47c7808411ecfd3c0d9eb33ad
nodejs#65076https://github.com/nodejs/node/pull/65076
nodejs#65076https://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-aac5713
test: add validation for invalid ALPNProtocolshttps://github.com/sankalpsthakur/node/commit/aac57132f6db4fbb52e9e24b156636a52111f44f
aac5713https://github.com/sankalpsthakur/node/commit/aac57132f6db4fbb52e9e24b156636a52111f44f
nodejs#65069https://github.com/nodejs/node/issues/65069
nodejs#65076https://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/dab0602126414782a85b78c13a81d2bd66b6a183..af6b21fc7849be58cb21d558169891a948f44ef2
dab0602https://github.com/nodejs/node/commit/dab0602126414782a85b78c13a81d2bd66b6a183
af6b21fhttps://github.com/nodejs/node/commit/af6b21fc7849be58cb21d558169891a948f44ef2
Compare https://github.com/nodejs/node/compare/dab0602126414782a85b78c13a81d2bd66b6a183..af6b21fc7849be58cb21d558169891a948f44ef2
August 6, 2026 12:42https://github.com/nodejs/node/pull/65076#event-29068131783
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 6, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5204776632
#65069https://github.com/nodejs/node/issues/65069
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 6, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-4874926731
View reviewed changes https://github.com/nodejs/node/pull/65076/files
lib/tls.jshttps://github.com/nodejs/node/pull/65076/files#diff-f1b90fb09d53a3d1d8bcdbd144bf06077c856e81ed324ac0f469bda505a2f027
Please reload this pagehttps://github.com/nodejs/node/pull/65076
src/crypto/crypto_tls.cchttps://github.com/nodejs/node/pull/65076/files#diff-b6bc83442e6523d48f1604e1754451478337a6a70aa5fb0caba6628d878dc2fb
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 7, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5220221605
Please reload this pagehttps://github.com/nodejs/node/pull/65076
@pimterryhttps://github.com/pimterry
6e497bbhttps://github.com/nodejs/node/commit/6e497bbdbcbb3cebe30b1e289cd0d03124b5967c
Please reload this pagehttps://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 7, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-6e497bb
https://github.com/sankalpsthakur
tls: allow empty ALPNProtocols and keep C++ CHECK_EQhttps://github.com/sankalpsthakur/node/commit/6e497bbdbcbb3cebe30b1e289cd0d03124b5967c
6e497bbhttps://github.com/sankalpsthakur/node/commit/6e497bbdbcbb3cebe30b1e289cd0d03124b5967c
nodejs#65076https://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 8, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5224627317
Please reload this pagehttps://github.com/nodejs/node/pull/65076
@pimterryhttps://github.com/pimterry
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 8, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-4889072076
View reviewed changes https://github.com/nodejs/node/pull/65076/files
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 9, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-4891520827
View reviewed changes https://github.com/nodejs/node/pull/65076/files
https://github.com/pimterry
pimterryhttps://github.com/pimterry
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 9, 2026https://github.com/nodejs/node/pull/65076#event-29183847449
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 9, 2026https://github.com/nodejs/node/pull/65076#event-29184171262
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5231908629
https://ci.nodejs.org/job/node-test-pull-request/75694/https://ci.nodejs.org/job/node-test-pull-request/75694/
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 9, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5232276886
Please reload this pagehttps://github.com/nodejs/node/pull/65076
6e497bbhttps://github.com/nodejs/node/commit/6e497bbdbcbb3cebe30b1e289cd0d03124b5967c
193e77bhttps://github.com/nodejs/node/commit/193e77b5df846d7af6a381e53ac0ab988f7d14e8
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 9, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5234204518
Please reload this pagehttps://github.com/nodejs/node/pull/65076
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65076?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a48e33fhttps://app.codecov.io/gh/nodejs/node/commit/a48e33fb6f8e48be856da69692a17bc19a39317a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
e074e05https://app.codecov.io/gh/nodejs/node/commit/e074e0504d32698524dcf4bc7987d2a320f70a3d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65076?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/tls.jshttps://app.codecov.io/gh/nodejs/node/pull/65076?src=pr&el=tree&filepath=lib%2Ftls.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL3Rscy5qcw==
56 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65076/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/pimterry
pimterryhttps://github.com/pimterry
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 9, 2026https://github.com/nodejs/node/pull/65076#event-29195425740
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/82aed1846c339a6b85be0540b75289162af93b24..193e77b5df846d7af6a381e53ac0ab988f7d14e8
82aed18https://github.com/nodejs/node/commit/82aed1846c339a6b85be0540b75289162af93b24
193e77bhttps://github.com/nodejs/node/commit/193e77b5df846d7af6a381e53ac0ab988f7d14e8
Compare https://github.com/nodejs/node/compare/82aed1846c339a6b85be0540b75289162af93b24..193e77b5df846d7af6a381e53ac0ab988f7d14e8
August 18, 2026 04:45https://github.com/nodejs/node/pull/65076#event-29597608304
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 22, 2026https://github.com/nodejs/node/pull/65076#event-29836806869
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5377527205
@sankalpsthakurhttps://github.com/sankalpsthakur
rebasehttps://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-5-rebase
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/82aed1846c339a6b85be0540b75289162af93b24..1e49721e79deec315eccde6da68a724d5b82b4e5
82aed18https://github.com/nodejs/node/commit/82aed1846c339a6b85be0540b75289162af93b24
1e49721https://github.com/nodejs/node/commit/1e49721e79deec315eccde6da68a724d5b82b4e5
Compare https://github.com/nodejs/node/compare/82aed1846c339a6b85be0540b75289162af93b24..1e49721e79deec315eccde6da68a724d5b82b4e5
August 22, 2026 07:21https://github.com/nodejs/node/pull/65076#event-29841575525
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 22, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-d3e359f
https://github.com/sankalpsthakur
tls: validate ALPNProtocols in JS and cover server casehttps://github.com/sankalpsthakur/node/commit/d3e359f1be587e2cfce33100f8b64842f35d2267
d3e359fhttps://github.com/sankalpsthakur/node/commit/d3e359f1be587e2cfce33100f8b64842f35d2267
nodejs#65076https://github.com/nodejs/node/pull/65076
nodejs#65076https://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 22, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-6f951ae
https://github.com/sankalpsthakur
test: add validation for invalid ALPNProtocolshttps://github.com/sankalpsthakur/node/commit/6f951aefe345d1d147a34120f1e47ebf8a1d81e3
6f951aehttps://github.com/sankalpsthakur/node/commit/6f951aefe345d1d147a34120f1e47ebf8a1d81e3
nodejs#65069https://github.com/nodejs/node/issues/65069
nodejs#65076https://github.com/nodejs/node/pull/65076
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 22, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-9a83a24
https://github.com/sankalpsthakur
tls: allow empty ALPNProtocols and keep C++ CHECK_EQhttps://github.com/sankalpsthakur/node/commit/9a83a24b76735f4e96cca025298c45140d2c1bbd
9a83a24https://github.com/sankalpsthakur/node/commit/9a83a24b76735f4e96cca025298c45140d2c1bbd
nodejs#65076https://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 22, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5378987795
a48e33fhttps://github.com/nodejs/node/commit/a48e33fb6f8e48be856da69692a17bc19a39317a
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/1e49721e79deec315eccde6da68a724d5b82b4e5..eaaedf84dfad15b7732a5720f8a9998d85922567
1e49721https://github.com/nodejs/node/commit/1e49721e79deec315eccde6da68a724d5b82b4e5
eaaedf8https://github.com/nodejs/node/commit/eaaedf84dfad15b7732a5720f8a9998d85922567
Compare https://github.com/nodejs/node/compare/1e49721e79deec315eccde6da68a724d5b82b4e5..eaaedf84dfad15b7732a5720f8a9998d85922567
August 22, 2026 07:25https://github.com/nodejs/node/pull/65076#event-29841667184
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 22, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5379003362
eaaedf8https://github.com/nodejs/node/commit/eaaedf84dfad15b7732a5720f8a9998d85922567
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 22, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5381625207
@sankalpsthakurhttps://github.com/sankalpsthakur
instructionshttps://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes
Developer Certificate of Originhttps://github.com/nodejs/node/blob/main/CONTRIBUTING.md#developers-certificate-of-origin-11
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/73e91cba02d9c86a61b6f2517e76eedf04105110..4e001a7e9637aa590a11e67d504baa0f62c30108
73e91cbhttps://github.com/nodejs/node/commit/73e91cba02d9c86a61b6f2517e76eedf04105110
4e001a7https://github.com/nodejs/node/commit/4e001a7e9637aa590a11e67d504baa0f62c30108
Compare https://github.com/nodejs/node/compare/73e91cba02d9c86a61b6f2517e76eedf04105110..4e001a7e9637aa590a11e67d504baa0f62c30108
August 23, 2026 04:58https://github.com/nodejs/node/pull/65076#event-29864138940
https://github.com/sankalpsthakur
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/pull/65076/commits/e074e0504d32698524dcf4bc7987d2a320f70a3d
e074e05https://github.com/nodejs/node/pull/65076/commits/e074e0504d32698524dcf4bc7987d2a320f70a3d
nodejs#65069https://github.com/nodejs/node/issues/65069
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
force-pushedhttps://github.com/nodejs/node/compare/4e001a7e9637aa590a11e67d504baa0f62c30108..e074e0504d32698524dcf4bc7987d2a320f70a3d
4e001a7https://github.com/nodejs/node/commit/4e001a7e9637aa590a11e67d504baa0f62c30108
e074e05https://github.com/nodejs/node/commit/e074e0504d32698524dcf4bc7987d2a320f70a3d
Compare https://github.com/nodejs/node/compare/4e001a7e9637aa590a11e67d504baa0f62c30108..e074e0504d32698524dcf4bc7987d2a320f70a3d
August 23, 2026 04:59https://github.com/nodejs/node/pull/65076#event-29864141567
https://github.com/sankalpsthakur
sankalpsthakurhttps://github.com/sankalpsthakur
Aug 23, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5384313968
e074e05https://github.com/nodejs/node/commit/e074e0504d32698524dcf4bc7987d2a320f70a3d
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 23, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-5002954622
View reviewed changes https://github.com/nodejs/node/pull/65076/files/e074e0504d32698524dcf4bc7987d2a320f70a3d
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 23, 2026https://github.com/nodejs/node/pull/65076#event-29877082061
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 23, 2026https://github.com/nodejs/node/pull/65076#event-29877171777
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 23, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5387480724
https://ci.nodejs.org/job/node-test-pull-request/76313/https://ci.nodejs.org/job/node-test-pull-request/76313/
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 24, 2026 https://github.com/nodejs/node/pull/65076#pullrequestreview-5007357858
View reviewed changes https://github.com/nodejs/node/pull/65076/files/e074e0504d32698524dcf4bc7987d2a320f70a3d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 24, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5394638545
https://ci.nodejs.org/job/node-test-pull-request/76361/https://ci.nodejs.org/job/node-test-pull-request/76361/
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 24, 2026https://github.com/nodejs/node/pull/65076#event-29918113429
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
278ead1https://github.com/nodejs/node/commit/278ead184f6a39659bd7f6587695335b792a0fb2
Aug 24, 2026https://github.com/nodejs/node/pull/65076#event-29919178486
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 24, 2026https://github.com/nodejs/node/pull/65076#issuecomment-5396696286
278ead1https://github.com/nodejs/node/commit/278ead184f6a39659bd7f6587695335b792a0fb2
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 24, 2026https://github.com/nodejs/node/pull/65076#event-29919182642
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-8ec268f
https://github.com/sankalpsthakur
https://github.com/aduh95
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/commit/8ec268f9052e1415c0b797bba20bb38e58f9df7c
8ec268fhttps://github.com/nodejs/node/commit/8ec268f9052e1415c0b797bba20bb38e58f9df7c
#65069https://github.com/nodejs/node/issues/65069
#65076https://github.com/nodejs/node/pull/65076
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-2a0b1ec
https://github.com/sankalpsthakur
https://github.com/aduh95
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/commit/2a0b1ec4cca9740828b2b34cbc4497ac2ee0fc2f
2a0b1echttps://github.com/nodejs/node/commit/2a0b1ec4cca9740828b2b34cbc4497ac2ee0fc2f
#65069https://github.com/nodejs/node/issues/65069
#65076https://github.com/nodejs/node/pull/65076
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65076#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-810b8e2
https://github.com/sankalpsthakur
https://github.com/aduh95
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/commit/810b8e2cc121345b8d9cdacefdaeea3cf04640ed
810b8e2https://github.com/nodejs/node/commit/810b8e2cc121345b8d9cdacefdaeea3cf04640ed
#65069https://github.com/nodejs/node/issues/65069
#65076https://github.com/nodejs/node/pull/65076
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65076#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-cd136aa
https://github.com/sankalpsthakur
https://github.com/aduh95
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/commit/cd136aaff976d8860e3616a8ea14b121af263642
cd136aahttps://github.com/nodejs/node/commit/cd136aaff976d8860e3616a8ea14b121af263642
#65069https://github.com/nodejs/node/issues/65069
#65076https://github.com/nodejs/node/pull/65076
aduh95https://github.com/aduh95
Sep 7, 2026 https://github.com/nodejs/node/pull/65076#ref-commit-b0ef155
https://github.com/sankalpsthakur
https://github.com/aduh95
tls: throw on invalid ALPNProtocols instead of abortinghttps://github.com/nodejs/node/commit/b0ef155440b5a379004ccfad699e3b433aaba191
b0ef155https://github.com/nodejs/node/commit/b0ef155440b5a379004ccfad699e3b433aaba191
#65069https://github.com/nodejs/node/issues/65069
#65076https://github.com/nodejs/node/pull/65076
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65076
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/65076/files/6e497bbdbcbb3cebe30b1e289cd0d03124b5967c
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/65076/files/e074e0504d32698524dcf4bc7987d2a320f70a3d
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/65076/files/e074e0504d32698524dcf4bc7987d2a320f70a3d
Please reload this pagehttps://github.com/nodejs/node/pull/65076
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tls.connect() aborts process on malformed ALPNProtocols instead of throwing an error https://github.com/nodejs/node/issues/65069
Please reload this pagehttps://github.com/nodejs/node/pull/65076
https://github.com/sankalpsthakur
https://github.com/nodejs-github-bot
https://github.com/trivikr
https://github.com/jasnell
https://github.com/pimterry
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.