René's URL Explorer Experiment


Title: http: fix keylog listener setup on existing agent sockets by shani-singh1 · Pull Request #65066 · nodejs/node · GitHub

Open Graph Title: http: fix keylog listener setup on existing agent sockets by shani-singh1 · Pull Request #65066 · nodejs/node

X Title: http: fix keylog listener setup on existing agent sockets by shani-singh1 · Pull Request #65066 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: maybeEnableKeylog() runs as the agent's 'newListener' handler and attaches the agent's keylog handler to the sockets the agent already owns: // Existing sockets will start listening...

X Description: maybeEnableKeylog() runs as the agent's 'newListener' handler and attaches the agent's keylog handler to the sockets the agent already owns: // Existing sockets will...

Opengraph URL: https://github.com/nodejs/node/pull/65066

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:43374414-ce6b-b06c-cfe9-3bab9e3f5391
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCF4:1E2715:713AB9:92AA90:6AED2FD9
html-safe-nonce97e3426a42d06bb29263e0ea5b0ed5765e4258e77bdd8ee4f86599a88a8c439c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Y0OjFFMjcxNTo3MTNBQjk6OTJBQTkwOjZBRUQyRkQ5IiwidmlzaXRvcl9pZCI6Ijg0NDY5NTExNTEwNzU0MDU3ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0136bcc06b00792a6fe99a8f0b67b092b47d0fd89037c8d7e39c3a4209c0141c
hovercard-subject-tagpull_request:4217313379
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65066/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c267e84108766c5c157a990398b1656fec2cee7add868ba325ba889d58df63ea/nodejs/node/pull/65066
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c267e84108766c5c157a990398b1656fec2cee7add868ba325ba889d58df63ea/nodejs/node/pull/65066
og:image:altmaybeEnableKeylog() runs as the agent's 'newListener' handler and attaches the agent's keylog handler to the sockets the agent already owns: // Existing sockets will start listening...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshani-singh1
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65066#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65066
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65066
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65066
Reloadhttps://github.com/nodejs/node/pull/65066
Reloadhttps://github.com/nodejs/node/pull/65066
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
shani-singh1:http-agent-keylog-existing-socketshttps://github.com/shani-singh1/node/tree/http-agent-keylog-existing-sockets
Conversationhttps://github.com/nodejs/node/pull/65066
Commits1 (1)https://github.com/nodejs/node/pull/65066/commits
Checkshttps://github.com/nodejs/node/pull/65066/checks
Files changedhttps://github.com/nodejs/node/pull/65066/files
http: fix keylog listener setup on existing agent socketshttps://github.com/nodejs/node/pull/65066#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
shani-singh1:http-agent-keylog-existing-socketshttps://github.com/shani-singh1/node/tree/http-agent-keylog-existing-sockets
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issue-5076939896
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5199656185
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 6, 2026https://github.com/nodejs/node/pull/65066#event-29043781172
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5203693912
Please reload this pagehttps://github.com/nodejs/node/pull/65066
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65066?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
51c0d94https://app.codecov.io/gh/nodejs/node/commit/51c0d9407211b433ded3dfb65061a6fa003d2dd7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9058cd0https://app.codecov.io/gh/nodejs/node/commit/9058cd0a8adea3ed974f5673772702232abcb810?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65066?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/_http_agent.jshttps://app.codecov.io/gh/nodejs/node/pull/65066?src=pr&el=tree&filepath=lib%2F_http_agent.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2FnZW50Lmpz
38 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65066/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 6, 2026 https://github.com/nodejs/node/pull/65066#pullrequestreview-4874026819
View reviewed changes https://github.com/nodejs/node/pull/65066/files/9058cd0a8adea3ed974f5673772702232abcb810
pimterryhttps://github.com/pimterry
https://github.com/nodejs/node/pull/65066#pullrequestreview-4874026819
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@shani-singh1https://github.com/shani-singh1
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/shani-singh1
http: fix keylog listener setup on existing agent socketshttps://github.com/nodejs/node/pull/65066/commits/9058cd0a8adea3ed974f5673772702232abcb810
9058cd0https://github.com/nodejs/node/pull/65066/commits/9058cd0a8adea3ed974f5673772702232abcb810
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
force-pushedhttps://github.com/nodejs/node/compare/898e68530ff3e72bfae0bd0589920bf229ad5025..9058cd0a8adea3ed974f5673772702232abcb810
898e685https://github.com/nodejs/node/commit/898e68530ff3e72bfae0bd0589920bf229ad5025
9058cd0https://github.com/nodejs/node/commit/9058cd0a8adea3ed974f5673772702232abcb810
Compare https://github.com/nodejs/node/compare/898e68530ff3e72bfae0bd0589920bf229ad5025..9058cd0a8adea3ed974f5673772702232abcb810
August 6, 2026 11:18https://github.com/nodejs/node/pull/65066#event-29064448820
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5204163791
9058cd0https://github.com/nodejs/node/commit/9058cd0a8adea3ed974f5673772702232abcb810
#65064https://github.com/nodejs/node/pull/65064
#65065https://github.com/nodejs/node/pull/65065
#65067https://github.com/nodejs/node/pull/65067
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 6, 2026 https://github.com/nodejs/node/pull/65066#pullrequestreview-4874652090
View reviewed changes https://github.com/nodejs/node/pull/65066/files/9058cd0a8adea3ed974f5673772702232abcb810
https://github.com/pimterry
pimterryhttps://github.com/pimterry
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 6, 2026https://github.com/nodejs/node/pull/65066#event-29067897886
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 6, 2026https://github.com/nodejs/node/pull/65066#event-29069328152
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5205023303
https://ci.nodejs.org/job/node-test-pull-request/75562/https://ci.nodejs.org/job/node-test-pull-request/75562/
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/pimterry
pimterryhttps://github.com/pimterry
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 6, 2026https://github.com/nodejs/node/pull/65066#event-29081387574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5207908869
https://ci.nodejs.org/job/node-test-pull-request/75580/https://ci.nodejs.org/job/node-test-pull-request/75580/
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/pimterry
pimterryhttps://github.com/pimterry
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65066#event-29570186074
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
45d6d31https://github.com/nodejs/node/commit/45d6d31279be840e2f4184d72dbe0f369c481c29
Aug 17, 2026https://github.com/nodejs/node/pull/65066#event-29576396084
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/65066#issuecomment-5318966177
45d6d31https://github.com/nodejs/node/commit/45d6d31279be840e2f4184d72dbe0f369c481c29
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/65066#event-29576399568
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65066#ref-commit-65f428e
https://github.com/shani-singh1
https://github.com/aduh95
http: fix keylog listener setup on existing agent socketshttps://github.com/nodejs/node/commit/65f428ee99a228c4636be0ed671ecd6a37c59322
65f428ehttps://github.com/nodejs/node/commit/65f428ee99a228c4636be0ed671ecd6a37c59322
#65066https://github.com/nodejs/node/pull/65066
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65066#ref-commit-6c3516f
https://github.com/shani-singh1
https://github.com/aduh95
http: fix keylog listener setup on existing agent socketshttps://github.com/nodejs/node/commit/6c3516f17970248ea19078026426970e85ced511
6c3516fhttps://github.com/nodejs/node/commit/6c3516f17970248ea19078026426970e85ced511
#65066https://github.com/nodejs/node/pull/65066
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65066#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65066#ref-commit-04785c8
https://github.com/shani-singh1
https://github.com/aduh95
http: fix keylog listener setup on existing agent socketshttps://github.com/nodejs/node/commit/04785c8f439834f62ee9d1d92f585e7b09a58ea7
04785c8https://github.com/nodejs/node/commit/04785c8f439834f62ee9d1d92f585e7b09a58ea7
#65066https://github.com/nodejs/node/pull/65066
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65066#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65066
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/65066/files/9058cd0a8adea3ed974f5673772702232abcb810
Please reload this pagehttps://github.com/nodejs/node/pull/65066
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65066
https://github.com/shani-singh1
https://github.com/nodejs-github-bot
https://github.com/pimterry
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.