René's URL Explorer Experiment


Title: stream: clean up when pipeline throws synchronously by shani-singh1 · Pull Request #65064 · nodejs/node · GitHub

Open Graph Title: stream: clean up when pipeline throws synchronously by shani-singh1 · Pull Request #65064 · nodejs/node

X Title: stream: clean up when pipeline throws synchronously by shani-singh1 · Pull Request #65064 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: pipelineImpl() wires the streams together in a loop that can throw synchronously. The most common case is ERR_STREAM_UNABLE_TO_PIPE, raised when the next stream is already closed or destroyed, whic...

X Description: pipelineImpl() wires the streams together in a loop that can throw synchronously. The most common case is ERR_STREAM_UNABLE_TO_PIPE, raised when the next stream is already closed or destroyed, whic...

Opengraph URL: https://github.com/nodejs/node/pull/65064

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:49d7f6d2-31df-fd02-1c1d-1c0a279119ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4B0:19E603:773DBC:9B0383:6AED3259
html-safe-nonce84db7f35260984fdda372098e27d7bcec45fc433767fce3172a2aef47adbafae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEIwOjE5RTYwMzo3NzNEQkM6OUIwMzgzOjZBRUQzMjU5IiwidmlzaXRvcl9pZCI6IjQyNzE3Mjg0MTUxNjYyNDc1MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacebde11076478e4fd0f4798989456ef2b4ff4d41779f6e542841470fab7293160
hovercard-subject-tagpull_request:4217190436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65064/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f44e8714c18f654886b7307595a2fc8d5f994fbf24510bec4f7dacfeeb506034/nodejs/node/pull/65064
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f44e8714c18f654886b7307595a2fc8d5f994fbf24510bec4f7dacfeeb506034/nodejs/node/pull/65064
og:image:altpipelineImpl() wires the streams together in a loop that can throw synchronously. The most common case is ERR_STREAM_UNABLE_TO_PIPE, raised when the next stream is already closed or destroyed, whic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshani-singh1
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65064#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65064
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65064
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65064
Reloadhttps://github.com/nodejs/node/pull/65064
Reloadhttps://github.com/nodejs/node/pull/65064
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests665 (665)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
shani-singh1https://github.com/shani-singh1
nodejs:mainhttps://github.com/nodejs/node/tree/main
shani-singh1:stream-pipeline-sync-throw-leakhttps://github.com/shani-singh1/node/tree/stream-pipeline-sync-throw-leak
Conversationhttps://github.com/nodejs/node/pull/65064
Commits1 (1)https://github.com/nodejs/node/pull/65064/commits
Checkshttps://github.com/nodejs/node/pull/65064/checks
Files changedhttps://github.com/nodejs/node/pull/65064/files
stream: clean up when pipeline throws synchronouslyhttps://github.com/nodejs/node/pull/65064#top
shani-singh1https://github.com/shani-singh1
nodejs:mainhttps://github.com/nodejs/node/tree/main
shani-singh1:stream-pipeline-sync-throw-leakhttps://github.com/shani-singh1/node/tree/stream-pipeline-sync-throw-leak
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026https://github.com/nodejs/node/pull/65064#issue-5076789950
#65063https://github.com/nodejs/node/issues/65063
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65064#issuecomment-5199475336
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Aug 6, 2026https://github.com/nodejs/node/pull/65064#event-29042938350
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
force-pushedhttps://github.com/nodejs/node/compare/9c3b6a818ec6dd13796a0b11e9576c16dd0cf66a..cb6d8990110e9509350e27dd568dea1d4a3b2e93
9c3b6a8https://github.com/nodejs/node/commit/9c3b6a818ec6dd13796a0b11e9576c16dd0cf66a
cb6d899https://github.com/nodejs/node/commit/cb6d8990110e9509350e27dd568dea1d4a3b2e93
Compare https://github.com/nodejs/node/compare/9c3b6a818ec6dd13796a0b11e9576c16dd0cf66a..cb6d8990110e9509350e27dd568dea1d4a3b2e93
August 6, 2026 11:17https://github.com/nodejs/node/pull/65064#event-29064416346
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026 https://github.com/nodejs/node/pull/65064#ref-pullrequest-5076939896
http: fix keylog listener setup on existing agent sockets #65066 https://github.com/nodejs/node/pull/65066
https://github.com/ronag
ronaghttps://github.com/ronag
Copilothttps://github.com/apps/copilot-pull-request-reviewer
August 6, 2026 12:28https://github.com/nodejs/node/pull/65064#event-29067448028
started reviewinghttps://github.com/nodejs/node/sessions/36ec5023-e90d-4969-8221-87ffd9d38948
ronaghttps://github.com/ronag
August 6, 2026 12:28https://github.com/nodejs/node/pull/65064#event-29067473879
View session https://github.com/nodejs/node/sessions/36ec5023-e90d-4969-8221-87ffd9d38948
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 6, 2026 https://github.com/nodejs/node/pull/65064#pullrequestreview-4874582417
View reviewed changes https://github.com/nodejs/node/pull/65064/files
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/65064#pullrequestreview-4874582417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Aug 6, 2026 https://github.com/nodejs/node/pull/65064#pullrequestreview-4874627093
View reviewed changes https://github.com/nodejs/node/pull/65064/files
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/nodejs/node/pull/65064#pullrequestreview-4874627093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add Copilot custom instructionshttps://github.com/nodejs/node/new/main?filename=.github/instructions/*.instructions.md
Learn how to get startedhttps://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot
Please reload this pagehttps://github.com/nodejs/node/pull/65064
lib/internal/streams/pipeline.jshttps://github.com/nodejs/node/pull/65064/files#diff-95c23fb6674af85f6f23a374851af6cccf58fb4617d73897df5078ba537a862c
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026https://github.com/nodejs/node/pull/65064#issuecomment-5208721271
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 6, 2026 https://github.com/nodejs/node/pull/65064#pullrequestreview-4878019242
View reviewed changes https://github.com/nodejs/node/pull/65064/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65064#pullrequestreview-4878019242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 6, 2026https://github.com/nodejs/node/pull/65064#event-29086242288
https://github.com/shani-singh1
stream: dispose abort listener when pipeline throwshttps://github.com/nodejs/node/pull/65064/commits/c4f4c9f0c0cecba82cc5640c619a11437c6c01bd
c4f4c9fhttps://github.com/nodejs/node/pull/65064/commits/c4f4c9f0c0cecba82cc5640c619a11437c6c01bd
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
force-pushedhttps://github.com/nodejs/node/compare/cb6d8990110e9509350e27dd568dea1d4a3b2e93..c4f4c9f0c0cecba82cc5640c619a11437c6c01bd
cb6d899https://github.com/nodejs/node/commit/cb6d8990110e9509350e27dd568dea1d4a3b2e93
c4f4c9fhttps://github.com/nodejs/node/commit/c4f4c9f0c0cecba82cc5640c619a11437c6c01bd
Compare https://github.com/nodejs/node/compare/cb6d8990110e9509350e27dd568dea1d4a3b2e93..c4f4c9f0c0cecba82cc5640c619a11437c6c01bd
August 6, 2026 21:41https://github.com/nodejs/node/pull/65064#event-29088144783
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 6, 2026https://github.com/nodejs/node/pull/65064#issuecomment-5209313739
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 8, 2026 https://github.com/nodejs/node/pull/65064#ref-issue-5095981501
stream.pipeline() can both throw synchronously and invoke the callback reporting success #65127 https://github.com/nodejs/node/issues/65127
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Aug 8, 2026https://github.com/nodejs/node/pull/65064#issuecomment-5224676492
#65127https://github.com/nodejs/node/issues/65127
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/pacocartones
pacocartoneshttps://github.com/pacocartones
Aug 12, 2026 https://github.com/nodejs/node/pull/65064#ref-pullrequest-5103307402
stream: prevent pipeline() callback after sync throw #65165 https://github.com/nodejs/node/pull/65165
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 22, 2026 https://github.com/nodejs/node/pull/65064#ref-pullrequest-5096189186
stream: skip pipeline callback on sync throw #65128 https://github.com/nodejs/node/pull/65128
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2026https://github.com/nodejs/node/pull/65064#issuecomment-5454779133
https://ci.nodejs.org/job/node-test-pull-request/76640/https://ci.nodejs.org/job/node-test-pull-request/76640/
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/sxa
sxahttps://github.com/sxa
Aug 28, 2026 https://github.com/nodejs/node/pull/65064#ref-issue-5267893624
Auto Start CI delayed running 2 - 3 hours instead of every 5 minutes nodejs/build#4443 https://github.com/nodejs/build/issues/4443
https://github.com/panva
panvahttps://github.com/panva
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 28, 2026https://github.com/nodejs/node/pull/65064#event-30175680274
https://github.com/Musicminion
Musicminionhttps://github.com/Musicminion
Oct 4, 2026 https://github.com/nodejs/node/pull/65064#ref-pullrequest-5701712164
Handle synchronous pipeline errors when clients disconnect overleaf/overleaf#1526 https://github.com/overleaf/overleaf/pull/1526
https://github.com/shani-singh1
shani-singh1https://github.com/shani-singh1
Nov 5, 2026https://github.com/nodejs/node/pull/65064#issuecomment-6670156359
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65064
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/nodejs/node/pull/65064/files/cb6d8990110e9509350e27dd568dea1d4a3b2e93
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/65064/files/cb6d8990110e9509350e27dd568dea1d4a3b2e93
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65064/files/cb6d8990110e9509350e27dd568dea1d4a3b2e93
Please reload this pagehttps://github.com/nodejs/node/pull/65064
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream.pipeline() leaks file descriptors when it throws synchronously (ERR_STREAM_UNABLE_TO_PIPE) https://github.com/nodejs/node/issues/65063
Please reload this pagehttps://github.com/nodejs/node/pull/65064
https://github.com/shani-singh1
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/ronag
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/panva
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.