René's URL Explorer Experiment


Title: dns: validate port range in `setServers()` by Renegade334 · Pull Request #65021 · nodejs/node · GitHub

Open Graph Title: dns: validate port range in `setServers()` by Renegade334 · Pull Request #65021 · nodejs/node

X Title: dns: validate port range in `setServers()` by Renegade334 · Pull Request #65021 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: As per #65009 (review). dns.setServers() currently has the following shenanigans with out-of-range port numbers: uint16 overflow (seems version-/platform-dependent) dns.setServers(['1.2.3.4:65...

X Description: As per #65009 (review). dns.setServers() currently has the following shenanigans with out-of-range port numbers: uint16 overflow (seems version-/platform-dependent) dns.setServers(['1.2.3....

Opengraph URL: https://github.com/nodejs/node/pull/65021

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05d0824e-f588-5b24-57d0-8e611d55cf8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B5C:147263:3A63A5:4F299C:6AED15F2
html-safe-nonce70a57eb30ee166295c0c1bbbebc2f5cfd853f95123b86dd8858b9dc4388a8d28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjVDOjE0NzI2MzozQTYzQTU6NEYyOTlDOjZBRUQxNUYyIiwidmlzaXRvcl9pZCI6IjkzODg3Mjg5NDg1MjUwMzAyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac589862170f6c018cd32a74cb926002f5a6ada9e71d6ff3a54b099639e323cc6c
hovercard-subject-tagpull_request:4204965279
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65021/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/497b2f2a7ad3bb012bd10e548909554289f08496da7f96fcfbade19fdbe980db/nodejs/node/pull/65021
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/497b2f2a7ad3bb012bd10e548909554289f08496da7f96fcfbade19fdbe980db/nodejs/node/pull/65021
og:image:altAs per #65009 (review). dns.setServers() currently has the following shenanigans with out-of-range port numbers: uint16 overflow (seems version-/platform-dependent) dns.setServers(['1.2.3.4:65...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRenegade334
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65021#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65021
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65021
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65021
Reloadhttps://github.com/nodejs/node/pull/65021
Reloadhttps://github.com/nodejs/node/pull/65021
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
Renegade334https://github.com/Renegade334
nodejs:mainhttps://github.com/nodejs/node/tree/main
Renegade334:dns-validate-setservers-portshttps://github.com/Renegade334/node/tree/dns-validate-setservers-ports
Conversationhttps://github.com/nodejs/node/pull/65021
Commits1 (1)https://github.com/nodejs/node/pull/65021/commits
Checkshttps://github.com/nodejs/node/pull/65021/checks
Files changedhttps://github.com/nodejs/node/pull/65021/files
dns: validate port range in setServers()https://github.com/nodejs/node/pull/65021#top
Renegade334https://github.com/Renegade334
nodejs:mainhttps://github.com/nodejs/node/tree/main
Renegade334:dns-validate-setservers-portshttps://github.com/Renegade334/node/tree/dns-validate-setservers-ports
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 4, 2026https://github.com/nodejs/node/pull/65021#issue-5062355470
#65009 (review)https://github.com/nodejs/node/pull/65009#pullrequestreview-4855375767
#65009https://github.com/nodejs/node/pull/65009
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/Renegade334
dns: validate port range in setServers()https://github.com/nodejs/node/pull/65021/commits/16f5b73c807654d2239ec4437d3cac3d22478001
16f5b73https://github.com/nodejs/node/pull/65021/commits/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2026https://github.com/nodejs/node/pull/65021#issuecomment-5181398790
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65021#event-28959826730
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Aug 4, 2026 https://github.com/nodejs/node/pull/65021#pullrequestreview-4857261647
View reviewed changes https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65021#event-28965071570
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 4, 2026https://github.com/nodejs/node/pull/65021#issuecomment-5182707502
Please reload this pagehttps://github.com/nodejs/node/pull/65021
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65021?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
1576cb8https://app.codecov.io/gh/nodejs/node/commit/1576cb83b499e91cd0be24b759696490518f5672?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
16f5b73https://app.codecov.io/gh/nodejs/node/commit/16f5b73c807654d2239ec4437d3cac3d22478001?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65021?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/dns/utils.jshttps://app.codecov.io/gh/nodejs/node/pull/65021?src=pr&el=tree&filepath=lib%2Finternal%2Fdns%2Futils.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2Rucy91dGlscy5qcw==
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65021/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65021#event-28966426874
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65021
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2026https://github.com/nodejs/node/pull/65021#issuecomment-5185711775
https://ci.nodejs.org/job/node-test-pull-request/75493/https://ci.nodejs.org/job/node-test-pull-request/75493/
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 5, 2026 https://github.com/nodejs/node/pull/65021#pullrequestreview-4862406347
View reviewed changes https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 5, 2026https://github.com/nodejs/node/pull/65021#event-29024299053
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 5, 2026 https://github.com/nodejs/node/pull/65021#pullrequestreview-4868689904
View reviewed changes https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
e2d7b34https://github.com/nodejs/node/commit/e2d7b3416402e611fdb023fb4531bf5b861721b6
Aug 7, 2026https://github.com/nodejs/node/pull/65021#event-29119610548
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
August 7, 2026 13:06https://github.com/nodejs/node/pull/65021#event-29119641413
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 7, 2026https://github.com/nodejs/node/pull/65021#event-29119643787
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 7, 2026https://github.com/nodejs/node/pull/65021#issuecomment-5217455713
e2d7b34https://github.com/nodejs/node/commit/e2d7b3416402e611fdb023fb4531bf5b861721b6
Please reload this pagehttps://github.com/nodejs/node/pull/65021
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/65021#ref-commit-bbfa75c
https://github.com/Renegade334
https://github.com/aduh95
dns: validate port range in setServers()https://github.com/nodejs/node/commit/bbfa75c0a9c04ba085aa5bf6ef7d9a56e7a07c47
bbfa75chttps://github.com/nodejs/node/commit/bbfa75c0a9c04ba085aa5bf6ef7d9a56e7a07c47
#65021https://github.com/nodejs/node/pull/65021
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65021#ref-commit-00c71fe
https://github.com/Renegade334
https://github.com/aduh95
dns: validate port range in setServers()https://github.com/nodejs/node/commit/00c71fec936c063beeaa09fa705ebf1c2681e132
00c71fehttps://github.com/nodejs/node/commit/00c71fec936c063beeaa09fa705ebf1c2681e132
#65021https://github.com/nodejs/node/pull/65021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65021#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65021#ref-commit-15f95fc
https://github.com/Renegade334
https://github.com/aduh95
dns: validate port range in setServers()https://github.com/nodejs/node/commit/15f95fc0e218530a8e870778a7f613c5f18d9532
15f95fchttps://github.com/nodejs/node/commit/15f95fc0e218530a8e870778a7f613c5f18d9532
#65021https://github.com/nodejs/node/pull/65021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65021#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/65021#ref-pullrequest-6092136976
dns: refuse setServers() ports above 65535 oven-sh/bun#47302 https://github.com/oven-sh/bun/pull/47302
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/65021#ref-commit-18ff162
https://github.com/robobun
dns: refuse setServers() ports above 65535https://github.com/oven-sh/bun/commit/18ff1624dcfab55ebc6deed27b24f847c11f2a30
18ff162https://github.com/oven-sh/bun/commit/18ff1624dcfab55ebc6deed27b24f847c11f2a30
nodejs/node#65021https://github.com/nodejs/node/pull/65021
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65021
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
https://github.com/avivkeller
avivkeller https://github.com/avivkeller
https://github.com/nodejs/node/pull/65021/files/16f5b73c807654d2239ec4437d3cac3d22478001
Please reload this pagehttps://github.com/nodejs/node/pull/65021
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/65021
https://github.com/Renegade334
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/pimterry
https://github.com/avivkeller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.