René's URL Explorer Experiment


Title: dns: fix crash on setServers with port 0 by lazerg · Pull Request #65009 · nodejs/node · GitHub

Open Graph Title: dns: fix crash on setServers with port 0 by lazerg · Pull Request #65009 · nodejs/node

X Title: dns: fix crash on setServers with port 0 by lazerg · Pull Request #65009 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: dns.setServers(['1.1.1.1:0']) aborts the process: Assertion failed: portValue->Int32Value(env->context()).FromJust() SetServers() in src/cares_wrap.cc checked the port with CHECK(por...

X Description: dns.setServers(['1.1.1.1:0']) aborts the process: Assertion failed: portValue->Int32Value(env->context()).FromJust() SetServers() in src/cares_wrap.cc checked the por...

Opengraph URL: https://github.com/nodejs/node/pull/65009

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b6b4f872-1b90-66a1-4a12-f98e32dd0258
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD84:146BDA:10D3F1:166C31:6AED09B8
html-safe-noncef8d1183a63901ce7ad0437daac8146f6f4e61146a0789290c48af732f33c9782
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDg0OjE0NkJEQToxMEQzRjE6MTY2QzMxOjZBRUQwOUI4IiwidmlzaXRvcl9pZCI6IjgyNzA2NTU3NTMwMzA1MzU2MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac37ca8b00c9ae793e6641ff2bcdd59b4a6bdaf1b1ce7a191920a5ec6310829795
hovercard-subject-tagpull_request:4202594736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/65009/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f6411c5f621b3ddebda974cbff2e1a3ddd0c209adfd8aaa819ae401856d617f4/nodejs/node/pull/65009
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f6411c5f621b3ddebda974cbff2e1a3ddd0c209adfd8aaa819ae401856d617f4/nodejs/node/pull/65009
og:image:altdns.setServers(['1.1.1.1:0']) aborts the process: Assertion failed: portValue->Int32Value(env->context()).FromJust() SetServers() in src/cares_wrap.cc checked the port with CHECK(por...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelazerg
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/65009#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65009
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65009
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/65009
Reloadhttps://github.com/nodejs/node/pull/65009
Reloadhttps://github.com/nodejs/node/pull/65009
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65006-setservers-port-zerohttps://github.com/lazerg/node/tree/fix/issue-65006-setservers-port-zero
Conversationhttps://github.com/nodejs/node/pull/65009
Commits2 (2)https://github.com/nodejs/node/pull/65009/commits
Checkshttps://github.com/nodejs/node/pull/65009/checks
Files changedhttps://github.com/nodejs/node/pull/65009/files
dns: fix crash on setServers with port 0https://github.com/nodejs/node/pull/65009#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
lazerg:fix/issue-65006-setservers-port-zerohttps://github.com/lazerg/node/tree/fix/issue-65006-setservers-port-zero
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 4, 2026https://github.com/nodejs/node/pull/65009#issue-5059593972
#65006https://github.com/nodejs/node/issues/65006
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/lazerg
dns: fix crash on setServers with port 0https://github.com/nodejs/node/pull/65009/commits/948d7580ab467b143ba0d92bbe60b2dd4305175c
948d758https://github.com/nodejs/node/pull/65009/commits/948d7580ab467b143ba0d92bbe60b2dd4305175c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2026https://github.com/nodejs/node/pull/65009#issuecomment-5177997464
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65009#event-28943398668
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 4, 2026 https://github.com/nodejs/node/pull/65009#pullrequestreview-4854634651
View reviewed changes https://github.com/nodejs/node/pull/65009/files/948d7580ab467b143ba0d92bbe60b2dd4305175c
src/cares_wrap.cchttps://github.com/nodejs/node/pull/65009/files/948d7580ab467b143ba0d92bbe60b2dd4305175c#diff-3befb8d112e0c02f9a96b1e6d35dca06ac78ede6de0c2284e981cf181860d0ec
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/lazerg
dns: keep type assertions in SetServershttps://github.com/nodejs/node/pull/65009/commits/42c89eefdb8c691aba57c624c998bd98301e9e89
42c89eehttps://github.com/nodejs/node/pull/65009/commits/42c89eefdb8c691aba57c624c998bd98301e9e89
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 4, 2026 https://github.com/nodejs/node/pull/65009#pullrequestreview-4855375767
View reviewed changes https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
Renegade334https://github.com/Renegade334
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/nodejs/node/pull/65009#pullrequestreview-4855375767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/lazerg
lazerghttps://github.com/lazerg
Aug 4, 2026https://github.com/nodejs/node/pull/65009#issuecomment-5180223148
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 4, 2026 https://github.com/nodejs/node/pull/65009#pullrequestreview-4855645956
View reviewed changes https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/65009#pullrequestreview-4855645956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65009#event-28955339093
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Aug 4, 2026https://github.com/nodejs/node/pull/65009#event-28955368176
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 4, 2026https://github.com/nodejs/node/pull/65009#event-28957208489
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65009
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 4, 2026https://github.com/nodejs/node/pull/65009#issuecomment-5181316379
Please reload this pagehttps://github.com/nodejs/node/pull/65009
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/65009?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ece8bbehttps://app.codecov.io/gh/nodejs/node/commit/ece8bbef9770f7169c3649374e6e0d6bb6483fab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
42c89eehttps://app.codecov.io/gh/nodejs/node/commit/42c89eefdb8c691aba57c624c998bd98301e9e89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65009?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/cares_wrap.cchttps://app.codecov.io/gh/nodejs/node/pull/65009?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M=
0 Missing and 2 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/65009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/65009?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/cares_wrap.cchttps://app.codecov.io/gh/nodejs/node/pull/65009?src=pr&el=tree&filepath=src%2Fcares_wrap.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NhcmVzX3dyYXAuY2M=
54 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/65009/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Aug 4, 2026 https://github.com/nodejs/node/pull/65009#ref-pullrequest-5062355470
dns: validate port range in setServers() #65021 https://github.com/nodejs/node/pull/65021
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2026https://github.com/nodejs/node/pull/65009#issuecomment-5183262182
https://ci.nodejs.org/job/node-test-pull-request/75482/https://ci.nodejs.org/job/node-test-pull-request/75482/
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 4, 2026https://github.com/nodejs/node/pull/65009#event-28979574791
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Aug 5, 2026 https://github.com/nodejs/node/pull/65009#pullrequestreview-4861939058
View reviewed changes https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 6, 2026https://github.com/nodejs/node/pull/65009#event-29064141602
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ee64033https://github.com/nodejs/node/commit/ee64033c8434a715ab9f2cf8121da19dc37c8af8
Aug 6, 2026https://github.com/nodejs/node/pull/65009#event-29064244599
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/65009#issuecomment-5203887090
ee64033https://github.com/nodejs/node/commit/ee64033c8434a715ab9f2cf8121da19dc37c8af8
Please reload this pagehttps://github.com/nodejs/node/pull/65009
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/65009#ref-commit-0b64b5d
https://github.com/lazerg
https://github.com/aduh95
dns: fix crash on setServers with port 0https://github.com/nodejs/node/commit/0b64b5d433d17102a293b9b349c439184d7674b3
0b64b5dhttps://github.com/nodejs/node/commit/0b64b5d433d17102a293b9b349c439184d7674b3
#65009https://github.com/nodejs/node/pull/65009
#65006https://github.com/nodejs/node/issues/65006
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/65009#ref-commit-e9327d1
https://github.com/lazerg
https://github.com/aduh95
dns: fix crash on setServers with port 0https://github.com/nodejs/node/commit/e9327d1422beed5a5d98b769631cc8602d22841c
e9327d1https://github.com/nodejs/node/commit/e9327d1422beed5a5d98b769631cc8602d22841c
#65009https://github.com/nodejs/node/pull/65009
#65006https://github.com/nodejs/node/issues/65006
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/65009#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/65009#ref-commit-37b9e9a
https://github.com/lazerg
https://github.com/aduh95
dns: fix crash on setServers with port 0https://github.com/nodejs/node/commit/37b9e9a1545aead015fc90979c15ca40f71080dd
37b9e9ahttps://github.com/nodejs/node/commit/37b9e9a1545aead015fc90979c15ca40f71080dd
#65009https://github.com/nodejs/node/pull/65009
#65006https://github.com/nodejs/node/issues/65006
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/65009#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.com/robobun
robobunhttps://github.com/robobun
Oct 29, 2026 https://github.com/nodejs/node/pull/65009#ref-pullrequest-6092136976
dns: refuse setServers() ports above 65535 oven-sh/bun#47302 https://github.com/oven-sh/bun/pull/47302
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F65009
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/65009/files/42c89eefdb8c691aba57c624c998bd98301e9e89
Please reload this pagehttps://github.com/nodejs/node/pull/65009
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
cares https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acares
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
dns.setServers.apply triggers SIGABRT when passed an address with port 0 https://github.com/nodejs/node/issues/65006
Please reload this pagehttps://github.com/nodejs/node/pull/65009
https://github.com/lazerg
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/pimterry
https://github.com/Renegade334
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.