René's URL Explorer Experiment


Title: ffi: remove dead null check in callback arguments by trivikr · Pull Request #64998 · nodejs/node · GitHub

Open Graph Title: ffi: remove dead null check in callback arguments by trivikr · Pull Request #64998 · nodejs/node

X Title: ffi: remove dead null check in callback arguments by trivikr · Pull Request #64998 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: InvokeCallback tested args[i] == nullptr and mapped the argument to JS null. args is libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argument,...

X Description: InvokeCallback tested args[i] == nullptr and mapped the argument to JS null. args is libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argum...

Opengraph URL: https://github.com/nodejs/node/pull/64998

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:99d9e17d-eb9f-7ea4-6ae2-6e16b749dfdb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9190:20309E:2B35C4:3834E7:6AED1B88
html-safe-nonce60c57e4de2095d93bf51ae4b3854fc7fd5b52b85ebc516ebae47aaf2b1ed6ce4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTkwOjIwMzA5RToyQjM1QzQ6MzgzNEU3OjZBRUQxQjg4IiwidmlzaXRvcl9pZCI6IjE1OTA4OTI1OTczMTc4MDI4ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5a50575d91351c8410ca72c2ae8894ac6f777d4da1c7135a6e273d0a2025cf0b
hovercard-subject-tagpull_request:4200000843
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64998/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cbd4d2317d10ca964d21a043cb5418dfa221b2d2b9aa0c0f35f57d41fe858223/nodejs/node/pull/64998
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cbd4d2317d10ca964d21a043cb5418dfa221b2d2b9aa0c0f35f57d41fe858223/nodejs/node/pull/64998
og:image:altInvokeCallback tested args[i] == nullptr and mapped the argument to JS null. args is libffi's avalue array, and libffi always points each slot at its own storage for the corresponding argument,...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64998#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64998
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64998
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64998
Reloadhttps://github.com/nodejs/node/pull/64998
Reloadhttps://github.com/nodejs/node/pull/64998
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-invoke-callback-dead-branchhttps://github.com/trivikr/node/tree/ffi-invoke-callback-dead-branch
Conversationhttps://github.com/nodejs/node/pull/64998
Commits1 (1)https://github.com/nodejs/node/pull/64998/commits
Checkshttps://github.com/nodejs/node/pull/64998/checks
Files changedhttps://github.com/nodejs/node/pull/64998/files
ffi: remove dead null check in callback argumentshttps://github.com/nodejs/node/pull/64998#top
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-invoke-callback-dead-branchhttps://github.com/trivikr/node/tree/ffi-invoke-callback-dead-branch
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 4, 2026https://github.com/nodejs/node/pull/64998#issue-5056533837
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2026https://github.com/nodejs/node/pull/64998#issuecomment-5174425082
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 4, 2026https://github.com/nodejs/node/pull/64998#event-28925985539
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
Aug 4, 2026https://github.com/nodejs/node/pull/64998#event-28927364988
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 4, 2026https://github.com/nodejs/node/pull/64998#issuecomment-5175013617
Please reload this pagehttps://github.com/nodejs/node/pull/64998
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64998?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8f6c69fhttps://app.codecov.io/gh/nodejs/node/commit/8f6c69fc4c60029391d3f5828e3c60e3c55ce7e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d95dba2https://app.codecov.io/gh/nodejs/node/commit/d95dba23d467a874c8e71078c9547151b2e52f5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64998?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/64998?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
37 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64998/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 7, 2026https://github.com/nodejs/node/pull/64998#event-29096813344
https://github.com/trivikr
trivikrhttps://github.com/trivikr
ShogunPandahttps://github.com/ShogunPanda
August 9, 2026 02:21https://github.com/nodejs/node/pull/64998#event-29172663436
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/c49d330f6931064dfd32f557d4eb4296a96946df..95c8bec912db6b68de6a26d226d6c52236cb483a
c49d330https://github.com/nodejs/node/commit/c49d330f6931064dfd32f557d4eb4296a96946df
95c8bechttps://github.com/nodejs/node/commit/95c8bec912db6b68de6a26d226d6c52236cb483a
Compare https://github.com/nodejs/node/compare/c49d330f6931064dfd32f557d4eb4296a96946df..95c8bec912db6b68de6a26d226d6c52236cb483a
August 9, 2026 23:21https://github.com/nodejs/node/pull/64998#event-29195019813
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 10, 2026https://github.com/nodejs/node/pull/64998#event-29246351265
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64998
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64998
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 11, 2026https://github.com/nodejs/node/pull/64998#issuecomment-5248974691
https://ci.nodejs.org/job/node-test-pull-request/75762/https://ci.nodejs.org/job/node-test-pull-request/75762/
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/trivikr
trivikrhttps://github.com/trivikr
mcollinahttps://github.com/mcollina
August 13, 2026 22:45https://github.com/nodejs/node/pull/64998#event-29428844660
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Aug 17, 2026 https://github.com/nodejs/node/pull/64998#pullrequestreview-4949369957
View reviewed changes https://github.com/nodejs/node/pull/64998/files/d95dba23d467a874c8e71078c9547151b2e52f5c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 17, 2026https://github.com/nodejs/node/pull/64998#event-29567541345
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Aug 17, 2026https://github.com/nodejs/node/pull/64998#event-29569779240
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 17, 2026https://github.com/nodejs/node/pull/64998#issuecomment-5317677041
https://github.com/nodejs/node/actions/runs/32045336475https://github.com/nodejs/node/actions/runs/32045336475
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Aug 17, 2026https://github.com/nodejs/node/pull/64998#event-29569937457
https://github.com/trivikr
ffi: remove dead null check in callback argumentshttps://github.com/nodejs/node/pull/64998/commits/d95dba23d467a874c8e71078c9547151b2e52f5c
d95dba2https://github.com/nodejs/node/pull/64998/commits/d95dba23d467a874c8e71078c9547151b2e52f5c
nodejs#64998https://github.com/nodejs/node/pull/64998
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/95c8bec912db6b68de6a26d226d6c52236cb483a..d95dba23d467a874c8e71078c9547151b2e52f5c
95c8bechttps://github.com/nodejs/node/commit/95c8bec912db6b68de6a26d226d6c52236cb483a
d95dba2https://github.com/nodejs/node/commit/d95dba23d467a874c8e71078c9547151b2e52f5c
Compare https://github.com/nodejs/node/compare/95c8bec912db6b68de6a26d226d6c52236cb483a..d95dba23d467a874c8e71078c9547151b2e52f5c
August 17, 2026 16:39https://github.com/nodejs/node/pull/64998#event-29570306826
https://github.com/trivikr
trivikrhttps://github.com/trivikr
d95dba2https://github.com/nodejs/node/commit/d95dba23d467a874c8e71078c9547151b2e52f5c
Aug 17, 2026https://github.com/nodejs/node/pull/64998#event-29570311421
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/trivikr
trivikrhttps://github.com/trivikr
August 17, 2026 16:40https://github.com/nodejs/node/pull/64998#event-29570315905
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 17, 2026https://github.com/nodejs/node/pull/64998#issuecomment-5317794091
d95dba2https://github.com/nodejs/node/commit/d95dba23d467a874c8e71078c9547151b2e52f5c
Please reload this pagehttps://github.com/nodejs/node/pull/64998
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64998#ref-commit-278027a
https://github.com/trivikr
https://github.com/aduh95
ffi: remove dead null check in callback argumentshttps://github.com/nodejs/node/commit/278027a5e4f00fd83f01065c4867d1c525f575d9
278027ahttps://github.com/nodejs/node/commit/278027a5e4f00fd83f01065c4867d1c525f575d9
#64998https://github.com/nodejs/node/pull/64998
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64998#ref-commit-0002f0a
https://github.com/trivikr
https://github.com/aduh95
ffi: remove dead null check in callback argumentshttps://github.com/nodejs/node/commit/0002f0a718de94258c5851b78930689394ff8bfe
0002f0ahttps://github.com/nodejs/node/commit/0002f0a718de94258c5851b78930689394ff8bfe
#64998https://github.com/nodejs/node/pull/64998
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/64998#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64998
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/64998/files/d95dba23d467a874c8e71078c9547151b2e52f5c
https://github.com/mcollina
mcollina https://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/64998
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/64998
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.