René's URL Explorer Experiment


Title: ffi: reuse the callable created per symbol by trivikr · Pull Request #64971 · nodejs/node · GitHub

Open Graph Title: ffi: reuse the callable created per symbol by trivikr · Pull Request #64971 · nodejs/node

X Title: ffi: reuse the callable created per symbol by trivikr · Pull Request #64971 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64970 CreateFunction() ran on every getFunction() call, every getFunctions() call, and every read of the functions accessor, each time emitting a trampoline, allocating an FFIFunctionInfo, ...

X Description: Fixes: #64970 CreateFunction() ran on every getFunction() call, every getFunctions() call, and every read of the functions accessor, each time emitting a trampoline, allocating an FFIFunctionInfo, ...

Opengraph URL: https://github.com/nodejs/node/pull/64971

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8da75c56-ca23-dda4-4dd3-7979c623e884
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCED2:1D8768:518BCE:6D553A:6AED19C0
html-safe-nonce1e602fd5db142b8c2f897a6b0d74b6847eaf8745e938afcbfdee0d9e41f97f04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQyOjFEODc2ODo1MThCQ0U6NkQ1NTNBOjZBRUQxOUMwIiwidmlzaXRvcl9pZCI6IjkwMjI5NjczMDAyMTQ2ODYwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac38133dd3b470fbb84e4cc714c0d21b899a8ca4e86f5866bb832f5e986a4f800d
hovercard-subject-tagpull_request:4190237441
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64971/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e060363e928438b19e82acdc4343344c3492ac4e6bc7691a6d2b06c4ca0b7852/nodejs/node/pull/64971
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e060363e928438b19e82acdc4343344c3492ac4e6bc7691a6d2b06c4ca0b7852/nodejs/node/pull/64971
og:image:altFixes: #64970 CreateFunction() ran on every getFunction() call, every getFunctions() call, and every read of the functions accessor, each time emitting a trampoline, allocating an FFIFunctionInfo, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64971#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64971
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64971
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64971
Reloadhttps://github.com/nodejs/node/pull/64971
Reloadhttps://github.com/nodejs/node/pull/64971
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-get-function-reuse-wrapperhttps://github.com/trivikr/node/tree/ffi-get-function-reuse-wrapper
Conversationhttps://github.com/nodejs/node/pull/64971
Commits1 (1)https://github.com/nodejs/node/pull/64971/commits
Checkshttps://github.com/nodejs/node/pull/64971/checks
Files changedhttps://github.com/nodejs/node/pull/64971/files
ffi: reuse the callable created per symbolhttps://github.com/nodejs/node/pull/64971#top
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-get-function-reuse-wrapperhttps://github.com/trivikr/node/tree/ffi-get-function-reuse-wrapper
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 2, 2026https://github.com/nodejs/node/pull/64971#issue-5044936991
#64970https://github.com/nodejs/node/issues/64970
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2026https://github.com/nodejs/node/pull/64971#issuecomment-5160808217
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 2, 2026 https://github.com/nodejs/node/pull/64971#ref-issue-5044927444
ffi: getFunction() and the functions accessor rebuild wrappers on every call #64970 https://github.com/nodejs/node/issues/64970
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 2, 2026https://github.com/nodejs/node/pull/64971#event-28860422519
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 2, 2026https://github.com/nodejs/node/pull/64971#event-28860867206
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 3, 2026https://github.com/nodejs/node/pull/64971#issuecomment-5161208376
Please reload this pagehttps://github.com/nodejs/node/pull/64971
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64971?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
51a55d4https://app.codecov.io/gh/nodejs/node/commit/51a55d4b38f98324bd552026ad4a73e9d7caacc7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
bf2f995https://app.codecov.io/gh/nodejs/node/commit/bf2f99566112d0e144b17fef30ad5a371e1d55ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64971?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
4 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/ffi.jshttps://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&filepath=lib%2Fffi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZmaS5qcw==
3 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64971?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_ffi.hhttps://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&filepath=src%2Fnode_ffi.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmg=
lib/ffi.jshttps://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&filepath=lib%2Fffi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZmaS5qcw==
src/node_ffi.cchttps://app.codecov.io/gh/nodejs/node/pull/64971?src=pr&el=tree&filepath=src%2Fnode_ffi.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmZpLmNj
37 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64971/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Aug 3, 2026 https://github.com/nodejs/node/pull/64971#pullrequestreview-4841447118
View reviewed changes https://github.com/nodejs/node/pull/64971/files/bf2f99566112d0e144b17fef30ad5a371e1d55ec
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 3, 2026https://github.com/nodejs/node/pull/64971#event-28872047576
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 3, 2026https://github.com/nodejs/node/pull/64971#event-28874625416
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64971
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2026https://github.com/nodejs/node/pull/64971#issuecomment-5167789395
https://ci.nodejs.org/job/node-test-pull-request/75433/https://ci.nodejs.org/job/node-test-pull-request/75433/
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/trivikr
trivikrhttps://github.com/trivikr
August 3, 2026 15:07https://github.com/nodejs/node/pull/64971#event-28896011678
https://github.com/trivikr
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64971
https://github.com/trivikr
trivikrhttps://github.com/trivikr
August 4, 2026 14:47https://github.com/nodejs/node/pull/64971#event-28956258972
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 9, 2026https://github.com/nodejs/node/pull/64971#event-29173295675
https://github.com/trivikr
ffi: reuse the callable created per symbolhttps://github.com/nodejs/node/pull/64971/commits/bf2f99566112d0e144b17fef30ad5a371e1d55ec
bf2f995https://github.com/nodejs/node/pull/64971/commits/bf2f99566112d0e144b17fef30ad5a371e1d55ec
nodejs#64971https://github.com/nodejs/node/pull/64971
nodejs#64970https://github.com/nodejs/node/issues/64970
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/16a5d6e27c6a02f5ef63cf5fa4d5fbb913ac2d21..bf2f99566112d0e144b17fef30ad5a371e1d55ec
16a5d6ehttps://github.com/nodejs/node/commit/16a5d6e27c6a02f5ef63cf5fa4d5fbb913ac2d21
bf2f995https://github.com/nodejs/node/commit/bf2f99566112d0e144b17fef30ad5a371e1d55ec
Compare https://github.com/nodejs/node/compare/16a5d6e27c6a02f5ef63cf5fa4d5fbb913ac2d21..bf2f99566112d0e144b17fef30ad5a371e1d55ec
August 9, 2026 23:19https://github.com/nodejs/node/pull/64971#event-29194985130
https://github.com/trivikr
trivikrhttps://github.com/trivikr
bf2f995https://github.com/nodejs/node/commit/bf2f99566112d0e144b17fef30ad5a371e1d55ec
Aug 9, 2026https://github.com/nodejs/node/pull/64971#event-29194987518
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 9, 2026https://github.com/nodejs/node/pull/64971#issuecomment-5234367773
bf2f995https://github.com/nodejs/node/commit/bf2f99566112d0e144b17fef30ad5a371e1d55ec
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/trivikr
trivikrhttps://github.com/trivikr
August 9, 2026 23:19https://github.com/nodejs/node/pull/64971#event-29194995451
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/64971#ref-commit-93ec6e6
https://github.com/trivikr
https://github.com/aduh95
ffi: reuse the callable created per symbolhttps://github.com/nodejs/node/commit/93ec6e65a851f1990c166836182ebee054b3dff7
93ec6e6https://github.com/nodejs/node/commit/93ec6e65a851f1990c166836182ebee054b3dff7
#64971https://github.com/nodejs/node/pull/64971
#64970https://github.com/nodejs/node/issues/64970
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64971#ref-commit-3e6688c
https://github.com/trivikr
https://github.com/aduh95
ffi: reuse the callable created per symbolhttps://github.com/nodejs/node/commit/3e6688c5e34dc377d90e701925e061a9ef906f4e
3e6688chttps://github.com/nodejs/node/commit/3e6688c5e34dc377d90e701925e061a9ef906f4e
#64971https://github.com/nodejs/node/pull/64971
#64970https://github.com/nodejs/node/issues/64970
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/64971#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
https://github.com/HoonDongKang
HoonDongKanghttps://github.com/HoonDongKang
Oct 2, 2026 https://github.com/nodejs/node/pull/64971#ref-pullrequest-5672785531
ffi: add getFunction cache-miss benchmark #66456 https://github.com/nodejs/node/pull/66456
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 20, 2026 https://github.com/nodejs/node/pull/64971#ref-commit-4c14b9f
https://github.com/HoonDongKang
ffi: add getFunction cache-miss benchmarkhttps://github.com/nodejs/node/commit/4c14b9f58a01dec9ae9586a03a3615ea73d02d32
4c14b9fhttps://github.com/nodejs/node/commit/4c14b9f58a01dec9ae9586a03a3615ea73d02d32
#66456https://github.com/nodejs/node/pull/66456
#64969https://github.com/nodejs/node/pull/64969
#64971https://github.com/nodejs/node/pull/64971
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64971
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/64971/files/bf2f99566112d0e144b17fef30ad5a371e1d55ec
Please reload this pagehttps://github.com/nodejs/node/pull/64971
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: getFunction() and the functions accessor rebuild wrappers on every call https://github.com/nodejs/node/issues/64970
Please reload this pagehttps://github.com/nodejs/node/pull/64971
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/ShogunPanda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.