René's URL Explorer Experiment


Title: permission: reuse cached env strings by agape1225 · Pull Request #64912 · nodejs/node · GitHub

Open Graph Title: permission: reuse cached env strings by agape1225 · Pull Request #64912 · nodejs/node

X Title: permission: reuse cached env strings by agape1225 · Pull Request #64912 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in src/permission/permission.cc with the Environment-cached permission_string()/resource_string() accessors already used el...

X Description: This PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in src/permission/permission.cc with the Environment-cached permission_string()/resource_string() accessors already...

Opengraph URL: https://github.com/nodejs/node/pull/64912

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6730f758-bdeb-5369-e62d-aa0edcb9bb34
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD880:39024:13A21C:19A999:6AED144F
html-safe-noncef644f35d7ee27264137d6facebf424bed063b50ba9a405747e8b670521490f85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODgwOjM5MDI0OjEzQTIxQzoxOUE5OTk6NkFFRDE0NEYiLCJ2aXNpdG9yX2lkIjoiNDcwNzQ5MzExMjY2MzgzOTgyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac65374acfe29dd47e93f08e489dbd71c2a40ba82ee8d3b260800696b84c839ca1
hovercard-subject-tagpull_request:4183991762
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64912/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a96020ba33309e93d6829b57e365811123aaab0ca282e45252751b4f998a0dd/nodejs/node/pull/64912
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a96020ba33309e93d6829b57e365811123aaab0ca282e45252751b4f998a0dd/nodejs/node/pull/64912
og:image:altThis PR replaces FIXED_ONE_BYTE_STRING(isolate, "...") literals in src/permission/permission.cc with the Environment-cached permission_string()/resource_string() accessors already used el...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameagape1225
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64912#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64912
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64912
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64912
Reloadhttps://github.com/nodejs/node/pull/64912
Reloadhttps://github.com/nodejs/node/pull/64912
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
agape1225https://github.com/agape1225
nodejs:mainhttps://github.com/nodejs/node/tree/main
agape1225:permission-use-cached-stringshttps://github.com/agape1225/node/tree/permission-use-cached-strings
Conversationhttps://github.com/nodejs/node/pull/64912
Commits1 (1)https://github.com/nodejs/node/pull/64912/commits
Checkshttps://github.com/nodejs/node/pull/64912/checks
Files changedhttps://github.com/nodejs/node/pull/64912/files
permission: reuse cached env stringshttps://github.com/nodejs/node/pull/64912#top
agape1225https://github.com/agape1225
nodejs:mainhttps://github.com/nodejs/node/tree/main
agape1225:permission-use-cached-stringshttps://github.com/agape1225/node/tree/permission-use-cached-strings
https://github.com/agape1225
agape1225https://github.com/agape1225
Aug 1, 2026https://github.com/nodejs/node/pull/64912#issue-5037173120
#59891https://github.com/nodejs/node/pull/59891
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/agape1225
permission: reuse cached env stringshttps://github.com/nodejs/node/pull/64912/commits/615612e04c5427329db211028a158535a9e4db4a
615612ehttps://github.com/nodejs/node/pull/64912/commits/615612e04c5427329db211028a158535a9e4db4a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 1, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5151588177
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Aug 1, 2026https://github.com/nodejs/node/pull/64912#event-28818764448
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 1, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5151955667
Please reload this pagehttps://github.com/nodejs/node/pull/64912
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64912?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b9dacd4https://app.codecov.io/gh/nodejs/node/commit/b9dacd417fa4feae384892d8462d6740ec0e2c88?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
615612ehttps://app.codecov.io/gh/nodejs/node/commit/615612e04c5427329db211028a158535a9e4db4a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/permission/permission.cchttps://app.codecov.io/gh/nodejs/node/pull/64912?src=pr&el=tree&filepath=src%2Fpermission%2Fpermission.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3Blcm1pc3Npb24vcGVybWlzc2lvbi5jYw==
38 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64912/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 2, 2026 https://github.com/nodejs/node/pull/64912#pullrequestreview-4838784169
View reviewed changes https://github.com/nodejs/node/pull/64912/files/615612e04c5427329db211028a158535a9e4db4a
leah-1eehttps://github.com/leah-1ee
Aug 5, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-90c4c8a
https://github.com/leah-1ee
src: reuse cached env strings in remaining fileshttps://github.com/leah-1ee/node/commit/90c4c8a86ce3aed8a9a3deec3059d2ff5af0f10f
90c4c8ahttps://github.com/leah-1ee/node/commit/90c4c8a86ce3aed8a9a3deec3059d2ff5af0f10f
nodejs#59891https://github.com/nodejs/node/pull/59891
nodejs#64760https://github.com/nodejs/node/pull/64760
nodejs#59891https://github.com/nodejs/node/pull/59891
nodejs#64760https://github.com/nodejs/node/pull/64760
nodejs#64912https://github.com/nodejs/node/pull/64912
https://github.com/leah-1ee
leah-1eehttps://github.com/leah-1ee
Aug 5, 2026 https://github.com/nodejs/node/pull/64912#ref-pullrequest-5069010758
src: reuse cached env strings in remaining files #65039 https://github.com/nodejs/node/pull/65039
leah-1eehttps://github.com/leah-1ee
Aug 5, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-ae5c463
https://github.com/leah-1ee
src: reuse cached env strings in remaining fileshttps://github.com/leah-1ee/node/commit/ae5c463241879ca2d3a0efd0f32ff9bd42f3f79e
ae5c463https://github.com/leah-1ee/node/commit/ae5c463241879ca2d3a0efd0f32ff9bd42f3f79e
nodejs#59891https://github.com/nodejs/node/pull/59891
nodejs#64760https://github.com/nodejs/node/pull/64760
nodejs#59891https://github.com/nodejs/node/pull/59891
nodejs#64760https://github.com/nodejs/node/pull/64760
nodejs#64912https://github.com/nodejs/node/pull/64912
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 6, 2026https://github.com/nodejs/node/pull/64912#event-29077506790
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
Aug 6, 2026 https://github.com/nodejs/node/pull/64912#pullrequestreview-4876387866
View reviewed changes https://github.com/nodejs/node/pull/64912/files/615612e04c5427329db211028a158535a9e4db4a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 6, 2026https://github.com/nodejs/node/pull/64912#event-29087539513
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5209186298
https://ci.nodejs.org/job/node-test-pull-request/75589/https://ci.nodejs.org/job/node-test-pull-request/75589/
Please reload this pagehttps://github.com/nodejs/node/pull/64912
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-721aad4
https://github.com/leah-1ee
src: reuse cached env strings in remaining fileshttps://github.com/nodejs/node/commit/721aad42f538cf07d14f879050249a36bf323eb2
721aad4https://github.com/nodejs/node/commit/721aad42f538cf07d14f879050249a36bf323eb2
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
#65039https://github.com/nodejs/node/pull/65039
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5231396488
https://ci.nodejs.org/job/node-test-pull-request/75689/https://ci.nodejs.org/job/node-test-pull-request/75689/
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/daeyeon
daeyeonhttps://github.com/daeyeon
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 10, 2026https://github.com/nodejs/node/pull/64912#event-29198048533
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 10, 2026https://github.com/nodejs/node/pull/64912#event-29230321325
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 10, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5242127081
https://github.com/nodejs/node/actions/runs/31401397043
https://github.com/nodejs/node/actions/runs/31401397043https://github.com/nodejs/node/actions/runs/31401397043
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 10, 2026https://github.com/nodejs/node/pull/64912#issuecomment-5242466757
41afbd3https://github.com/nodejs/node/commit/41afbd30cfe551a87d24d81f0920324d2136ead1
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 10, 2026https://github.com/nodejs/node/pull/64912#event-29231905628
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-b761755
https://github.com/leah-1ee
https://github.com/aduh95
src: reuse cached env strings in remaining fileshttps://github.com/nodejs/node/commit/b761755f61c8af9b40906a309abfac1486c21643
b761755https://github.com/nodejs/node/commit/b761755f61c8af9b40906a309abfac1486c21643
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
#65039https://github.com/nodejs/node/pull/65039
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-262d88e
https://github.com/leah-1ee
https://github.com/aduh95
src: reuse cached env strings in remaining fileshttps://github.com/nodejs/node/commit/262d88e6c2fc2670682e92b31bb51e545306c1bb
262d88ehttps://github.com/nodejs/node/commit/262d88e6c2fc2670682e92b31bb51e545306c1bb
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
#65039https://github.com/nodejs/node/pull/65039
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/64912#ref-commit-d7463b9
https://github.com/leah-1ee
https://github.com/aduh95
src: reuse cached env strings in remaining fileshttps://github.com/nodejs/node/commit/d7463b9dbcfb94ca18f1dd15165c1ed41a346dbd
d7463b9https://github.com/nodejs/node/commit/d7463b9dbcfb94ca18f1dd15165c1ed41a346dbd
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
#65039https://github.com/nodejs/node/pull/65039
#59891https://github.com/nodejs/node/pull/59891
#64760https://github.com/nodejs/node/pull/64760
#64912https://github.com/nodejs/node/pull/64912
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64912
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64912/files/615612e04c5427329db211028a158535a9e4db4a
https://github.com/daeyeon
daeyeon https://github.com/daeyeon
https://github.com/nodejs/node/pull/64912/files/615612e04c5427329db211028a158535a9e4db4a
Please reload this pagehttps://github.com/nodejs/node/pull/64912
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/64912
https://github.com/agape1225
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com/jasnell
https://github.com/daeyeon
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.