René's URL Explorer Experiment


Title: sea: handle NUL bytes in asset keys by Archkon · Pull Request #64773 · nodejs/node · GitHub

Open Graph Title: sea: handle NUL bytes in asset keys by Archkon · Pull Request #64773 · nodejs/node

X Title: sea: handle NUL bytes in asset keys by Archkon · Pull Request #64773 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Construct the asset lookup string_view with the explicit Utf8Value length so embedded NUL bytes do not truncate keys.

X Description: Construct the asset lookup string_view with the explicit Utf8Value length so embedded NUL bytes do not truncate keys.

Opengraph URL: https://github.com/nodejs/node/pull/64773

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:caf4bbcf-ddc0-ad31-7bff-dbe6c1e4d215
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB44E:DF107:24BC4E:322CA0:6AED0E24
html-safe-noncef38ce16cd89b3ec4e0a474c4d0e68b946610840b3a963f2da2a944c987e1283a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDRFOkRGMTA3OjI0QkM0RTozMjJDQTA6NkFFRDBFMjQiLCJ2aXNpdG9yX2lkIjoiMTc3Nzg5ODI4NjU4OTIxODM0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a5982deb8ab1065586c86026dec3091ba29f89c5a5bd779e30d47bfdb07d964
hovercard-subject-tagpull_request:4139983057
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64773/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/538293e3734619725eee4464e160f9380719ec17ebf9dc2092d068a682807035/nodejs/node/pull/64773
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/538293e3734619725eee4464e160f9380719ec17ebf9dc2092d068a682807035/nodejs/node/pull/64773
og:image:altConstruct the asset lookup string_view with the explicit Utf8Value length so embedded NUL bytes do not truncate keys.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameArchkon
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64773#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64773
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64773
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64773
Reloadhttps://github.com/nodejs/node/pull/64773
Reloadhttps://github.com/nodejs/node/pull/64773
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Archkon:sea3https://github.com/Archkon/node/tree/sea3
Conversationhttps://github.com/nodejs/node/pull/64773
Commits1 (1)https://github.com/nodejs/node/pull/64773/commits
Checkshttps://github.com/nodejs/node/pull/64773/checks
Files changedhttps://github.com/nodejs/node/pull/64773/files
sea: handle NUL bytes in asset keyshttps://github.com/nodejs/node/pull/64773#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
Archkon:sea3https://github.com/Archkon/node/tree/sea3
https://github.com/Archkon
Archkonhttps://github.com/Archkon
Jul 27, 2026https://github.com/nodejs/node/pull/64773#issue-4985154450
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 27, 2026https://github.com/nodejs/node/pull/64773#issuecomment-5088145909
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
single-executable https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asingle-executable
Jul 27, 2026https://github.com/nodejs/node/pull/64773#event-28521433356
https://github.com/Archkon
sea: handle NUL bytes in asset keyshttps://github.com/nodejs/node/pull/64773/commits/f73674ee79ebdb564e692b46121ff335005c5247
f73674ehttps://github.com/nodejs/node/pull/64773/commits/f73674ee79ebdb564e692b46121ff335005c5247
https://github.com/Archkon
Archkonhttps://github.com/Archkon
force-pushedhttps://github.com/nodejs/node/compare/79d8ebc55532f5774facc864a5b2fd3eb6ce1c39..f73674ee79ebdb564e692b46121ff335005c5247
79d8ebchttps://github.com/nodejs/node/commit/79d8ebc55532f5774facc864a5b2fd3eb6ce1c39
f73674ehttps://github.com/nodejs/node/commit/f73674ee79ebdb564e692b46121ff335005c5247
Compare https://github.com/nodejs/node/compare/79d8ebc55532f5774facc864a5b2fd3eb6ce1c39..f73674ee79ebdb564e692b46121ff335005c5247
July 27, 2026 06:53https://github.com/nodejs/node/pull/64773#event-28521717282
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 27, 2026https://github.com/nodejs/node/pull/64773#issuecomment-5089185933
Please reload this pagehttps://github.com/nodejs/node/pull/64773
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64773?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
54a5095https://app.codecov.io/gh/nodejs/node/commit/54a50957643f02b5918d7d26afbb855b5ee59a68?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
f73674ehttps://app.codecov.io/gh/nodejs/node/commit/f73674ee79ebdb564e692b46121ff335005c5247?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64773?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sea.cchttps://app.codecov.io/gh/nodejs/node/pull/64773?src=pr&el=tree&filepath=src%2Fnode_sea.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc2VhLmNj
24 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Jul 27, 2026 https://github.com/nodejs/node/pull/64773#pullrequestreview-4788822053
View reviewed changes https://github.com/nodejs/node/pull/64773/files/f73674ee79ebdb564e692b46121ff335005c5247
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64773
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 5, 2026https://github.com/nodejs/node/pull/64773#event-28984067233
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Aug 5, 2026 https://github.com/nodejs/node/pull/64773#pullrequestreview-4860423276
View reviewed changes https://github.com/nodejs/node/pull/64773/files/f73674ee79ebdb564e692b46121ff335005c5247
src/node_sea.cchttps://github.com/nodejs/node/pull/64773/files/f73674ee79ebdb564e692b46121ff335005c5247#diff-5afaf7eae42f44a543b411784037654c21ba0dc69870c7a5351bc219f0bfce64
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 5, 2026https://github.com/nodejs/node/pull/64773#event-28984613477
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 5, 2026https://github.com/nodejs/node/pull/64773#issuecomment-5186812498
https://ci.nodejs.org/job/node-test-pull-request/75499/https://ci.nodejs.org/job/node-test-pull-request/75499/
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 8, 2026https://github.com/nodejs/node/pull/64773#issuecomment-5226208970
https://ci.nodejs.org/job/node-test-pull-request/75645/https://ci.nodejs.org/job/node-test-pull-request/75645/
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 9, 2026https://github.com/nodejs/node/pull/64773#event-29190147921
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
cf44862https://github.com/nodejs/node/commit/cf44862eb3db8d35074e6275fa3880e6f3ec9dd6
Aug 9, 2026https://github.com/nodejs/node/pull/64773#event-29190351282
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 9, 2026https://github.com/nodejs/node/pull/64773#issuecomment-5233379901
cf44862https://github.com/nodejs/node/commit/cf44862eb3db8d35074e6275fa3880e6f3ec9dd6
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 9, 2026https://github.com/nodejs/node/pull/64773#event-29190351996
https://github.com/Archkon
Archkonhttps://github.com/Archkon
August 9, 2026 19:21https://github.com/nodejs/node/pull/64773#event-29190547877
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/64773#ref-commit-1595703
https://github.com/Archkon
https://github.com/aduh95
sea: handle NUL bytes in asset keyshttps://github.com/nodejs/node/commit/1595703aee5c21e95351bc47f43befe02b0f3f2d
1595703https://github.com/nodejs/node/commit/1595703aee5c21e95351bc47f43befe02b0f3f2d
#64773https://github.com/nodejs/node/pull/64773
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64773#ref-commit-3126ce5
https://github.com/Archkon
https://github.com/aduh95
sea: handle NUL bytes in asset keyshttps://github.com/nodejs/node/commit/3126ce57792b8a0df5e60781d2743071520c04d4
3126ce5https://github.com/nodejs/node/commit/3126ce57792b8a0df5e60781d2743071520c04d4
#64773https://github.com/nodejs/node/pull/64773
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/64773#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/64773#ref-commit-ec5e2d6
https://github.com/Archkon
https://github.com/aduh95
sea: handle NUL bytes in asset keyshttps://github.com/nodejs/node/commit/ec5e2d6856efa005c26ac18956eebb28c5697961
ec5e2d6https://github.com/nodejs/node/commit/ec5e2d6856efa005c26ac18956eebb28c5697961
#64773https://github.com/nodejs/node/pull/64773
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/64773#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64773
https://github.com/avivkeller
avivkeller https://github.com/avivkeller
https://github.com/nodejs/node/pull/64773/files/f73674ee79ebdb564e692b46121ff335005c5247
Please reload this pagehttps://github.com/nodejs/node/pull/64773
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
single-executable https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asingle-executable
Please reload this pagehttps://github.com/nodejs/node/pull/64773
https://github.com/Archkon
https://github.com/nodejs-github-bot
https://github.com/avivkeller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.