René's URL Explorer Experiment


Title: stream: preserve falsy cancellation reasons by trivikr · Pull Request #64705 · nodejs/node · GitHub

Open Graph Title: stream: preserve falsy cancellation reasons by trivikr · Pull Request #64705 · nodejs/node

X Title: stream: preserve falsy cancellation reasons by trivikr · Pull Request #64705 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64704 Previously, falsy reasons such as 0, '', false, and null were stored but later treated as if no error existed. Consumers that had not started waiting would therefore observe c...

X Description: Fixes: #64704 Previously, falsy reasons such as 0, '', false, and null were stored but later treated as if no error existed. Consumers that had not started waiting would therefore o...

Opengraph URL: https://github.com/nodejs/node/pull/64705

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2c35691f-85b4-546e-451d-7f4eef94100d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD11A:B3C94:14DE7:1B63A:6AED0EF9
html-safe-nonce12bbcc7a8ead7aee80bcd54fcd5179a96ac1e0f43f45d263af2c462f56f9647d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTFBOkIzQzk0OjE0REU3OjFCNjNBOjZBRUQwRUY5IiwidmlzaXRvcl9pZCI6Ijg0OTAyNzI4MTExNTI5MDM5MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac957cb34073b7bd4fd920dd490a9fe31c5effddf81b1619ad9c71d70416382397
hovercard-subject-tagpull_request:4121910014
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64705/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/70f8eeb3ac237e41dc604b97d4b8fb32d547069a2a349fc57717c4d9092bec70/nodejs/node/pull/64705
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/70f8eeb3ac237e41dc604b97d4b8fb32d547069a2a349fc57717c4d9092bec70/nodejs/node/pull/64705
og:image:altFixes: #64704 Previously, falsy reasons such as 0, '', false, and null were stored but later treated as if no error existed. Consumers that had not started waiting would therefore observe c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64705#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64705
Reloadhttps://github.com/nodejs/node/pull/64705
Reloadhttps://github.com/nodejs/node/pull/64705
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-broadcast-share-falsy-cancellationhttps://github.com/trivikr/node/tree/stream-iter-broadcast-share-falsy-cancellation
Conversationhttps://github.com/nodejs/node/pull/64705
Commits1 (1)https://github.com/nodejs/node/pull/64705/commits
Checkshttps://github.com/nodejs/node/pull/64705/checks
Files changedhttps://github.com/nodejs/node/pull/64705/files
stream: preserve falsy cancellation reasonshttps://github.com/nodejs/node/pull/64705#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-broadcast-share-falsy-cancellationhttps://github.com/trivikr/node/tree/stream-iter-broadcast-share-falsy-cancellation
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 24, 2026https://github.com/nodejs/node/pull/64705#issue-4965190768
#64704https://github.com/nodejs/node/issues/64704
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 24, 2026https://github.com/nodejs/node/pull/64705#issuecomment-5066155821
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 24, 2026https://github.com/nodejs/node/pull/64705#event-28417475001
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 24, 2026https://github.com/nodejs/node/pull/64705#event-28417775760
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 24, 2026https://github.com/nodejs/node/pull/64705#issuecomment-5066663371
Please reload this pagehttps://github.com/nodejs/node/pull/64705
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64705?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
bfa3e98https://app.codecov.io/gh/nodejs/node/commit/bfa3e982ec3ed8d30b525707948bbf9045967195?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0f06c0fhttps://app.codecov.io/gh/nodejs/node/commit/0f06c0f488b858984d984a36acb62fe8d2520fa4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64705?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64705?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/broadcast.jshttps://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fbroadcast.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9icm9hZGNhc3QuanM=
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/64705?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
24 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64705/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 31, 2026 https://github.com/nodejs/node/pull/64705#ref-issue-4965185932
stream/iter: falsy cancellation reasons become clean EOF in broadcast and share #64704 https://github.com/nodejs/node/issues/64704
https://github.com/trivikr
trivikrhttps://github.com/trivikr
jasnellhttps://github.com/jasnell
August 1, 2026 03:04https://github.com/nodejs/node/pull/64705#event-28805926497
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/ad6e53b94991f208fd4342277a5f31a3b37103f8..bf47906157b93875df8c5672fb8be822adf397b0
ad6e53bhttps://github.com/nodejs/node/commit/ad6e53b94991f208fd4342277a5f31a3b37103f8
bf47906https://github.com/nodejs/node/commit/bf47906157b93875df8c5672fb8be822adf397b0
Compare https://github.com/nodejs/node/compare/ad6e53b94991f208fd4342277a5f31a3b37103f8..bf47906157b93875df8c5672fb8be822adf397b0
August 4, 2026 05:02https://github.com/nodejs/node/pull/64705#event-28927995566
https://github.com/trivikr
stream: preserve falsy cancellation reasonshttps://github.com/nodejs/node/pull/64705/commits/0f06c0f488b858984d984a36acb62fe8d2520fa4
0f06c0fhttps://github.com/nodejs/node/pull/64705/commits/0f06c0f488b858984d984a36acb62fe8d2520fa4
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/bf47906157b93875df8c5672fb8be822adf397b0..0f06c0f488b858984d984a36acb62fe8d2520fa4
bf47906https://github.com/nodejs/node/commit/bf47906157b93875df8c5672fb8be822adf397b0
0f06c0fhttps://github.com/nodejs/node/commit/0f06c0f488b858984d984a36acb62fe8d2520fa4
Compare https://github.com/nodejs/node/compare/bf47906157b93875df8c5672fb8be822adf397b0..0f06c0f488b858984d984a36acb62fe8d2520fa4
August 12, 2026 15:48https://github.com/nodejs/node/pull/64705#event-29350199619
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 14, 2026 https://github.com/nodejs/node/pull/64705#pullrequestreview-4933335163
View reviewed changes https://github.com/nodejs/node/pull/64705/files/0f06c0f488b858984d984a36acb62fe8d2520fa4
https://github.com/jasnell
jasnellhttps://github.com/jasnell
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 14, 2026https://github.com/nodejs/node/pull/64705#event-29435704369
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2026https://github.com/nodejs/node/pull/64705#issuecomment-5295986172
https://ci.nodejs.org/job/node-test-pull-request/75846/https://ci.nodejs.org/job/node-test-pull-request/75846/
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 14, 2026https://github.com/nodejs/node/pull/64705#event-29479526596
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
bc813a7https://github.com/nodejs/node/commit/bc813a7a6dcf9d8c7320f5dffa6e8089fb9ccf68
Aug 14, 2026https://github.com/nodejs/node/pull/64705#event-29480296374
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2026https://github.com/nodejs/node/pull/64705#issuecomment-5298044873
bc813a7https://github.com/nodejs/node/commit/bc813a7a6dcf9d8c7320f5dffa6e8089fb9ccf68
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 14, 2026https://github.com/nodejs/node/pull/64705#event-29480298549
https://github.com/trivikr
trivikrhttps://github.com/trivikr
August 16, 2026 16:01https://github.com/nodejs/node/pull/64705#event-29526109846
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64705#ref-commit-c7f9ac9
https://github.com/trivikr
https://github.com/aduh95
stream: preserve falsy cancellation reasonshttps://github.com/nodejs/node/commit/c7f9ac9960106e9ddd5ac6bb11311d2d59954ea2
c7f9ac9https://github.com/nodejs/node/commit/c7f9ac9960106e9ddd5ac6bb11311d2d59954ea2
#64705https://github.com/nodejs/node/pull/64705
#64704https://github.com/nodejs/node/issues/64704
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/64705#ref-commit-0876a29
https://github.com/trivikr
https://github.com/aduh95
stream: preserve falsy cancellation reasonshttps://github.com/nodejs/node/commit/0876a29bb60b1cfe0c826b1fdfbf81fcf1122c05
0876a29https://github.com/nodejs/node/commit/0876a29bb60b1cfe0c826b1fdfbf81fcf1122c05
#64705https://github.com/nodejs/node/pull/64705
#64704https://github.com/nodejs/node/issues/64704
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/64705#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/64705#ref-commit-d631e91
https://github.com/trivikr
https://github.com/aduh95
stream: preserve falsy cancellation reasonshttps://github.com/nodejs/node/commit/d631e910db8756cd92cc2809d70d65e5093a55c6
d631e91https://github.com/nodejs/node/commit/d631e910db8756cd92cc2809d70d65e5093a55c6
#64705https://github.com/nodejs/node/pull/64705
#64704https://github.com/nodejs/node/issues/64704
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/64705#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64705
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64705/files/0f06c0f488b858984d984a36acb62fe8d2520fa4
Please reload this pagehttps://github.com/nodejs/node/pull/64705
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: falsy cancellation reasons become clean EOF in broadcast and share https://github.com/nodejs/node/issues/64704
Please reload this pagehttps://github.com/nodejs/node/pull/64705
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.