René's URL Explorer Experiment


Title: ffi: evaluate function signatures once by trivikr · Pull Request #64559 · nodejs/node · GitHub

Open Graph Title: ffi: evaluate function signatures once by trivikr · Pull Request #64559 · nodejs/node

X Title: ffi: evaluate function signatures once by trivikr · Pull Request #64559 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64558 Function signatures passed to DynamicLibrary.getFunction() and DynamicLibrary.getFunctions() were evaluated twice. The native implementation parsed the signature first, after which th...

X Description: Fixes: #64558 Function signatures passed to DynamicLibrary.getFunction() and DynamicLibrary.getFunctions() were evaluated twice. The native implementation parsed the signature first, after which th...

Opengraph URL: https://github.com/nodejs/node/pull/64559

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b8ff1b58-502c-d5f1-79f1-0043186197eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C6E:1A0B50:416355:5BB393:6A6308DC
html-safe-nonce0ac9666127d01fce9bdbb4ec8e9604152a8d89a9b89291f6f90344cb893cde5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzZFOjFBMEI1MDo0MTYzNTU6NUJCMzkzOjZBNjMwOERDIiwidmlzaXRvcl9pZCI6IjQ3Njg2NzM0OTU4NTcxNzA2NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacef740e5d2fd885ca4cbb6a685346b670f28e8ae26b1b778c19b5dfea50e182a7
hovercard-subject-tagpull_request:4077889290
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64559/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cef3450abcff3d3ad19dc10f3ff4a395d42ec4dd62bd27edb877f67ce78476bb/nodejs/node/pull/64559
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cef3450abcff3d3ad19dc10f3ff4a395d42ec4dd62bd27edb877f67ce78476bb/nodejs/node/pull/64559
og:image:altFixes: #64558 Function signatures passed to DynamicLibrary.getFunction() and DynamicLibrary.getFunctions() were evaluated twice. The native implementation parsed the signature first, after which th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Noneb48e7bf0b1945d51f303503b057abf666ce74c3efbe107b413db2bb921c3f012
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9370f37042c29822d6ba7e3f670f0036a0155b21
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64559#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64559
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64559
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64559
Reloadhttps://github.com/nodejs/node/pull/64559
Reloadhttps://github.com/nodejs/node/pull/64559
Please reload this pagehttps://github.com/nodejs/node/pull/64559
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64559
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-signature-evaluationhttps://github.com/trivikr/node/tree/ffi-signature-evaluation
Conversationhttps://github.com/nodejs/node/pull/64559
Commits1 (1)https://github.com/nodejs/node/pull/64559/commits
Checkshttps://github.com/nodejs/node/pull/64559/checks
Files changedhttps://github.com/nodejs/node/pull/64559/files
ffi: evaluate function signatures oncehttps://github.com/nodejs/node/pull/64559#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:ffi-signature-evaluationhttps://github.com/trivikr/node/tree/ffi-signature-evaluation
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 17, 2026https://github.com/nodejs/node/pull/64559#issue-4912986217
#64558https://github.com/nodejs/node/issues/64558
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/trivikr
ffi: evaluate function signatures oncehttps://github.com/nodejs/node/pull/64559/commits/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
5fc8a83https://github.com/nodejs/node/pull/64559/commits/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2026https://github.com/nodejs/node/pull/64559#issuecomment-5005212709
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 17, 2026https://github.com/nodejs/node/pull/64559#event-28131070091
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 17, 2026https://github.com/nodejs/node/pull/64559#event-28131089470
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 17, 2026https://github.com/nodejs/node/pull/64559#issuecomment-5005965596
Please reload this pagehttps://github.com/nodejs/node/pull/64559
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64559?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
608112ahttps://app.codecov.io/gh/nodejs/node/commit/608112affae2cf44d2f8a0a6bfe7967193b459c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
5fc8a83https://app.codecov.io/gh/nodejs/node/commit/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64559?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/ffi.jshttps://app.codecov.io/gh/nodejs/node/pull/64559?src=pr&el=tree&filepath=lib%2Fffi.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZmaS5qcw==
48 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64559/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 17, 2026 https://github.com/nodejs/node/pull/64559#pullrequestreview-4726174534
View reviewed changes https://github.com/nodejs/node/pull/64559/files/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/64559#pullrequestreview-4726174534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 17, 2026https://github.com/nodejs/node/pull/64559#event-28141964082
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 17, 2026https://github.com/nodejs/node/pull/64559#event-28142048213
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2026https://github.com/nodejs/node/pull/64559#issuecomment-5007580835
https://ci.nodejs.org/job/node-test-pull-request/74875/https://ci.nodejs.org/job/node-test-pull-request/74875/
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 17, 2026https://github.com/nodejs/node/pull/64559#event-28145213817
https://github.com/ShogunPanda
ShogunPandahttps://github.com/ShogunPanda
Jul 20, 2026 https://github.com/nodejs/node/pull/64559#pullrequestreview-4732241456
View reviewed changes https://github.com/nodejs/node/pull/64559/files/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 20, 2026https://github.com/nodejs/node/pull/64559#event-28195114804
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 20, 2026https://github.com/nodejs/node/pull/64559#event-28195598958
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
00917bahttps://github.com/nodejs/node/commit/00917ba54c26ce02cb5bf869fd1d7affd8c19a54
Jul 20, 2026https://github.com/nodejs/node/pull/64559#event-28195652268
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2026https://github.com/nodejs/node/pull/64559#issuecomment-5019057331
00917bahttps://github.com/nodejs/node/commit/00917ba54c26ce02cb5bf869fd1d7affd8c19a54
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 20, 2026 https://github.com/nodejs/node/pull/64559#ref-issue-4926390895
[Vulnerability] nodejs/node: Type Confusion / TOCTOU (Time-of-check-to-time-of-use) spaceraccoon/vulnerability-spoiler-alert#337 https://github.com/spaceraccoon/vulnerability-spoiler-alert/issues/337
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64559#ref-commit-1591ed0
https://github.com/trivikr
https://github.com/aduh95
ffi: evaluate function signatures oncehttps://github.com/nodejs/node/commit/1591ed0cccaf606f4702d4d4f02af9005b0c1c46
1591ed0https://github.com/nodejs/node/commit/1591ed0cccaf606f4702d4d4f02af9005b0c1c46
#64559https://github.com/nodejs/node/pull/64559
#64558https://github.com/nodejs/node/issues/64558
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64559#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64559#ref-commit-91d90e9
https://github.com/trivikr
https://github.com/aduh95
ffi: evaluate function signatures oncehttps://github.com/nodejs/node/commit/91d90e9cd0dbb953b27d9b887b1a1fd01dabcea5
91d90e9https://github.com/nodejs/node/commit/91d90e9cd0dbb953b27d9b887b1a1fd01dabcea5
#64559https://github.com/nodejs/node/pull/64559
#64558https://github.com/nodejs/node/issues/64558
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64559#ref-commit-a5d676d
https://github.com/trivikr
https://github.com/aduh95
ffi: evaluate function signatures oncehttps://github.com/nodejs/node/commit/a5d676d34c2e8b5f65cb665da3dca850cd8325ac
a5d676dhttps://github.com/nodejs/node/commit/a5d676d34c2e8b5f65cb665da3dca850cd8325ac
#64559https://github.com/nodejs/node/pull/64559
#64558https://github.com/nodejs/node/issues/64558
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64559
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/64559/files/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
https://github.com/ShogunPanda
ShogunPanda https://github.com/ShogunPanda
https://github.com/nodejs/node/pull/64559/files/5fc8a83a7aec0fc2ee5bdb7a8db1177b6ea2eb3c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
ffi https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Affi
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
ffi: getFunction() evaluates signature getters twice, causing native/JavaScript ABI mismatch https://github.com/nodejs/node/issues/64558
Please reload this pagehttps://github.com/nodejs/node/pull/64559
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/ShogunPanda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.