René's URL Explorer Experiment


Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node · GitHub

Open Graph Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node

X Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node

Description: This fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR preserves the core change there, but covers the "response set but not yet completed" window properly so errors here still fire as expected.

Open Graph Description: This fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...

X Description: This fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...

Opengraph URL: https://github.com/nodejs/node/pull/64507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0f438d0-5134-bd93-671e-3f6610cf4cee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB77A:3BA6B9:12A2C21:18D5996:6AED5F22
html-safe-nonce70b00c1ddc9db2aa66b844adce7955c47b033963e92e058eeaf8367f7680038f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzdBOjNCQTZCOToxMkEyQzIxOjE4RDU5OTY6NkFFRDVGMjIiLCJ2aXNpdG9yX2lkIjoiMzcxOTA2NjYxMzUyMDg4MzQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e6e5a55d50bc0726489117650ca3b1ea58c9247c1d335af482d0a38a9cf7a13
hovercard-subject-tagpull_request:4055624384
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/64507/files
twitter:imagehttps://avatars.githubusercontent.com/u/1526883?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1526883?s=400&v=4
og:image:altThis fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64507/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64507/files
Reloadhttps://github.com/nodejs/node/pull/64507/files
Reloadhttps://github.com/nodejs/node/pull/64507/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests662 (662)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
pimterryhttps://github.com/pimterry
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-64278https://github.com/pimterry/node/tree/fix-64278
Conversation 17 https://github.com/nodejs/node/pull/64507
Commits 2 https://github.com/nodejs/node/pull/64507/commits
Checks 30 https://github.com/nodejs/node/pull/64507/checks
Files changed https://github.com/nodejs/node/pull/64507/files
Please reload this pagehttps://github.com/nodejs/node/pull/64507/files
http: fix just-merged change that could silently truncate responses https://github.com/nodejs/node/pull/64507/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/64507/files
912f569 http: fix just-merged change that could silently truncate responses pimterry Jul 14, 2026 https://github.com/nodejs/node/pull/64507/commits/912f569e8b7675612fe83a1e8f276b6dce2c60dd
30901e2 Fix the request-not-finished case as well pimterry Jul 14, 2026 https://github.com/nodejs/node/pull/64507/commits/30901e24cd5865e301fc283a05858e9417c44c90
Clear filters https://github.com/nodejs/node/pull/64507/files
Please reload this pagehttps://github.com/nodejs/node/pull/64507/files
Please reload this pagehttps://github.com/nodejs/node/pull/64507/files
_http_client.js https://github.com/nodejs/node/pull/64507/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
test-http-client-complete-response-open-request-reset.js https://github.com/nodejs/node/pull/64507/files#diff-6e6d6481dc0eedcc6445dfb7a44a9f2a75518bd41a8f211960881c7b646dcd9f
test-http-client-complete-response-reset.js https://github.com/nodejs/node/pull/64507/files#diff-a88e7c5de542cd91c73d3b550162d6e1c280384ebef32fd6f90ca400bf3b5094
test-http-client-incomplete-response-reset.js https://github.com/nodejs/node/pull/64507/files#diff-ba870647dcad0404151ad11d612b9f01fe0a62ff0837669bf7c98ab44f2ad4b9
lib/_http_client.jshttps://github.com/nodejs/node/pull/64507/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
View file https://github.com/nodejs/node/blob/30901e24cd5865e301fc283a05858e9417c44c90/lib/_http_client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64507/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64507/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/64507/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
test/parallel/test-http-client-complete-response-open-request-reset.jshttps://github.com/nodejs/node/pull/64507/files#diff-6e6d6481dc0eedcc6445dfb7a44a9f2a75518bd41a8f211960881c7b646dcd9f
View file https://github.com/nodejs/node/blob/30901e24cd5865e301fc283a05858e9417c44c90/test/parallel/test-http-client-complete-response-open-request-reset.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64507/{{ revealButtonHref }}
https://github.com/nodejs/node/actions/runs/29372367020/job/87218387012?pr=64507
test/parallel/test-http-client-complete-response-reset.jshttps://github.com/nodejs/node/pull/64507/files#diff-a88e7c5de542cd91c73d3b550162d6e1c280384ebef32fd6f90ca400bf3b5094
View file https://github.com/nodejs/node/blob/30901e24cd5865e301fc283a05858e9417c44c90/test/parallel/test-http-client-complete-response-reset.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64507/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64507/files#diff-a88e7c5de542cd91c73d3b550162d6e1c280384ebef32fd6f90ca400bf3b5094
https://github.com/nodejs/node/pull/64507/files#diff-a88e7c5de542cd91c73d3b550162d6e1c280384ebef32fd6f90ca400bf3b5094
test/parallel/test-http-client-incomplete-response-reset.jshttps://github.com/nodejs/node/pull/64507/files#diff-ba870647dcad0404151ad11d612b9f01fe0a62ff0837669bf7c98ab44f2ad4b9
View file https://github.com/nodejs/node/blob/30901e24cd5865e301fc283a05858e9417c44c90/test/parallel/test-http-client-incomplete-response-reset.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64507/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/64507/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.