René's URL Explorer Experiment


Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node · GitHub

Open Graph Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node

X Title: http: fix just-merged change that could silently truncate responses by pimterry · Pull Request #64507 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...

X Description: This fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...

Opengraph URL: https://github.com/nodejs/node/pull/64507

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e5575628-452f-5197-5ea4-de98dde43203
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDD8:3BA6B9:826F08:ADC8FD:6AED2890
html-safe-noncec8d93a75c708cb9a6e3b90fc721aa4d58059a3cbd83be0e2c0f595a506a4577c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREQ4OjNCQTZCOTo4MjZGMDg6QURDOEZEOjZBRUQyODkwIiwidmlzaXRvcl9pZCI6IjQ3NTM0MDAxMzY4OTUxMTMzNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc8cdcca704bad6fb3b44d3979ccb1bc7df9c9d41e5cb8d8d281b42d1694e2c27
hovercard-subject-tagpull_request:4055624384
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64507/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/eed07ed8feb49f757d0d4b7b5cf9582abebe85ef25843c886de6bad87a61c071/nodejs/node/pull/64507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eed07ed8feb49f757d0d4b7b5cf9582abebe85ef25843c886de6bad87a61c071/nodejs/node/pull/64507
og:image:altThis fixes an issue introduced 2 days ago in #64278. With that change, errors that emit after HTTP response headers are received but before the response is completed are swallowed silently. This PR...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepimterry
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64507#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64507
Reloadhttps://github.com/nodejs/node/pull/64507
Reloadhttps://github.com/nodejs/node/pull/64507
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
pimterryhttps://github.com/pimterry
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-64278https://github.com/pimterry/node/tree/fix-64278
Conversationhttps://github.com/nodejs/node/pull/64507
Commits2 (2)https://github.com/nodejs/node/pull/64507/commits
Checkshttps://github.com/nodejs/node/pull/64507/checks
Files changedhttps://github.com/nodejs/node/pull/64507/files
http: fix just-merged change that could silently truncate responseshttps://github.com/nodejs/node/pull/64507#top
pimterryhttps://github.com/pimterry
nodejs:mainhttps://github.com/nodejs/node/tree/main
pimterry:fix-64278https://github.com/pimterry/node/tree/fix-64278
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issue-4886810964
#64278https://github.com/nodejs/node/pull/64278
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/pimterry
http: fix just-merged change that could silently truncate responseshttps://github.com/nodejs/node/pull/64507/commits/912f569e8b7675612fe83a1e8f276b6dce2c60dd
912f569https://github.com/nodejs/node/pull/64507/commits/912f569e8b7675612fe83a1e8f276b6dce2c60dd
https://github.com/pimterry
pimterryhttps://github.com/pimterry
lpincahttps://github.com/lpinca
mcollinahttps://github.com/mcollina
July 14, 2026 20:31https://github.com/nodejs/node/pull/64507#event-27983779701
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4973711458
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 14, 2026https://github.com/nodejs/node/pull/64507#event-27983785085
https://github.com/pimterry
pimterryhttps://github.com/pimterry
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 14, 2026https://github.com/nodejs/node/pull/64507#event-27983788325
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4973714208
@pimterryhttps://github.com/pimterry
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/bjohansebas
bjohansebashttps://github.com/bjohansebas
Jul 14, 2026 https://github.com/nodejs/node/pull/64507#pullrequestreview-4698316489
View reviewed changes https://github.com/nodejs/node/pull/64507/files/912f569e8b7675612fe83a1e8f276b6dce2c60dd
bjohansebashttps://github.com/bjohansebas
https://github.com/nodejs/node/pull/64507#pullrequestreview-4698316489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 14, 2026 https://github.com/nodejs/node/pull/64507#pullrequestreview-4698325252
View reviewed changes https://github.com/nodejs/node/pull/64507/files/912f569e8b7675612fe83a1e8f276b6dce2c60dd
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/64507#pullrequestreview-4698325252
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4973767524
#64278https://github.com/nodejs/node/pull/64278
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4973812645
https://ci.nodejs.org/job/node-test-pull-request/74823/https://ci.nodejs.org/job/node-test-pull-request/74823/
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4974473326
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/pimterry
Fix the request-not-finished case as wellhttps://github.com/nodejs/node/pull/64507/commits/30901e24cd5865e301fc283a05858e9417c44c90
30901e2https://github.com/nodejs/node/pull/64507/commits/30901e24cd5865e301fc283a05858e9417c44c90
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 14, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4975184302
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64507?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
3ac95f2https://app.codecov.io/gh/nodejs/node/commit/3ac95f2d0ca18650a5a53ad9254ef01fd9673de2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
30901e2https://app.codecov.io/gh/nodejs/node/commit/30901e24cd5865e301fc283a05858e9417c44c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64507?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/_http_client.jshttps://app.codecov.io/gh/nodejs/node/pull/64507?src=pr&el=tree&filepath=lib%2F_http_client.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2NsaWVudC5qcw==
37 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64507/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/Archkon
Archkonhttps://github.com/Archkon
Jul 15, 2026 https://github.com/nodejs/node/pull/64507#pullrequestreview-4700680534
View reviewed changes https://github.com/nodejs/node/pull/64507/files/30901e24cd5865e301fc283a05858e9417c44c90
lib/_http_client.jshttps://github.com/nodejs/node/pull/64507/files/30901e24cd5865e301fc283a05858e9417c44c90#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/Archkon
Archkonhttps://github.com/Archkon
Jul 15, 2026 https://github.com/nodejs/node/pull/64507#pullrequestreview-4701368606
View reviewed changes https://github.com/nodejs/node/pull/64507/files/30901e24cd5865e301fc283a05858e9417c44c90
test/parallel/test-http-client-complete-response-open-request-reset.jshttps://github.com/nodejs/node/pull/64507/files/30901e24cd5865e301fc283a05858e9417c44c90#diff-6e6d6481dc0eedcc6445dfb7a44a9f2a75518bd41a8f211960881c7b646dcd9f
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 15, 2026 https://github.com/nodejs/node/pull/64507#ref-pullrequest-4890172908
Revert "http: do not emit socket errors after complete response" #64511 https://github.com/nodejs/node/pull/64511
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Jul 15, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4979857318
@Archkonhttps://github.com/Archkon
#64511https://github.com/nodejs/node/pull/64511
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Jul 15, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4981761206
herehttps://github.com/nodejs/node/actions/runs/29372367205/job/87218629054?pr=64507
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Jul 16, 2026https://github.com/nodejs/node/pull/64507#issuecomment-4994385040
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/Archkon
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
https://github.com/Archkon
Archkonhttps://github.com/Archkon
Jul 17, 2026 https://github.com/nodejs/node/pull/64507#ref-issue-4909146270
kqueue: write-side socket error can be dispatched before pending readable data after TCP reset libuv/libuv#5196 https://github.com/libuv/libuv/issues/5196
https://github.com/lpinca
lpincahttps://github.com/lpinca
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 17, 2026https://github.com/nodejs/node/pull/64507#event-28136809031
Archkonhttps://github.com/Archkon
Jul 17, 2026 https://github.com/nodejs/node/pull/64507#ref-commit-2818b98
https://github.com/Archkon
http: defer write errors for pending responseshttps://github.com/Archkon/node/commit/2818b98c165299ddfd4a658dac031a3035e77e75
2818b98https://github.com/Archkon/node/commit/2818b98c165299ddfd4a658dac031a3035e77e75
nodejs#64507https://github.com/nodejs/node/pull/64507
nodejs#64278https://github.com/nodejs/node/pull/64278
nodejs#64272https://github.com/nodejs/node/issues/64272
nodejs#64511https://github.com/nodejs/node/pull/64511
libuv/libuv#5196https://github.com/libuv/libuv/issues/5196
nodejs#64507 (comment)https://github.com/nodejs/node/pull/64507#issuecomment-4999378702
nodejs#64511 (comment)https://github.com/nodejs/node/pull/64511#issuecomment-4978451178
https://github.com/Archkon
Archkonhttps://github.com/Archkon
Jul 17, 2026 https://github.com/nodejs/node/pull/64507#ref-pullrequest-4915071325
http: fix the reverted commit which would swallow some errors #64566 https://github.com/nodejs/node/pull/64566
Archkonhttps://github.com/Archkon
Aug 4, 2026 https://github.com/nodejs/node/pull/64507#ref-commit-dcbb130
https://github.com/Archkon
http: defer write errors for pending responseshttps://github.com/Archkon/node/commit/dcbb13015ef4630124c5ce0fc6cee2bb452a8285
dcbb130https://github.com/Archkon/node/commit/dcbb13015ef4630124c5ce0fc6cee2bb452a8285
nodejs#64507https://github.com/nodejs/node/pull/64507
nodejs#64278https://github.com/nodejs/node/pull/64278
nodejs#64272https://github.com/nodejs/node/issues/64272
nodejs#64511https://github.com/nodejs/node/pull/64511
libuv/libuv#5196https://github.com/libuv/libuv/issues/5196
nodejs#64507 (comment)https://github.com/nodejs/node/pull/64507#issuecomment-4999378702
nodejs#64511 (comment)https://github.com/nodejs/node/pull/64511#issuecomment-4978451178
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64507
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/64507/files/912f569e8b7675612fe83a1e8f276b6dce2c60dd
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/Archkon
Archkon https://github.com/Archkon
https://github.com/nodejs/node/pull/64507/files/30901e24cd5865e301fc283a05858e9417c44c90
https://github.com/bjohansebas
bjohansebas https://github.com/bjohansebas
https://github.com/nodejs/node/pull/64507/files/912f569e8b7675612fe83a1e8f276b6dce2c60dd
Please reload this pagehttps://github.com/nodejs/node/pull/64507
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/64507
https://github.com/pimterry
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/Archkon
https://github.com/bjohansebas
https://github.com/lpinca
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.