René's URL Explorer Experiment


Title: stream: reject strings in ReadableStream.from by trivikr · Pull Request #64465 · nodejs/node · GitHub

Open Graph Title: stream: reject strings in ReadableStream.from by trivikr · Pull Request #64465 · nodejs/node

X Title: stream: reject strings in ReadableStream.from by trivikr · Pull Request #64465 · nodejs/node

Description: Refs: #64288 Depends on: web-platform-tests/wpt#59594 Use Web IDL async_sequence semantics for ReadableStream.from(). This changes ReadableStream.from('abc') to throw a TypeError instead of iterating over the string's Unicode code points. Web IDL async sequences require the input value to be an ECMAScript object. The corresponding WPT change is included provisionally. This PR should not land until the upstream WPT PR is merged. Afterward, the Streams WPT fixtures will be regenerated with git node wpt streams. Assisted-by: openai:gpt-5.6-sol

Open Graph Description: Refs: #64288 Depends on: web-platform-tests/wpt#59594 Use Web IDL async_sequence<any> semantics for ReadableStream.from(). This changes ReadableStream.from('abc') to throw a TypeError...

X Description: Refs: #64288 Depends on: web-platform-tests/wpt#59594 Use Web IDL async_sequence&lt;any&gt; semantics for ReadableStream.from(). This changes ReadableStream.from(&#39;abc&#39;) to t...

Opengraph URL: https://github.com/nodejs/node/pull/64465

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5e1b66da-0308-1c16-d526-f45adeebb359
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84BC:35BF39:657747:84BD97:6AED2E6C
html-safe-nonce916c2daf7c060cd01099a8765ff634409bf92b1e11cffbd20d4f680e4169312b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEJDOjM1QkYzOTo2NTc3NDc6ODRCRDk3OjZBRUQyRTZDIiwidmlzaXRvcl9pZCI6IjE2Njc2OTE1MzQ2MDI4MDg5NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac89e68159a39f7eee99eadd271577b470877010b2f15e4321eb981b9cc143fd71
hovercard-subject-tagpull_request:4040815467
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/64465/files
twitter:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16024985?s=400&v=4
og:image:altRefs: #64288 Depends on: web-platform-tests/wpt#59594 Use Web IDL async_sequence<any> semantics for ReadableStream.from(). This changes ReadableStream.from('abc') to throw a TypeError...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee51d0b7b5ab34b1688c05b54c3ed17b8658b2fa9bca973a9c740683ccb12cf4a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ebb7b901cc154ecc179a44f266fcf69f343b30
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64465/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64465%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64465%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64465/files
Reloadhttps://github.com/nodejs/node/pull/64465/files
Reloadhttps://github.com/nodejs/node/pull/64465/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
trivikrhttps://github.com/trivikr
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:readable-stream-from-reject-stringshttps://github.com/trivikr/node/tree/readable-stream-from-reject-strings
Conversation 6 https://github.com/nodejs/node/pull/64465
Commits 1 https://github.com/nodejs/node/pull/64465/commits
Checks 35 https://github.com/nodejs/node/pull/64465/checks
Files changed https://github.com/nodejs/node/pull/64465/files
Please reload this pagehttps://github.com/nodejs/node/pull/64465/files
stream: reject strings in ReadableStream.from https://github.com/nodejs/node/pull/64465/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/64465/files
b2aa380 stream: reject strings in ReadableStream.from trivikr Jul 13, 2026 https://github.com/nodejs/node/pull/64465/commits/b2aa380da10e073b1226a5c5999a8fd909b1bbbb
Clear filters https://github.com/nodejs/node/pull/64465/files
Please reload this pagehttps://github.com/nodejs/node/pull/64465/files
Please reload this pagehttps://github.com/nodejs/node/pull/64465/files
readablestream.js https://github.com/nodejs/node/pull/64465/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
from.any.js https://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
test-webstream-readable-from.js https://github.com/nodejs/node/pull/64465/files#diff-a5c2ca0d39740eb038904248bcdf1f44ee3b9a881b49b03452b8b6bc70c2e568
lib/internal/webstreams/readablestream.jshttps://github.com/nodejs/node/pull/64465/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
View file https://github.com/nodejs/node/blob/b2aa380da10e073b1226a5c5999a8fd909b1bbbb/lib/internal/webstreams/readablestream.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64465/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64465/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
https://github.com/nodejs/node/pull/64465/files#diff-a75b6b92eada0f88527acce4428a28471b39067fd0ddaab2fcf26cc022bded47
test/fixtures/wpt/streams/readable-streams/from.any.jshttps://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
View file https://github.com/nodejs/node/blob/b2aa380da10e073b1226a5c5999a8fd909b1bbbb/test/fixtures/wpt/streams/readable-streams/from.any.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64465/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
https://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
https://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
https://github.com/nodejs/node/pull/64465/files#diff-43b4eb446db690cf9e5fd6963f8c3c5d3364cb8c1234f5942a87b41cb2925928
test/parallel/test-webstream-readable-from.jshttps://github.com/nodejs/node/pull/64465/files#diff-a5c2ca0d39740eb038904248bcdf1f44ee3b9a881b49b03452b8b6bc70c2e568
View file https://github.com/nodejs/node/blob/b2aa380da10e073b1226a5c5999a8fd909b1bbbb/test/parallel/test-webstream-readable-from.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64465/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64465/files#diff-a5c2ca0d39740eb038904248bcdf1f44ee3b9a881b49b03452b8b6bc70c2e568
https://github.com/nodejs/node/pull/64465/files#diff-a5c2ca0d39740eb038904248bcdf1f44ee3b9a881b49b03452b8b6bc70c2e568
Please reload this pagehttps://github.com/nodejs/node/pull/64465/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.