René's URL Explorer Experiment


Title: stream: fix drop-newest behavior in share() by trivikr · Pull Request #64417 · nodejs/node · GitHub

Open Graph Title: stream: fix drop-newest behavior in share() by trivikr · Pull Request #64417 · nodejs/node

X Title: stream: fix drop-newest behavior in share() by trivikr · Pull Request #64417 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64416 Fixes share() with backpressure: 'drop-newest' so upstream pull results are discarded when the shared buffer reaches highWaterMark. Previously, #waitForBufferSpace() returned ...

X Description: Fixes: #64416 Fixes share() with backpressure: 'drop-newest' so upstream pull results are discarded when the shared buffer reaches highWaterMark. Previously, #waitForBufferSpace() r...

Opengraph URL: https://github.com/nodejs/node/pull/64417

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0003efa9-71bd-34f6-363e-4f4158ee8713
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D8C:2088C9:20C2653:2C9CD1F:6A6308E9
html-safe-nonce100546e3dca1181b183bb85bdbc2c9b70efcfeea46b39c5f4b6f953d9544e2c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDhDOjIwODhDOToyMEMyNjUzOjJDOUNEMUY6NkE2MzA4RTkiLCJ2aXNpdG9yX2lkIjoiNzEwOTE5MTIxMDU3MDU0OTQ4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6d2f8744519c22040784868378072743be7304182ea39e4411102af651037c93
hovercard-subject-tagpull_request:4033621061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64417/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/83aa4b16e36e4a963bcaf6f5e0e49f137b7b42633730610e15484a5b65994999/nodejs/node/pull/64417
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/83aa4b16e36e4a963bcaf6f5e0e49f137b7b42633730610e15484a5b65994999/nodejs/node/pull/64417
og:image:altFixes: #64416 Fixes share() with backpressure: 'drop-newest' so upstream pull results are discarded when the shared buffer reaches highWaterMark. Previously, #waitForBufferSpace() returned ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Noneb48e7bf0b1945d51f303503b057abf666ce74c3efbe107b413db2bb921c3f012
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9370f37042c29822d6ba7e3f670f0036a0155b21
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64417#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64417
Reloadhttps://github.com/nodejs/node/pull/64417
Reloadhttps://github.com/nodejs/node/pull/64417
Please reload this pagehttps://github.com/nodejs/node/pull/64417
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64417
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-share-drop-newesthttps://github.com/trivikr/node/tree/stream-iter-share-drop-newest
Conversationhttps://github.com/nodejs/node/pull/64417
Commits1 (1)https://github.com/nodejs/node/pull/64417/commits
Checkshttps://github.com/nodejs/node/pull/64417/checks
Files changedhttps://github.com/nodejs/node/pull/64417/files
stream: fix drop-newest behavior in share()https://github.com/nodejs/node/pull/64417#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-share-drop-newesthttps://github.com/trivikr/node/tree/stream-iter-share-drop-newest
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 11, 2026https://github.com/nodejs/node/pull/64417#issue-4860100120
#64416https://github.com/nodejs/node/issues/64416
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2026https://github.com/nodejs/node/pull/64417#issuecomment-4941626311
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 11, 2026https://github.com/nodejs/node/pull/64417#event-27841116780
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 11, 2026https://github.com/nodejs/node/pull/64417#event-27841119117
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 11, 2026https://github.com/nodejs/node/pull/64417#issuecomment-4942218720
Please reload this pagehttps://github.com/nodejs/node/pull/64417
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64417?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
608112ahttps://app.codecov.io/gh/nodejs/node/commit/608112affae2cf44d2f8a0a6bfe7967193b459c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
5fadff0https://app.codecov.io/gh/nodejs/node/commit/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64417?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/64417?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
1 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/64417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64417?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/share.jshttps://app.codecov.io/gh/nodejs/node/pull/64417?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fshare.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9zaGFyZS5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/trivikr
stream: fix drop-newest behavior in share()https://github.com/nodejs/node/pull/64417/commits/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
5fadff0https://github.com/nodejs/node/pull/64417/commits/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/baae906a12b5fc50def40766c49eeb008f3a1202..5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
baae906https://github.com/nodejs/node/commit/baae906a12b5fc50def40766c49eeb008f3a1202
5fadff0https://github.com/nodejs/node/commit/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
Compare https://github.com/nodejs/node/compare/baae906a12b5fc50def40766c49eeb008f3a1202..5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
July 16, 2026 03:48https://github.com/nodejs/node/pull/64417#event-28049374729
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 19, 2026 https://github.com/nodejs/node/pull/64417#pullrequestreview-4731096358
View reviewed changes https://github.com/nodejs/node/pull/64417/files/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 19, 2026https://github.com/nodejs/node/pull/64417#event-28183639151
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 20, 2026https://github.com/nodejs/node/pull/64417#event-28230015764
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2026https://github.com/nodejs/node/pull/64417#issuecomment-5028165667
https://ci.nodejs.org/job/node-test-pull-request/74930/https://ci.nodejs.org/job/node-test-pull-request/74930/
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 21, 2026https://github.com/nodejs/node/pull/64417#event-28241509123
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 21, 2026https://github.com/nodejs/node/pull/64417#event-28242185290
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
4991131https://github.com/nodejs/node/commit/4991131590829d9fbfa505ece12fa5b78fc7a569
Jul 21, 2026https://github.com/nodejs/node/pull/64417#event-28242381854
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 21, 2026https://github.com/nodejs/node/pull/64417#issuecomment-5028949044
4991131https://github.com/nodejs/node/commit/4991131590829d9fbfa505ece12fa5b78fc7a569
Please reload this pagehttps://github.com/nodejs/node/pull/64417
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64417#ref-commit-03abb09
https://github.com/trivikr
https://github.com/aduh95
stream: fix drop-newest behavior in share()https://github.com/nodejs/node/commit/03abb0924b165c20d79d2b1d076bab818ce9aef2
03abb09https://github.com/nodejs/node/commit/03abb0924b165c20d79d2b1d076bab818ce9aef2
#64417https://github.com/nodejs/node/pull/64417
#64416https://github.com/nodejs/node/issues/64416
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64417#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64417#ref-commit-0418f1a
https://github.com/trivikr
https://github.com/aduh95
stream: fix drop-newest behavior in share()https://github.com/nodejs/node/commit/0418f1af33599ddcbde010981ac49e3cca279316
0418f1ahttps://github.com/nodejs/node/commit/0418f1af33599ddcbde010981ac49e3cca279316
#64417https://github.com/nodejs/node/pull/64417
#64416https://github.com/nodejs/node/issues/64416
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64417#ref-commit-ddf7798
https://github.com/trivikr
https://github.com/aduh95
stream: fix drop-newest behavior in share()https://github.com/nodejs/node/commit/ddf779893df944a002acc6931e2e4feca8ad4c28
ddf7798https://github.com/nodejs/node/commit/ddf779893df944a002acc6931e2e4feca8ad4c28
#64417https://github.com/nodejs/node/pull/64417
#64416https://github.com/nodejs/node/issues/64416
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64417
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64417/files/5fadff01bdd322cb47040a8b9de75dec1d8c1e5d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: share() does not discard upstream results with "drop-newest" https://github.com/nodejs/node/issues/64416
Please reload this pagehttps://github.com/nodejs/node/pull/64417
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.