René's URL Explorer Experiment


Title: vfs: enforce readonly state on open handles by harjothkhara · Pull Request #64403 · nodejs/node · GitHub

Open Graph Title: vfs: enforce readonly state on open handles by harjothkhara · Pull Request #64403 · nodejs/node

X Title: vfs: enforce readonly state on open handles by harjothkhara · Pull Request #64403 · nodejs/node

Description: MemoryProvider.setReadOnly() prevented new writable handles from being opened, but handles opened before the transition retained write access. This allowed descriptor-based writes and truncation to bypass the provider's documented read-only state. Pass a live provider-state callback to MemoryFileHandle and check it at each mutation primitive. This covers descriptor and direct-handle operations, including delegated async, vector, and append-mode writes, while preserving EBADF precedence for handles that were not opened for writing. Regression tests cover: writeSync() and ftruncateSync() through pre-existing descriptors append-mode descriptors opened before setReadOnly() async handle write(), writeFile(), truncate(), and writev() unchanged file contents after rejected mutations Validation: python3 tools/test.py test/parallel/test-vfs-memory-provider.js test/parallel/test-vfs-memory-file-handle.js JavaScript lint on the three changed files Fixes: #64401

Open Graph Description: MemoryProvider.setReadOnly() prevented new writable handles from being opened, but handles opened before the transition retained write access. This allowed descriptor-based writes and truncation to...

X Description: MemoryProvider.setReadOnly() prevented new writable handles from being opened, but handles opened before the transition retained write access. This allowed descriptor-based writes and truncation to...

Opengraph URL: https://github.com/nodejs/node/pull/64403

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.112.4

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:13c1c15c-4bfd-1b85-1f4a-39efe82cda4e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBC6:1C9060:20AAD09:2B1FD21:6B0354C2
html-safe-nonceaff68a255c6d7faed90cbda5b873984fd9df8123913eb99c8fa45ff9ac113d0c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkM2OjFDOTA2MDoyMEFBRDA5OjJCMUZEMjE6NkIwMzU0QzIiLCJ2aXNpdG9yX2lkIjoiMjAxOTMyNDA0MTg4NTg2NTE1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac66d95b0fea4d8cb927171eb8e32b483f03655da141de87986e247baa3b99fa40
hovercard-subject-tagpull_request:4026987497
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/64403/files
twitter:imagehttps://avatars.githubusercontent.com/u/48686985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/48686985?s=400&v=4
og:image:altMemoryProvider.setReadOnly() prevented new writable handles from being opened, but handles opened before the transition retained write access. This allowed descriptor-based writes and truncation to...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64403/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64403%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64403%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64403/files
Reloadhttps://github.com/nodejs/node/pull/64403/files
Reloadhttps://github.com/nodejs/node/pull/64403/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues637 (637)https://github.com/nodejs/node/issues
Pull requests667 (667)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
harjothkhara:codex/fix-vfs-readonly-handleshttps://github.com/harjothkhara/node/tree/codex/fix-vfs-readonly-handles
Conversation 10 https://github.com/nodejs/node/pull/64403
Commits 1 https://github.com/nodejs/node/pull/64403/commits
Checks 41 https://github.com/nodejs/node/pull/64403/checks
Files changed https://github.com/nodejs/node/pull/64403/files
Please reload this pagehttps://github.com/nodejs/node/pull/64403/files
vfs: enforce readonly state on open handles https://github.com/nodejs/node/pull/64403/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/64403/files
298698e vfs: enforce readonly state on open handles harjothkhara Jul 10, 2026 https://github.com/nodejs/node/pull/64403/commits/298698e9a335ee28ae7b6f2061b21ba29e78596f
Clear filters https://github.com/nodejs/node/pull/64403/files
Please reload this pagehttps://github.com/nodejs/node/pull/64403/files
Please reload this pagehttps://github.com/nodejs/node/pull/64403/files
file_handle.js https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
memory.js https://github.com/nodejs/node/pull/64403/files#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
test-vfs-memory-provider.js https://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
lib/internal/vfs/file_handle.jshttps://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
View file https://github.com/harjothkhara/node/blob/298698e9a335ee28ae7b6f2061b21ba29e78596f/lib/internal/vfs/file_handle.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64403/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
https://github.com/nodejs/node/pull/64403/files#diff-bc81c83b80666b34781524911dcef029bdd6b45de42ee513cc2ec95f41fa1dfd
lib/internal/vfs/providers/memory.jshttps://github.com/nodejs/node/pull/64403/files#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
View file https://github.com/harjothkhara/node/blob/298698e9a335ee28ae7b6f2061b21ba29e78596f/lib/internal/vfs/providers/memory.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64403/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64403/files#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
https://github.com/nodejs/node/pull/64403/files#diff-e954e208a8f73fa7dd4ce5b1eb35b1f5cead8d2a9ce751037e54a65334f40963
test/parallel/test-vfs-memory-provider.jshttps://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
View file https://github.com/harjothkhara/node/blob/298698e9a335ee28ae7b6f2061b21ba29e78596f/test/parallel/test-vfs-memory-provider.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/64403/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
https://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
https://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
https://github.com/nodejs/node/pull/64403/files#diff-8a7dea0a69968e022ccdc52ae846737cd77f4fe990d617394ac42244878b7d69
Please reload this pagehttps://github.com/nodejs/node/pull/64403/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.