René's URL Explorer Experiment


Title: stream: reject push iterator.throw() with error by trivikr · Pull Request #64380 · nodejs/node · GitHub

Open Graph Title: stream: reject push iterator.throw() with error by trivikr · Pull Request #64380 · nodejs/node

X Title: stream: reject push iterator.throw() with error by trivikr · Pull Request #64380 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64378 This updates stream/iter push readable iterators so iterator.throw(error) rejects with the supplied error instead of resolving with { done: true, value: undefined }. The existing canc...

X Description: Fixes: #64378 This updates stream/iter push readable iterators so iterator.throw(error) rejects with the supplied error instead of resolving with { done: true, value: undefined }. The existing canc...

Opengraph URL: https://github.com/nodejs/node/pull/64380

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b44d8758-213f-d4b7-a170-45ae48de5816
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94C2:1AC9BC:AE1A20:E987AB:6A62A7D4
html-safe-nonceb732e9f20885d0023130050d608280e82e26c919ae7f0be5c26dee40358accf6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEMyOjFBQzlCQzpBRTFBMjA6RTk4N0FCOjZBNjJBN0Q0IiwidmlzaXRvcl9pZCI6IjU3NTgzODU3OTIyNDQ0MjY3MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3b52a7e53be943255376cddf0b01dc2d996b66147d461640036724c98978d738
hovercard-subject-tagpull_request:4019054663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64380/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a2fc4088d6d92cdf781c2380cdd83d6498ca1e61d4c241cb637f1439af0253ce/nodejs/node/pull/64380
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2fc4088d6d92cdf781c2380cdd83d6498ca1e61d4c241cb637f1439af0253ce/nodejs/node/pull/64380
og:image:altFixes: #64378 This updates stream/iter push readable iterators so iterator.throw(error) rejects with the supplied error instead of resolving with { done: true, value: undefined }. The existing canc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonee362a1b5e54cdb52dad78dc403bb9e6a8362e7c0448a1d804fe243f9fac57954
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5410e150d3e7c804f80827080c5f130c97eaf5a4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64380#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64380
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64380
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64380
Reloadhttps://github.com/nodejs/node/pull/64380
Reloadhttps://github.com/nodejs/node/pull/64380
Please reload this pagehttps://github.com/nodejs/node/pull/64380
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64380
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-readable-throwhttps://github.com/trivikr/node/tree/stream-iter-push-readable-throw
Conversationhttps://github.com/nodejs/node/pull/64380
Commits1 (1)https://github.com/nodejs/node/pull/64380/commits
Checkshttps://github.com/nodejs/node/pull/64380/checks
Files changedhttps://github.com/nodejs/node/pull/64380/files
stream: reject push iterator.throw() with errorhttps://github.com/nodejs/node/pull/64380#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-push-readable-throwhttps://github.com/trivikr/node/tree/stream-iter-push-readable-throw
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 9, 2026https://github.com/nodejs/node/pull/64380#issue-4842869329
#64378https://github.com/nodejs/node/issues/64378
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/trivikr
stream: reject push iterator.throw() with errorhttps://github.com/nodejs/node/pull/64380/commits/b1e4e8870b400195486a29fbe23a5709e783456f
b1e4e88https://github.com/nodejs/node/pull/64380/commits/b1e4e8870b400195486a29fbe23a5709e783456f
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2026https://github.com/nodejs/node/pull/64380#issuecomment-4921269777
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 9, 2026https://github.com/nodejs/node/pull/64380#event-27745805265
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2026https://github.com/nodejs/node/pull/64380#event-27745808224
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 9, 2026https://github.com/nodejs/node/pull/64380#issuecomment-4921751957
Please reload this pagehttps://github.com/nodejs/node/pull/64380
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64380?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0032189https://app.codecov.io/gh/nodejs/node/commit/0032189dbe7c1e9a8e65178d6d50bcb620d6b1d3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
b1e4e88https://app.codecov.io/gh/nodejs/node/commit/b1e4e8870b400195486a29fbe23a5709e783456f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64380?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/64380?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64380/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 9, 2026 https://github.com/nodejs/node/pull/64380#pullrequestreview-4663421684
View reviewed changes https://github.com/nodejs/node/pull/64380/files/b1e4e8870b400195486a29fbe23a5709e783456f
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2026https://github.com/nodejs/node/pull/64380#event-27767854042
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64380
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 9, 2026https://github.com/nodejs/node/pull/64380#event-27768895298
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2026https://github.com/nodejs/node/pull/64380#issuecomment-4930050512
https://ci.nodejs.org/job/node-test-pull-request/74711/https://ci.nodejs.org/job/node-test-pull-request/74711/
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 16, 2026https://github.com/nodejs/node/pull/64380#event-28048779981
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 16, 2026https://github.com/nodejs/node/pull/64380#event-28049145828
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
608112ahttps://github.com/nodejs/node/commit/608112affae2cf44d2f8a0a6bfe7967193b459c8
Jul 16, 2026https://github.com/nodejs/node/pull/64380#event-28049240722
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 16, 2026https://github.com/nodejs/node/pull/64380#issuecomment-4987928546
608112ahttps://github.com/nodejs/node/commit/608112affae2cf44d2f8a0a6bfe7967193b459c8
Please reload this pagehttps://github.com/nodejs/node/pull/64380
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64380#ref-commit-8ee0570
https://github.com/trivikr
https://github.com/aduh95
stream: reject push iterator.throw() with errorhttps://github.com/nodejs/node/commit/8ee0570fdd8d9fe630b0a14f727ededb748e407f
8ee0570https://github.com/nodejs/node/commit/8ee0570fdd8d9fe630b0a14f727ededb748e407f
#64380https://github.com/nodejs/node/pull/64380
#64378https://github.com/nodejs/node/issues/64378
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64380#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64380#ref-commit-7677b1c
https://github.com/trivikr
https://github.com/aduh95
stream: reject push iterator.throw() with errorhttps://github.com/nodejs/node/commit/7677b1c3076e0b55de1cb0cec7d99bba2bd5a2ff
7677b1chttps://github.com/nodejs/node/commit/7677b1c3076e0b55de1cb0cec7d99bba2bd5a2ff
#64380https://github.com/nodejs/node/pull/64380
#64378https://github.com/nodejs/node/issues/64378
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64380
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64380/files/b1e4e8870b400195486a29fbe23a5709e783456f
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: push readable iterator.throw() resolves instead of rejecting https://github.com/nodejs/node/issues/64378
Please reload this pagehttps://github.com/nodejs/node/pull/64380
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.