Title: dns: address compile-time warnings by aduh95 · Pull Request #64355 · nodejs/node · GitHub
Open Graph Title: dns: address compile-time warnings by aduh95 · Pull Request #64355 · nodejs/node
X Title: dns: address compile-time warnings by aduh95 · Pull Request #64355 · nodejs/node
Description: ../../src/cares_wrap.cc:227:16: warning: 'ares_parse_a_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 227 | status = ares_parse_a_reply(buf, | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1098:14: note: 'ares_parse_a_reply' has been explicitly marked deprecated here 1098 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_a_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:234:16: warning: 'ares_parse_aaaa_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 234 | status = ares_parse_aaaa_reply(buf, | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1102:14: note: 'ares_parse_aaaa_reply' has been explicitly marked deprecated here 1102 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_aaaa_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:241:16: warning: 'ares_parse_ns_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 241 | status = ares_parse_ns_reply(buf, len, &host); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1113:14: note: 'ares_parse_ns_reply' has been explicitly marked deprecated here 1113 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_ns_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:244:16: warning: 'ares_parse_ptr_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 244 | status = ares_parse_ptr_reply(buf, len, nullptr, 0, AF_INET, &host); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1109:14: note: 'ares_parse_ptr_reply' has been explicitly marked deprecated here 1109 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_ptr_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:320:16: warning: 'ares_parse_mx_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 320 | int status = ares_parse_mx_reply(buf, len, &mx_start); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1119:14: note: 'ares_parse_mx_reply' has been explicitly marked deprecated here 1119 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_mx_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:366:16: warning: 'ares_parse_caa_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 366 | int status = ares_parse_caa_reply(buf, len, &caa_start); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1106:14: note: 'ares_parse_caa_reply' has been explicitly marked deprecated here 1106 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_caa_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:494:16: warning: 'ares_parse_txt_reply_ext' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 494 | int status = ares_parse_txt_reply_ext(buf, len, &txt_out); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1125:14: note: 'ares_parse_txt_reply_ext' has been explicitly marked deprecated here 1125 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_txt_reply_ext( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:581:16: warning: 'ares_parse_srv_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 581 | int status = ares_parse_srv_reply(buf, len, &srv_start); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1116:14: note: 'ares_parse_srv_reply' has been explicitly marked deprecated here 1116 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_srv_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:636:16: warning: 'ares_parse_naptr_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 636 | int status = ares_parse_naptr_reply(buf, len, &naptr_start); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1128:14: note: 'ares_parse_naptr_reply' has been explicitly marked deprecated here 1128 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_naptr_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:984:3: warning: 'ares_get_servers_ports' is deprecated: Use ares_get_servers_csv instead [-Wdeprecated-declarations] 984 | ares_get_servers_ports(channel_, &servers); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1187:1: note: 'ares_get_servers_ports' has been explicitly marked deprecated here 1187 | CARES_DEPRECATED_FOR(ares_get_servers_csv) | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ ../../src/cares_wrap.cc:1688:16: warning: 'ares_parse_soa_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 1688 | int status = ares_parse_soa_reply(buf, len, &soa_out); | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:1131:14: note: 'ares_parse_soa_reply' has been explicitly marked deprecated here 1131 | CARES_EXTERN CARES_DEPRECATED_FOR(ares_dns_parse) int ares_parse_soa_reply( | ^ /nix/store/655p6if1xf6r88nnr876x7xmclflyx2z-c-ares-1.34.7-dev/include/ares.h:153:22: note: expanded from macro 'CARES_DEPRECATED_FOR' 153 | __attribute__((deprecated("Use " #f " instead"))) | ^ The 2 remaining warnings are ares_set_servers / ares_set_servers_ports in setServers(), which IIUC would require a breaking change to address. N.B.: this is mostly vibe-coded
Open Graph Description: ../../src/cares_wrap.cc:227:16: warning: 'ares_parse_a_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 227 | status = ares_parse_a_reply(buf, | ...
X Description: ../../src/cares_wrap.cc:227:16: warning: 'ares_parse_a_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 227 | status = ares_parse_a_reply(buf, ...
Opengraph URL: https://github.com/nodejs/node/pull/64355
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:737f9924-1a6b-c059-be69-b2da7dd90337 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE7E:3865E3:62E916:807693:6AED2B8C |
| html-safe-nonce | 6f99979d59c36f55356ad1a5a9957ff9077bc0444c106ae9bceab39e4ae63f3e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTdFOjM4NjVFMzo2MkU5MTY6ODA3NjkzOjZBRUQyQjhDIiwidmlzaXRvcl9pZCI6IjI0MzIyMTIxMzI5NTA3ODA4MTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1240dd9a0c71beba66f0d11232feff8c00357bd0adc21291da359401b91fa164 |
| hovercard-subject-tag | pull_request:4013810181 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/64355/files |
| twitter:image | https://avatars.githubusercontent.com/u/14309773?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14309773?s=400&v=4 |
| og:image:alt | ../../src/cares_wrap.cc:227:16: warning: 'ares_parse_a_reply' is deprecated: Use ares_dns_parse instead [-Wdeprecated-declarations] 227 | status = ares_parse_a_reply(buf, | ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 98b41fa4b5635ceb45a4c54320fced73817ff290 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width