René's URL Explorer Experiment


Title: stream: prefer sync iterator in fromSync by trivikr · Pull Request #64294 · nodejs/node · GitHub

Open Graph Title: stream: prefer sync iterator in fromSync by trivikr · Pull Request #64294 · nodejs/node

X Title: stream: prefer sync iterator in fromSync by trivikr · Pull Request #64294 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64292 stream/iter's fromSync() rejected any input that exposed Symbol.asyncIterator, even when the same input also exposed Symbol.iterator. This updates fromSync() to reject only inputs...

X Description: Fixes: #64292 stream/iter's fromSync() rejected any input that exposed Symbol.asyncIterator, even when the same input also exposed Symbol.iterator. This updates fromSync() to reject only in...

Opengraph URL: https://github.com/nodejs/node/pull/64294

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4b18f54d-53da-af11-df5b-a0b86137a6fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBEE:70AED:2D95C18:3F43EF6:6A6334F8
html-safe-noncefb0133a2c1d06df4476c9b3f453d07536aab0db3d7e4254472e3572b008d726a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkVFOjcwQUVEOjJEOTVDMTg6M0Y0M0VGNjo2QTYzMzRGOCIsInZpc2l0b3JfaWQiOiI3MjQzMzQ1OTE4NTE1NDI2NTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7c6178c69928dfca944137777d404e985d793b2aed6b3ecef174b0214c159c31
hovercard-subject-tagpull_request:3992015600
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64294/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f554da779ea152fdcf3cab0e4a2c58232814f83c9e38d26b77376b908e9b8daa/nodejs/node/pull/64294
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f554da779ea152fdcf3cab0e4a2c58232814f83c9e38d26b77376b908e9b8daa/nodejs/node/pull/64294
og:image:altFixes: #64292 stream/iter's fromSync() rejected any input that exposed Symbol.asyncIterator, even when the same input also exposed Symbol.iterator. This updates fromSync() to reject only inputs...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonedf6e1c2adcceb061ec8c4106a1b34f38280f08e13f2b195c661c202834cbc3b1
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release822a0ff2a479845adcdd40a1a7b1734a56e05818
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64294#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64294
Reloadhttps://github.com/nodejs/node/pull/64294
Reloadhttps://github.com/nodejs/node/pull/64294
Please reload this pagehttps://github.com/nodejs/node/pull/64294
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64294
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-fromsync-iterhttps://github.com/trivikr/node/tree/stream-iter-fromsync-iter
Conversationhttps://github.com/nodejs/node/pull/64294
Commits1 (1)https://github.com/nodejs/node/pull/64294/commits
Checkshttps://github.com/nodejs/node/pull/64294/checks
Files changedhttps://github.com/nodejs/node/pull/64294/files
stream: prefer sync iterator in fromSynchttps://github.com/nodejs/node/pull/64294#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-fromsync-iterhttps://github.com/trivikr/node/tree/stream-iter-fromsync-iter
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 4, 2026https://github.com/nodejs/node/pull/64294#issue-4810807150
Please reload this pagehttps://github.com/nodejs/node/pull/64294
#64292https://github.com/nodejs/node/issues/64292
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 4, 2026https://github.com/nodejs/node/pull/64294#issuecomment-4884050746
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 4, 2026https://github.com/nodejs/node/pull/64294#event-27564445608
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 4, 2026https://github.com/nodejs/node/pull/64294#event-27564450065
https://github.com/aduh95
aduh95https://github.com/aduh95
Jul 5, 2026 https://github.com/nodejs/node/pull/64294#pullrequestreview-4631593578
View reviewed changes https://github.com/nodejs/node/pull/64294/files
lib/internal/streams/iter/from.jshttps://github.com/nodejs/node/pull/64294/files#diff-04ea7c07101e0a3e4d8a7a12e120bc878b35b91343555839acd90a6d5d00dca0
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 5, 2026 https://github.com/nodejs/node/pull/64294#pullrequestreview-4631728741
View reviewed changes https://github.com/nodejs/node/pull/64294/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/64294#pullrequestreview-4631728741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 5, 2026https://github.com/nodejs/node/pull/64294#event-27578111201
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/1e713e7bdf5eaa87500ccde6f932f2a2a4fa4e20..f21d60412c583b36dc8116711783e9f355e0b8d6
1e713e7https://github.com/nodejs/node/commit/1e713e7bdf5eaa87500ccde6f932f2a2a4fa4e20
f21d604https://github.com/nodejs/node/commit/f21d60412c583b36dc8116711783e9f355e0b8d6
Compare https://github.com/nodejs/node/compare/1e713e7bdf5eaa87500ccde6f932f2a2a4fa4e20..f21d60412c583b36dc8116711783e9f355e0b8d6
July 6, 2026 06:17https://github.com/nodejs/node/pull/64294#event-27591333273
https://github.com/trivikr
trivikrhttps://github.com/trivikr
aduh95https://github.com/aduh95
July 6, 2026 06:20https://github.com/nodejs/node/pull/64294#event-27591406631
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 6, 2026https://github.com/nodejs/node/pull/64294#event-27591412019
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 7, 2026 https://github.com/nodejs/node/pull/64294#pullrequestreview-4641403034
View reviewed changes https://github.com/nodejs/node/pull/64294/files/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 7, 2026https://github.com/nodejs/node/pull/64294#event-27644537327
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
https://github.com/trivikr
stream: prefer sync iterator in fromSynchttps://github.com/nodejs/node/pull/64294/commits/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
ce6448ehttps://github.com/nodejs/node/pull/64294/commits/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/f21d60412c583b36dc8116711783e9f355e0b8d6..ce6448ebccb5511ddd7e9d8c26fa097f243adc19
f21d604https://github.com/nodejs/node/commit/f21d60412c583b36dc8116711783e9f355e0b8d6
ce6448ehttps://github.com/nodejs/node/commit/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
Compare https://github.com/nodejs/node/compare/f21d60412c583b36dc8116711783e9f355e0b8d6..ce6448ebccb5511ddd7e9d8c26fa097f243adc19
July 8, 2026 00:38https://github.com/nodejs/node/pull/64294#event-27691569152
https://github.com/trivikr
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 8, 2026https://github.com/nodejs/node/pull/64294#event-27693663026
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 8, 2026 https://github.com/nodejs/node/pull/64294#pullrequestreview-4650423196
View reviewed changes https://github.com/nodejs/node/pull/64294/files/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 8, 2026https://github.com/nodejs/node/pull/64294#issuecomment-4910851638
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64294?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
4ee2117https://app.codecov.io/gh/nodejs/node/commit/4ee211788387ff955187cdfc6a5b86294644617e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ce6448ehttps://app.codecov.io/gh/nodejs/node/commit/ce6448ebccb5511ddd7e9d8c26fa097f243adc19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64294?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/from.jshttps://app.codecov.io/gh/nodejs/node/pull/64294?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Ffrom.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9mcm9tLmpz
30 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64294/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 8, 2026https://github.com/nodejs/node/pull/64294#event-27694899668
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 8, 2026https://github.com/nodejs/node/pull/64294#issuecomment-4910976677
https://ci.nodejs.org/job/node-test-pull-request/74648/https://ci.nodejs.org/job/node-test-pull-request/74648/
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 8, 2026https://github.com/nodejs/node/pull/64294#event-27695961969
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 8, 2026https://github.com/nodejs/node/pull/64294#event-27701768675
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
91b65a4https://github.com/nodejs/node/commit/91b65a4fe8a24f190d795fa04bec0f4e7eb40657
Jul 8, 2026https://github.com/nodejs/node/pull/64294#event-27701860434
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 8, 2026https://github.com/nodejs/node/pull/64294#issuecomment-4912251469
91b65a4https://github.com/nodejs/node/commit/91b65a4fe8a24f190d795fa04bec0f4e7eb40657
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/trivikr
trivikrhttps://github.com/trivikr
July 13, 2026 05:14https://github.com/nodejs/node/pull/64294#event-27890945456
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64294#ref-commit-fccb76b
https://github.com/trivikr
https://github.com/aduh95
stream: prefer sync iterator in fromSynchttps://github.com/nodejs/node/commit/fccb76b3ff28e2111f366f2747aa577791d0399c
fccb76bhttps://github.com/nodejs/node/commit/fccb76b3ff28e2111f366f2747aa577791d0399c
#64294https://github.com/nodejs/node/pull/64294
#64292https://github.com/nodejs/node/issues/64292
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64294#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64294
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/64294/files/1e713e7bdf5eaa87500ccde6f932f2a2a4fa4e20
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64294/files/ce6448ebccb5511ddd7e9d8c26fa097f243adc19
https://github.com/aduh95
aduh95 https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: fromSync() rejects dual sync/async iterables instead of using Symbol.iterator https://github.com/nodejs/node/issues/64292
Please reload this pagehttps://github.com/nodejs/node/pull/64294
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/jasnell
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.