René's URL Explorer Experiment


Title: stream: avoid draining merged iter sources by trivikr · Pull Request #64293 · nodejs/node · GitHub

Open Graph Title: stream: avoid draining merged iter sources by trivikr · Pull Request #64293 · nodejs/node

X Title: stream: avoid draining merged iter sources by trivikr · Pull Request #64293 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #63566 stream/iter merge() was scheduling the next read from a source as soon as that source produced a value. For fast sources, this could drain all inputs even while the merged consumer wa...

X Description: Fixes: #63566 stream/iter merge() was scheduling the next read from a source as soon as that source produced a value. For fast sources, this could drain all inputs even while the merged consumer wa...

Opengraph URL: https://github.com/nodejs/node/pull/64293

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:79e3459f-718d-0b86-2859-c2ac7abac13b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA74A:13EDA9:5B80C3:7C669E:6A62D958
html-safe-noncebbd1cf59822211634e850dbf039cd2e10f2242788e647a9683b0ab3f9cee488c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzRBOjEzRURBOTo1QjgwQzM6N0M2NjlFOjZBNjJEOTU4IiwidmlzaXRvcl9pZCI6IjQ4OTYzOTgxNDgxMzM2NDA1MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac115eb9be541f9dc228e9cb057f21c13e43fe73923414346890d1f8cc5e8f6336
hovercard-subject-tagpull_request:3992003547
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64293/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/80733c00888879c141ed28c20063367ad2f32949dc4d5813280fe149aca9160e/nodejs/node/pull/64293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/80733c00888879c141ed28c20063367ad2f32949dc4d5813280fe149aca9160e/nodejs/node/pull/64293
og:image:altFixes: #63566 stream/iter merge() was scheduling the next read from a source as soon as that source produced a value. For fast sources, this could drain all inputs even while the merged consumer wa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
Nonedf33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released41cd1bdb290013455c0ac430fa755621733f5eb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64293#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64293
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64293
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64293
Reloadhttps://github.com/nodejs/node/pull/64293
Reloadhttps://github.com/nodejs/node/pull/64293
Please reload this pagehttps://github.com/nodejs/node/pull/64293
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64293
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-merge-drain-consumer-idlehttps://github.com/trivikr/node/tree/stream-iter-merge-drain-consumer-idle
Conversationhttps://github.com/nodejs/node/pull/64293
Commits1 (1)https://github.com/nodejs/node/pull/64293/commits
Checkshttps://github.com/nodejs/node/pull/64293/checks
Files changedhttps://github.com/nodejs/node/pull/64293/files
stream: avoid draining merged iter sourceshttps://github.com/nodejs/node/pull/64293#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-merge-drain-consumer-idlehttps://github.com/trivikr/node/tree/stream-iter-merge-drain-consumer-idle
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 4, 2026https://github.com/nodejs/node/pull/64293#issue-4810792138
#63566https://github.com/nodejs/node/issues/63566
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 4, 2026https://github.com/nodejs/node/pull/64293#issuecomment-4884035521
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 4, 2026https://github.com/nodejs/node/pull/64293#event-27564377118
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 4, 2026https://github.com/nodejs/node/pull/64293#event-27564448807
https://github.com/trivikr
stream: avoid draining merged iter sourceshttps://github.com/nodejs/node/pull/64293/commits/0b25aaa8b5106b672521e1610183e31dcb66ec0a
0b25aaahttps://github.com/nodejs/node/pull/64293/commits/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/61b6bd2fb345aadd747888997d7636f6b6f4b5e8..0b25aaa8b5106b672521e1610183e31dcb66ec0a
61b6bd2https://github.com/nodejs/node/commit/61b6bd2fb345aadd747888997d7636f6b6f4b5e8
0b25aaahttps://github.com/nodejs/node/commit/0b25aaa8b5106b672521e1610183e31dcb66ec0a
Compare https://github.com/nodejs/node/compare/61b6bd2fb345aadd747888997d7636f6b6f4b5e8..0b25aaa8b5106b672521e1610183e31dcb66ec0a
July 8, 2026 16:05https://github.com/nodejs/node/pull/64293#event-27724896044
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 8, 2026https://github.com/nodejs/node/pull/64293#issuecomment-4917724967
Please reload this pagehttps://github.com/nodejs/node/pull/64293
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64293?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
799e910https://app.codecov.io/gh/nodejs/node/commit/799e91018163db31440d9504834428438e641f0e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0b25aaahttps://app.codecov.io/gh/nodejs/node/commit/0b25aaa8b5106b672521e1610183e31dcb66ec0a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/64293?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/consumers.jshttps://app.codecov.io/gh/nodejs/node/pull/64293?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fconsumers.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9jb25zdW1lcnMuanM=
26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64293/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 8, 2026 https://github.com/nodejs/node/pull/64293#pullrequestreview-4657076342
View reviewed changes https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 8, 2026https://github.com/nodejs/node/pull/64293#event-27732144446
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 8, 2026https://github.com/nodejs/node/pull/64293#issuecomment-4918342375
https://ci.nodejs.org/job/node-test-pull-request/74677/https://ci.nodejs.org/job/node-test-pull-request/74677/
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 8, 2026https://github.com/nodejs/node/pull/64293#event-27732410374
https://github.com/gurgunday
gurgundayhttps://github.com/gurgunday
Jul 8, 2026 https://github.com/nodejs/node/pull/64293#pullrequestreview-4657409943
View reviewed changes https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/efekrskl
efekrsklhttps://github.com/efekrskl
Jul 8, 2026 https://github.com/nodejs/node/pull/64293#pullrequestreview-4657574900
View reviewed changes https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 8, 2026https://github.com/nodejs/node/pull/64293#event-27738893560
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 8, 2026https://github.com/nodejs/node/pull/64293#event-27739584856
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
0032189https://github.com/nodejs/node/commit/0032189dbe7c1e9a8e65178d6d50bcb620d6b1d3
Jul 8, 2026https://github.com/nodejs/node/pull/64293#event-27739670961
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 8, 2026https://github.com/nodejs/node/pull/64293#issuecomment-4919951899
0032189https://github.com/nodejs/node/commit/0032189dbe7c1e9a8e65178d6d50bcb620d6b1d3
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/trivikr
trivikrhttps://github.com/trivikr
July 13, 2026 05:14https://github.com/nodejs/node/pull/64293#event-27890941265
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64293#ref-commit-e029e22
https://github.com/trivikr
https://github.com/aduh95
stream: avoid draining merged iter sourceshttps://github.com/nodejs/node/commit/e029e2247c4ea31b85525452ccc297267cd0842c
e029e22https://github.com/nodejs/node/commit/e029e2247c4ea31b85525452ccc297267cd0842c
#64293https://github.com/nodejs/node/pull/64293
#63566https://github.com/nodejs/node/issues/63566
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64293#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64293
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/gurgunday
gurgunday https://github.com/gurgunday
https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
https://github.com/efekrskl
efekrskl https://github.com/efekrskl
https://github.com/nodejs/node/pull/64293/files/0b25aaa8b5106b672521e1610183e31dcb66ec0a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: merge() proactively drains fast sources while merged consumer is idle https://github.com/nodejs/node/issues/63566
Please reload this pagehttps://github.com/nodejs/node/pull/64293
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/efekrskl
https://github.com/gurgunday
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.