René's URL Explorer Experiment


Title: doc,test: widen fsPromises.appendFile()'s data type, add missing tests by hkleungai · Pull Request #64279 · nodejs/node · GitHub

Open Graph Title: doc,test: widen fsPromises.appendFile()'s data type, add missing tests by hkleungai · Pull Request #64279 · nodejs/node

X Title: doc,test: widen fsPromises.appendFile()'s data type, add missing tests by hkleungai · Pull Request #64279 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: From lib/internal/fs/promises.js, one can see fsPromises.appendFile() is simply a wrapper on fsPromises.writeFile(). Hence if writeFile() can take non-buffer data argument, so can appendFile() too....

X Description: From lib/internal/fs/promises.js, one can see fsPromises.appendFile() is simply a wrapper on fsPromises.writeFile(). Hence if writeFile() can take non-buffer data argument, so can appendFile() too....

Mail addresses
mingfamily@hotmail.com.hk

Opengraph URL: https://github.com/nodejs/node/pull/64279

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:392f152f-daf3-f905-3f7d-736961e83881
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1C8:2FA691:837918:BB6C8F:6A633529
html-safe-noncea53db576efbefefbf132ecd7b9b988bb4e271b2bec3f8fe05230d6d2b5b9b8f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUM4OjJGQTY5MTo4Mzc5MTg6QkI2QzhGOjZBNjMzNTI5IiwidmlzaXRvcl9pZCI6Ijc3NTgxODQ4MTIyMjMwODM4MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3779d767deb1c9c772a619daf55a0e9d274609fa1964fc24feb6be368d859a68
hovercard-subject-tagpull_request:3989831232
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64279/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f465d2b32368f3a5645f51312beb84987967a715f2c6aa6a286184a1a3d056aa/nodejs/node/pull/64279
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f465d2b32368f3a5645f51312beb84987967a715f2c6aa6a286184a1a3d056aa/nodejs/node/pull/64279
og:image:altFrom lib/internal/fs/promises.js, one can see fsPromises.appendFile() is simply a wrapper on fsPromises.writeFile(). Hence if writeFile() can take non-buffer data argument, so can appendFile() too....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehkleungai
hostnamegithub.com
expected-hostnamegithub.com
Nonedf6e1c2adcceb061ec8c4106a1b34f38280f08e13f2b195c661c202834cbc3b1
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release822a0ff2a479845adcdd40a1a7b1734a56e05818
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64279#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64279
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64279
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64279
Reloadhttps://github.com/nodejs/node/pull/64279
Reloadhttps://github.com/nodejs/node/pull/64279
Please reload this pagehttps://github.com/nodejs/node/pull/64279
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/64279
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hkleungai:update-fsPromises-appendFile-data-type-and-testhttps://github.com/hkleungai/node/tree/update-fsPromises-appendFile-data-type-and-test
Conversationhttps://github.com/nodejs/node/pull/64279
Commits1 (1)https://github.com/nodejs/node/pull/64279/commits
Checkshttps://github.com/nodejs/node/pull/64279/checks
Files changedhttps://github.com/nodejs/node/pull/64279/files
doc,test: widen fsPromises.appendFile()'s data type, add missing testshttps://github.com/nodejs/node/pull/64279#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
hkleungai:update-fsPromises-appendFile-data-type-and-testhttps://github.com/hkleungai/node/tree/update-fsPromises-appendFile-data-type-and-test
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
Jul 4, 2026https://github.com/nodejs/node/pull/64279#issue-4808048723
#41677https://github.com/nodejs/node/pull/41677
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 4, 2026https://github.com/nodejs/node/pull/64279#event-27552102765
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
force-pushedhttps://github.com/nodejs/node/compare/0b04ed56326af5b395b68da9a74c8ccb254ac9de..62f79deb9e6a59013bfcb5e06973c8d53dca22f9
0b04ed5https://github.com/nodejs/node/commit/0b04ed56326af5b395b68da9a74c8ccb254ac9de
62f79dehttps://github.com/nodejs/node/commit/62f79deb9e6a59013bfcb5e06973c8d53dca22f9
Compare https://github.com/nodejs/node/compare/0b04ed56326af5b395b68da9a74c8ccb254ac9de..62f79deb9e6a59013bfcb5e06973c8d53dca22f9
July 4, 2026 07:13https://github.com/nodejs/node/pull/64279#event-27552177741
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
Jul 4, 2026https://github.com/nodejs/node/pull/64279#event-27552179734
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
Jul 4, 2026 https://github.com/nodejs/node/pull/64279#ref-pullrequest-4808220205
feat(node/fs/promises): update data type for appendFile() & writeFile() DefinitelyTyped/DefinitelyTyped#75205 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/75205
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 4, 2026 https://github.com/nodejs/node/pull/64279#pullrequestreview-4629857928
View reviewed changes https://github.com/nodejs/node/pull/64279/files
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Jul 6, 2026 https://github.com/nodejs/node/pull/64279#pullrequestreview-4639079725
View reviewed changes https://github.com/nodejs/node/pull/64279/files
doc/api/fs.mdhttps://github.com/nodejs/node/pull/64279/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2
Renegade334https://github.com/Renegade334
Jul 6, 2026https://github.com/nodejs/node/pull/64279#discussion_r3531526499
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/hkleungai
doc,test: widen fsPromises.appendFile()'s data type, add missing testshttps://github.com/nodejs/node/pull/64279/commits/275b8091cd2213522d002a0acd25edb66b3248ab
275b809https://github.com/nodejs/node/pull/64279/commits/275b8091cd2213522d002a0acd25edb66b3248ab
nodejs#41677https://github.com/nodejs/node/pull/41677
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
force-pushedhttps://github.com/nodejs/node/compare/62f79deb9e6a59013bfcb5e06973c8d53dca22f9..275b8091cd2213522d002a0acd25edb66b3248ab
62f79dehttps://github.com/nodejs/node/commit/62f79deb9e6a59013bfcb5e06973c8d53dca22f9
275b809https://github.com/nodejs/node/commit/275b8091cd2213522d002a0acd25edb66b3248ab
Compare https://github.com/nodejs/node/compare/62f79deb9e6a59013bfcb5e06973c8d53dca22f9..275b8091cd2213522d002a0acd25edb66b3248ab
July 9, 2026 14:24https://github.com/nodejs/node/pull/64279#event-27769681947
https://github.com/hkleungai
hkleungaihttps://github.com/hkleungai
Renegade334https://github.com/Renegade334
jasnellhttps://github.com/jasnell
July 9, 2026 14:25https://github.com/nodejs/node/pull/64279#event-27769695297
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 9, 2026https://github.com/nodejs/node/pull/64279#issuecomment-4927153481
Please reload this pagehttps://github.com/nodejs/node/pull/64279
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/64279?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8fec65dhttps://app.codecov.io/gh/nodejs/node/commit/8fec65d87731c86711bc930a78c612a4ae70b16b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
275b809https://app.codecov.io/gh/nodejs/node/commit/275b8091cd2213522d002a0acd25edb66b3248ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/64279/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Jul 9, 2026 https://github.com/nodejs/node/pull/64279#pullrequestreview-4665279619
View reviewed changes https://github.com/nodejs/node/pull/64279/files/275b8091cd2213522d002a0acd25edb66b3248ab
test/parallel/test-fs-promises-appendfile.jshttps://github.com/nodejs/node/pull/64279/files/275b8091cd2213522d002a0acd25edb66b3248ab#diff-e621c075405b09087c568296a2c8d42f5796ac29fc70640c6a2417cfbfb2f9f6
Renegade334https://github.com/Renegade334
Jul 9, 2026https://github.com/nodejs/node/pull/64279#discussion_r3553540981
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/main/test/parallel/test-aborted-util.jshttps://github.com/nodejs/node/blob/main/test/parallel/test-aborted-util.js
Please reload this pagehttps://github.com/nodejs/node/pull/64279
hkleungaihttps://github.com/hkleungai
Jul 9, 2026https://github.com/nodejs/node/pull/64279#discussion_r3553566191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Jul 9, 2026https://github.com/nodejs/node/pull/64279#event-27777926856
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 9, 2026https://github.com/nodejs/node/pull/64279#event-27778135305
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 9, 2026https://github.com/nodejs/node/pull/64279#issuecomment-4927963946
https://ci.nodejs.org/job/node-test-pull-request/74704/https://ci.nodejs.org/job/node-test-pull-request/74704/
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 14, 2026https://github.com/nodejs/node/pull/64279#event-27971124488
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 14, 2026https://github.com/nodejs/node/pull/64279#event-27971535535
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
3ac95f2https://github.com/nodejs/node/commit/3ac95f2d0ca18650a5a53ad9254ef01fd9673de2
Jul 14, 2026https://github.com/nodejs/node/pull/64279#event-27971659046
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2026https://github.com/nodejs/node/pull/64279#issuecomment-4971158449
3ac95f2https://github.com/nodejs/node/commit/3ac95f2d0ca18650a5a53ad9254ef01fd9673de2
Please reload this pagehttps://github.com/nodejs/node/pull/64279
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64279#ref-commit-95220f2
https://github.com/hkleungai
https://github.com/aduh95
doc,test: widen fsPromises.appendFile()'s data type, add missing testshttps://github.com/nodejs/node/commit/95220f2c49e954e869e60c5490657fb605cedb75
95220f2https://github.com/nodejs/node/commit/95220f2c49e954e869e60c5490657fb605cedb75
#41677https://github.com/nodejs/node/pull/41677
#64279https://github.com/nodejs/node/pull/64279
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2026 https://github.com/nodejs/node/pull/64279#ref-pullrequest-4940321437
2026-07-22, Version 26.6.0 (Current) #64655 https://github.com/nodejs/node/pull/64655
aduh95https://github.com/aduh95
Jul 21, 2026 https://github.com/nodejs/node/pull/64279#ref-commit-6fc05e3
https://github.com/hkleungai
https://github.com/aduh95
doc,test: widen fsPromises.appendFile()'s data type, add missing testshttps://github.com/nodejs/node/commit/6fc05e3d21c10e5294265de2c97443fb36fdd00f
6fc05e3https://github.com/nodejs/node/commit/6fc05e3d21c10e5294265de2c97443fb36fdd00f
#41677https://github.com/nodejs/node/pull/41677
#64279https://github.com/nodejs/node/pull/64279
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64279
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/64279/files/275b8091cd2213522d002a0acd25edb66b3248ab
https://github.com/jasnell
jasnell https://github.com/jasnell
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/64279
https://github.com/hkleungai
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Renegade334
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.