René's URL Explorer Experiment


Title: fs: remove FileHandle stream close listener by ishaanlabs-gg · Pull Request #64229 · nodejs/node · GitHub

Open Graph Title: fs: remove FileHandle stream close listener by ishaanlabs-gg · Pull Request #64229 · nodejs/node

X Title: fs: remove FileHandle stream close listener by ishaanlabs-gg · Pull Request #64229 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #64214 This removes the extra FileHandle close listener that can be left behind by streams created with autoClose: false. The listener still lets the stream close if the FileHandle is closed...

X Description: Fixes: #64214 This removes the extra FileHandle close listener that can be left behind by streams created with autoClose: false. The listener still lets the stream close if the FileHandle is closed...

Opengraph URL: https://github.com/nodejs/node/pull/64229

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2e2272cd-7f87-9084-c987-1b2ca2e64186
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8BC:1A4188:54EAD0:716319:6AED19C8
html-safe-nonce660888cf5212bef94a50d59d212e01696ae563f4fb78ae2842398abab4c70261
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEJDOjFBNDE4ODo1NEVBRDA6NzE2MzE5OjZBRUQxOUM4IiwidmlzaXRvcl9pZCI6IjkxMzY3Mjg0MjIxNDA5NDI3OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5a4e46bbd1d10de98fbc9110ec97e76742cf22b42407d0715d1fbc5ef1dbd87a
hovercard-subject-tagpull_request:3970199470
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/64229/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7142c799d83313bc15fee3562c47e1a89cf368e67a52d1ad87130cd88f0c5165/nodejs/node/pull/64229
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7142c799d83313bc15fee3562c47e1a89cf368e67a52d1ad87130cd88f0c5165/nodejs/node/pull/64229
og:image:altFixes: #64214 This removes the extra FileHandle close listener that can be left behind by streams created with autoClose: false. The listener still lets the stream close if the FileHandle is closed...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameishaanlabs-gg
hostnamegithub.com
expected-hostnamegithub.com
None120085d0bcec1f427e3ab45302c8b95f873d26ad21984dc86d62ab2c10158f41
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee12fd03aa775dceadc5a793c3a0791e43ca256bb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/64229#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64229
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64229
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/64229
Reloadhttps://github.com/nodejs/node/pull/64229
Reloadhttps://github.com/nodejs/node/pull/64229
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues655 (655)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
ishaanlabs-gghttps://github.com/ishaanlabs-gg
nodejs:mainhttps://github.com/nodejs/node/tree/main
ishaanlabs-gg:fix-filehandle-readstream-listener-leakhttps://github.com/ishaanlabs-gg/node/tree/fix-filehandle-readstream-listener-leak
Conversationhttps://github.com/nodejs/node/pull/64229
Commits3 (3)https://github.com/nodejs/node/pull/64229/commits
Checkshttps://github.com/nodejs/node/pull/64229/checks
Files changedhttps://github.com/nodejs/node/pull/64229/files
fs: remove FileHandle stream close listenerhttps://github.com/nodejs/node/pull/64229#top
ishaanlabs-gghttps://github.com/ishaanlabs-gg
nodejs:mainhttps://github.com/nodejs/node/tree/main
ishaanlabs-gg:fix-filehandle-readstream-listener-leakhttps://github.com/ishaanlabs-gg/node/tree/fix-filehandle-readstream-listener-leak
https://github.com/ishaanlabs-gg
ishaanlabs-gghttps://github.com/ishaanlabs-gg
Jul 1, 2026https://github.com/nodejs/node/pull/64229#issue-4784985651
#64214https://github.com/nodejs/node/issues/64214
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jul 1, 2026https://github.com/nodejs/node/pull/64229#event-27424946747
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 1, 2026 https://github.com/nodejs/node/pull/64229#pullrequestreview-4609283196
View reviewed changes https://github.com/nodejs/node/pull/64229/files
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/64229#pullrequestreview-4609283196
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 1, 2026 https://github.com/nodejs/node/pull/64229#pullrequestreview-4609296651
View reviewed changes https://github.com/nodejs/node/pull/64229/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/64229/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
mcollinahttps://github.com/mcollina
Jul 1, 2026https://github.com/nodejs/node/pull/64229#discussion_r3506169936
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/ishaanlabs-gg
ishaanlabs-gghttps://github.com/ishaanlabs-gg
force-pushedhttps://github.com/nodejs/node/compare/98b30c4975df81eb631f618dfe5a6ff34a9f54e5..59c7463f1bd2c08f7565ffca4fe0ac54630ee02f
98b30c4https://github.com/nodejs/node/commit/98b30c4975df81eb631f618dfe5a6ff34a9f54e5
59c7463https://github.com/nodejs/node/commit/59c7463f1bd2c08f7565ffca4fe0ac54630ee02f
Compare https://github.com/nodejs/node/compare/98b30c4975df81eb631f618dfe5a6ff34a9f54e5..59c7463f1bd2c08f7565ffca4fe0ac54630ee02f
July 1, 2026 14:11https://github.com/nodejs/node/pull/64229#event-27432999906
https://github.com/ishaanlabs-gg
ishaanlabs-gghttps://github.com/ishaanlabs-gg
Jul 1, 2026https://github.com/nodejs/node/pull/64229#issuecomment-4856025707
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/davidje13
davidje13https://github.com/davidje13
Jul 1, 2026 https://github.com/nodejs/node/pull/64229#pullrequestreview-4610123719
View reviewed changes https://github.com/nodejs/node/pull/64229/files
lib/internal/fs/streams.jshttps://github.com/nodejs/node/pull/64229/files#diff-ae08fbeb399934340e8c17e06303e19de6caa7fc1ce2d9ed8db7c7c88d4c4b3b
davidje13https://github.com/davidje13
Jul 1, 2026https://github.com/nodejs/node/pull/64229#discussion_r3506843610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/64229
ishaanlabs-gghttps://github.com/ishaanlabs-gg
July 2, 2026 16:02https://github.com/nodejs/node/pull/64229#commits-pushed-8d1e9bd
https://github.com/ishaanlabs-gg
fs: remove FileHandle stream close listenerhttps://github.com/nodejs/node/pull/64229/commits/8d1e9bda31672100ae000f8714c4637166950c6e
8d1e9bdhttps://github.com/nodejs/node/pull/64229/commits/8d1e9bda31672100ae000f8714c4637166950c6e
https://github.com/ishaanlabs-gg
fs: avoid redundant FileHandle stream close listenerhttps://github.com/nodejs/node/pull/64229/commits/442374e06164ab28cba8675eec7e4459ff8b6dc4
442374ehttps://github.com/nodejs/node/pull/64229/commits/442374e06164ab28cba8675eec7e4459ff8b6dc4
https://github.com/ishaanlabs-gg
fs: remove redundant FileHandle close listenerhttps://github.com/nodejs/node/pull/64229/commits/610d021c884aacc0924c3d8c63c859e8154e704a
610d021https://github.com/nodejs/node/pull/64229/commits/610d021c884aacc0924c3d8c63c859e8154e704a
https://github.com/ishaanlabs-gg
ishaanlabs-gghttps://github.com/ishaanlabs-gg
force-pushedhttps://github.com/nodejs/node/compare/968e2ad884d8a696086248859c4a53e6656c1738..610d021c884aacc0924c3d8c63c859e8154e704a
968e2adhttps://github.com/nodejs/node/commit/968e2ad884d8a696086248859c4a53e6656c1738
610d021https://github.com/nodejs/node/commit/610d021c884aacc0924c3d8c63c859e8154e704a
Compare https://github.com/nodejs/node/compare/968e2ad884d8a696086248859c4a53e6656c1738..610d021c884aacc0924c3d8c63c859e8154e704a
July 2, 2026 10:32https://github.com/nodejs/node/pull/64229#event-27473814299
https://github.com/ishaanlabs-gg
ishaanlabs-gghttps://github.com/ishaanlabs-gg
Jul 2, 2026https://github.com/nodejs/node/pull/64229#issuecomment-4864761958
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Aug 17, 2026https://github.com/nodejs/node/pull/64229#issuecomment-5320283990
#64214https://github.com/nodejs/node/issues/64214
#64227https://github.com/nodejs/node/pull/64227
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/MikeMcC399
MikeMcC399https://github.com/MikeMcC399
Aug 17, 2026https://github.com/nodejs/node/pull/64229#event-29582292732
rasadregmihttps://github.com/rasadregmi
Sep 17, 2026 https://github.com/nodejs/node/pull/64229#ref-commit-5397a5b
https://github.com/rasadregmi
ut only released either when thehttps://github.com/rasadregmi/node/commit/5397a5b5a3d93b9bde7c26eaf107226d2ff14cb9
5397a5bhttps://github.com/rasadregmi/node/commit/5397a5b5a3d93b9bde7c26eaf107226d2ff14cb9
nodejs#64227https://github.com/nodejs/node/pull/64227
nodejs#64214https://github.com/nodejs/node/issues/64214
nodejs#64227https://github.com/nodejs/node/pull/64227
nodejs#65387https://github.com/nodejs/node/pull/65387
nodejs#64229https://github.com/nodejs/node/pull/64229
nodejs#64214https://github.com/nodejs/node/issues/64214
nodejs#64227https://github.com/nodejs/node/pull/64227
nodejs#65387https://github.com/nodejs/node/pull/65387
nodejs#64229https://github.com/nodejs/node/pull/64229
rasadregmihttps://github.com/rasadregmi
Sep 17, 2026 https://github.com/nodejs/node/pull/64229#ref-commit-456d8c4
https://github.com/rasadregmi
fs: fix FileHandle close listener/ref leak in streamshttps://github.com/rasadregmi/node/commit/456d8c4e25fd0dbb10edf3269406118d5a9a2e58
456d8c4https://github.com/rasadregmi/node/commit/456d8c4e25fd0dbb10edf3269406118d5a9a2e58
nodejs#64214https://github.com/nodejs/node/issues/64214
nodejs#64227https://github.com/nodejs/node/pull/64227
nodejs#65387https://github.com/nodejs/node/pull/65387
nodejs#64229https://github.com/nodejs/node/pull/64229
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F64229
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/64229/files/f937b9a639494f2bf43a13ea7d2715e93b3f9a55
https://github.com/davidje13
davidje13 https://github.com/davidje13
https://github.com/nodejs/node/pull/64229/files/59c7463f1bd2c08f7565ffca4fe0ac54630ee02f
Please reload this pagehttps://github.com/nodejs/node/pull/64229
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Close listener leak in fs/promises createReadStream https://github.com/nodejs/node/issues/64214
Please reload this pagehttps://github.com/nodejs/node/pull/64229
https://github.com/ishaanlabs-gg
https://github.com/MikeMcC399
https://github.com/mcollina
https://github.com/davidje13
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.