Title: dgram: skip dns.lookup() for literal IP addresses by BridgeAR · Pull Request #64133 · nodejs/node · GitHub
Open Graph Title: dgram: skip dns.lookup() for literal IP addresses by BridgeAR · Pull Request #64133 · nodejs/node
X Title: dgram: skip dns.lookup() for literal IP addresses by BridgeAR · Pull Request #64133 · nodejs/node
Description: dgram resolved the destination through dns.lookup() on every unconnected send() and on the implicit first-send bind, even when the destination was already a literal IP. The address resolves to itself, so the call is redundant, and tools that instrument dns.lookup() record a lookup for every datagram sent to an IP. Skip the default dns.lookup() for a literal IP of the socket's family and report it on the next tick, keeping dns.lookup()'s asynchronous contract. A custom lookup function is still consulted. Refs: DataDog/dd-trace-js#2984
Open Graph Description: dgram resolved the destination through dns.lookup() on every unconnected send() and on the implicit first-send bind, even when the destination was already a literal IP. The address resolves to itse...
X Description: dgram resolved the destination through dns.lookup() on every unconnected send() and on the implicit first-send bind, even when the destination was already a literal IP. The address resolves to itse...
Opengraph URL: https://github.com/nodejs/node/pull/64133
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:589e2e4d-a02c-3c06-2acd-8ee10987bcb6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2EE:20FA41:373EDB3:4958D0B:6A655ACF |
| html-safe-nonce | 5c6ff9e083954a8c31c58a4932b0c149dca1c9beca9834cf4cba0397df0696f2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkVFOjIwRkE0MTozNzNFREIzOjQ5NThEMEI6NkE2NTVBQ0YiLCJ2aXNpdG9yX2lkIjoiMTYzMzYzMzQ4MzMxODcxMzAzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9b1f8b3743732c954d4158f8ccb2f818cb691c1f30f074dd5096ac36e745a839 |
| hovercard-subject-tag | pull_request:3936335503 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/64133/files/5d63356c6b40ccda396a60438da38b86602fba5c |
| twitter:image | https://avatars.githubusercontent.com/u/8822573?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8822573?s=400&v=4 |
| og:image:alt | dgram resolved the destination through dns.lookup() on every unconnected send() and on the implicit first-send bind, even when the destination was already a literal IP. The address resolves to itse... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width