René's URL Explorer Experiment


Title: src: omit unconvertible names in cjs_lexer::Parse by anonrig · Pull Request #63943 · nodejs/node · GitHub

Open Graph Title: src: omit unconvertible names in cjs_lexer::Parse by anonrig · Pull Request #63943 · nodejs/node

X Title: src: omit unconvertible names in cjs_lexer::Parse by anonrig · Pull Request #63943 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Follow-up to #63885 (aa25a0a30c3). That change made CreateString() return a MaybeLocal<String> and bailed out of Parse() (early return) when an export / re-export name could not be converted ...

X Description: Follow-up to #63885 (aa25a0a30c3). That change made CreateString() return a MaybeLocal&lt;String&gt; and bailed out of Parse() (early return) when an export / re-export name could not be co...

Opengraph URL: https://github.com/nodejs/node/pull/63943

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8671d35d-b4e0-133d-51fb-ccf52398afb2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84B4:13B1D:12A040F:19E9B94:6A4CA9C0
html-safe-nonce775e1ecfde5ebe63a96e0712f926c8c269291a52ede57a86c170f088a1868c27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEI0OjEzQjFEOjEyQTA0MEY6MTlFOUI5NDo2QTRDQTlDMCIsInZpc2l0b3JfaWQiOiIzMjE1OTMxODQ5MjgxNjc3NzYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5ccc65d657b7f58d6b0157361c5432b1122a4b267e4cd46c9b983f985833576c
hovercard-subject-tagpull_request:3876215450
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63943/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/49692c6a97c698f6e0416332edfa679fa906dfe4c8c14a09f441fddc2d06d440/nodejs/node/pull/63943
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/49692c6a97c698f6e0416332edfa679fa906dfe4c8c14a09f441fddc2d06d440/nodejs/node/pull/63943
og:image:altFollow-up to #63885 (aa25a0a30c3). That change made CreateString() return a MaybeLocal<String> and bailed out of Parse() (early return) when an export / re-export name could not be converted ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseae90d426644ca15e89bacceb72e51f4e9dbf85f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63943#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63943
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63943
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63943
Reloadhttps://github.com/nodejs/node/pull/63943
Reloadhttps://github.com/nodejs/node/pull/63943
Please reload this pagehttps://github.com/nodejs/node/pull/63943
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63943
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:cjs-lexer-omit-followuphttps://github.com/anonrig/node/tree/cjs-lexer-omit-followup
Conversationhttps://github.com/nodejs/node/pull/63943
Commits2 (2)https://github.com/nodejs/node/pull/63943/commits
Checkshttps://github.com/nodejs/node/pull/63943/checks
Files changedhttps://github.com/nodejs/node/pull/63943/files
src: omit unconvertible names in cjs_lexer::Parsehttps://github.com/nodejs/node/pull/63943#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:cjs-lexer-omit-followuphttps://github.com/anonrig/node/tree/cjs-lexer-omit-followup
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jun 16, 2026https://github.com/nodejs/node/pull/63943#issue-4674894155
#63885https://github.com/nodejs/node/pull/63885
aa25a0a30c3https://github.com/nodejs/node/commit/aa25a0a30c3c1008522b29f8a4467ee912d65e5e
#63885https://github.com/nodejs/node/pull/63885
#63323https://github.com/nodejs/node/issues/63323
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/anonrig
src: omit unconvertible names in cjs_lexer::Parsehttps://github.com/nodejs/node/pull/63943/commits/53cc25a0d7bf13961690dc5146aad4df39c4b010
53cc25ahttps://github.com/nodejs/node/pull/63943/commits/53cc25a0d7bf13961690dc5146aad4df39c4b010
aa25a0ahttps://github.com/anonrig/node/commit/aa25a0a30c3c1008522b29f8a4467ee912d65e5e
nodejs#63885https://github.com/nodejs/node/pull/63885
nodejs#63323https://github.com/nodejs/node/issues/63323
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 16, 2026https://github.com/nodejs/node/pull/63943#event-26812192224
https://github.com/watilde
watildehttps://github.com/watilde
Jun 16, 2026 https://github.com/nodejs/node/pull/63943#pullrequestreview-4507405489
View reviewed changes https://github.com/nodejs/node/pull/63943/files/53cc25a0d7bf13961690dc5146aad4df39c4b010
https://github.com/anonrig
anonrighttps://github.com/anonrig
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 16, 2026https://github.com/nodejs/node/pull/63943#event-26814375129
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 16, 2026https://github.com/nodejs/node/pull/63943#event-26817512043
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 16, 2026https://github.com/nodejs/node/pull/63943#issuecomment-4720691039
https://ci.nodejs.org/job/node-test-pull-request/74186/https://ci.nodejs.org/job/node-test-pull-request/74186/
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/anonrig
anonrighttps://github.com/anonrig
mcollinahttps://github.com/mcollina
panvahttps://github.com/panva
June 16, 2026 17:43https://github.com/nodejs/node/pull/63943#event-26821866857
https://github.com/panva
panvahttps://github.com/panva
Jun 17, 2026 https://github.com/nodejs/node/pull/63943#pullrequestreview-4516242395
View reviewed changes https://github.com/nodejs/node/pull/63943/files/53cc25a0d7bf13961690dc5146aad4df39c4b010
src/node_cjs_lexer.cchttps://github.com/nodejs/node/pull/63943/files/53cc25a0d7bf13961690dc5146aad4df39c4b010#diff-6c0cd7ce3241cb3068864118334aac79f71cb01452d98429906b0dfb45fcde37
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/anonrig
https://github.com/panva
Update src/node_cjs_lexer.cchttps://github.com/nodejs/node/pull/63943/commits/52797350ffc37111c41fbb8ac8ba5dd3861ee010
5279735https://github.com/nodejs/node/pull/63943/commits/52797350ffc37111c41fbb8ac8ba5dd3861ee010
https://github.com/anonrig
anonrighttps://github.com/anonrig
panvahttps://github.com/panva
June 17, 2026 15:24https://github.com/nodejs/node/pull/63943#event-26868454392
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Jun 17, 2026https://github.com/nodejs/node/pull/63943#event-26868460699
https://github.com/panva
panvahttps://github.com/panva
Jun 17, 2026 https://github.com/nodejs/node/pull/63943#pullrequestreview-4517189741
View reviewed changes https://github.com/nodejs/node/pull/63943/files/52797350ffc37111c41fbb8ac8ba5dd3861ee010
https://github.com/anonrig
anonrighttps://github.com/anonrig
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 17, 2026https://github.com/nodejs/node/pull/63943#event-26869095394
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 17, 2026https://github.com/nodejs/node/pull/63943#event-26871814801
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 17, 2026https://github.com/nodejs/node/pull/63943#issuecomment-4732963859
https://ci.nodejs.org/job/node-test-pull-request/74212/https://ci.nodejs.org/job/node-test-pull-request/74212/
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 19, 2026https://github.com/nodejs/node/pull/63943#issuecomment-4754070114
https://ci.nodejs.org/job/node-test-pull-request/74275/https://ci.nodejs.org/job/node-test-pull-request/74275/
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/anonrig
anonrighttps://github.com/anonrig
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 20, 2026https://github.com/nodejs/node/pull/63943#event-26996784991
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 20, 2026https://github.com/nodejs/node/pull/63943#event-26997423413
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
7bdd50bhttps://github.com/nodejs/node/commit/7bdd50bc0fcd21cdea91ac0e1c203ea722cfe354
Jun 20, 2026https://github.com/nodejs/node/pull/63943#event-26997480656
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 20, 2026https://github.com/nodejs/node/pull/63943#issuecomment-4759696219
7bdd50bhttps://github.com/nodejs/node/commit/7bdd50bc0fcd21cdea91ac0e1c203ea722cfe354
Please reload this pagehttps://github.com/nodejs/node/pull/63943
aduh95https://github.com/aduh95
Jun 20, 2026 https://github.com/nodejs/node/pull/63943#ref-commit-10f03e5
https://github.com/anonrig
https://github.com/aduh95
src: omit unconvertible names in cjs_lexer::Parsehttps://github.com/nodejs/node/commit/10f03e5958ef4a37cd86786037531826a74f3772
10f03e5https://github.com/nodejs/node/commit/10f03e5958ef4a37cd86786037531826a74f3772
aa25a0ahttps://github.com/nodejs/node/commit/aa25a0a30c3c1008522b29f8a4467ee912d65e5e
#63885https://github.com/nodejs/node/pull/63885
#63323https://github.com/nodejs/node/issues/63323
#63943https://github.com/nodejs/node/pull/63943
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63943#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
luanmunizhttps://github.com/luanmuniz
Jun 25, 2026 https://github.com/nodejs/node/pull/63943#ref-commit-5106385
https://github.com/anonrig
https://github.com/luanmuniz
src: omit unconvertible names in cjs_lexer::Parsehttps://github.com/luanmuniz/node/commit/51063851a0cf3ddafc467426c231256b46795db5
5106385https://github.com/luanmuniz/node/commit/51063851a0cf3ddafc467426c231256b46795db5
aa25a0ahttps://github.com/luanmuniz/node/commit/aa25a0a30c3c1008522b29f8a4467ee912d65e5e
nodejs#63885https://github.com/nodejs/node/pull/63885
nodejs#63323https://github.com/nodejs/node/issues/63323
nodejs#63943https://github.com/nodejs/node/pull/63943
aduh95https://github.com/aduh95
Jun 25, 2026 https://github.com/nodejs/node/pull/63943#ref-commit-1d1a925
https://github.com/anonrig
https://github.com/aduh95
src: omit unconvertible names in cjs_lexer::Parsehttps://github.com/nodejs/node/commit/1d1a925a84fdb7abc61a4b5f86a6cfb606e5d161
1d1a925https://github.com/nodejs/node/commit/1d1a925a84fdb7abc61a4b5f86a6cfb606e5d161
aa25a0ahttps://github.com/nodejs/node/commit/aa25a0a30c3c1008522b29f8a4467ee912d65e5e
#63885https://github.com/nodejs/node/pull/63885
#63323https://github.com/nodejs/node/issues/63323
#63943https://github.com/nodejs/node/pull/63943
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63943
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/63943/files/52797350ffc37111c41fbb8ac8ba5dd3861ee010
https://github.com/watilde
watilde https://github.com/watilde
https://github.com/nodejs/node/pull/63943/files/53cc25a0d7bf13961690dc5146aad4df39c4b010
https://github.com/mcollina
mcollina https://github.com/mcollina
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63943
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/watilde
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.