René's URL Explorer Experiment


Title: module: avoid allocating a cache key string for every require() by MarshallOfSound · Pull Request #63884 · nodejs/node · GitHub

Open Graph Title: module: avoid allocating a cache key string for every require() by MarshallOfSound · Pull Request #63884 · nodejs/node

X Title: module: avoid allocating a cache key string for every require() by MarshallOfSound · Pull Request #63884 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Description of Change Every require() call — including fully cached ones — allocates a fresh `${parent.path}\x00${request}` string to key the relative-resolve fast path in Module._load. On cache hi...

X Description: Description of Change Every require() call — including fully cached ones — allocates a fresh `${parent.path}\x00${request}` string to key the relative-resolve fast path in Module._load. On cache hi...

Opengraph URL: https://github.com/nodejs/node/pull/63884

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1afac3b2-2f3f-a949-6ec4-c897d1ca5f34
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E38:436FA:483896:64CD38:6AED00C8
html-safe-nonce7f64ed71dbe7e7c2cf3f0a2d440e680784189c218e2536313cdbfd0316d7c7d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTM4OjQzNkZBOjQ4Mzg5Njo2NENEMzg6NkFFRDAwQzgiLCJ2aXNpdG9yX2lkIjoiNDQ2Mjc4Njg2MTM0Nzk2MzA4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace618c395cfe057cfa5c615ebe48173a8a9a5c7e8d86c46972fc572aedfd43dd0
hovercard-subject-tagpull_request:3856664648
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63884/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6d952c18474549ce7ffc99b82464de7ce153737e7b41d74131d4276f5b75dde7/nodejs/node/pull/63884
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6d952c18474549ce7ffc99b82464de7ce153737e7b41d74131d4276f5b75dde7/nodejs/node/pull/63884
og:image:altDescription of Change Every require() call — including fully cached ones — allocates a fresh `${parent.path}\x00${request}` string to key the relative-resolve fast path in Module._load. On cache hi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMarshallOfSound
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63884#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63884
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63884
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63884
Reloadhttps://github.com/nodejs/node/pull/63884
Reloadhttps://github.com/nodejs/node/pull/63884
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
MarshallOfSound:perf/cache-onlyhttps://github.com/MarshallOfSound/node/tree/perf/cache-only
Conversationhttps://github.com/nodejs/node/pull/63884
Commits2 (2)https://github.com/nodejs/node/pull/63884/commits
Checkshttps://github.com/nodejs/node/pull/63884/checks
Files changedhttps://github.com/nodejs/node/pull/63884/files
module: avoid allocating a cache key string for every require()https://github.com/nodejs/node/pull/63884#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
MarshallOfSound:perf/cache-onlyhttps://github.com/MarshallOfSound/node/tree/perf/cache-only
https://github.com/MarshallOfSound
MarshallOfSoundhttps://github.com/MarshallOfSound
Jun 12, 2026https://github.com/nodejs/node/pull/63884#issue-4651581386
https://gist.github.com/MarshallOfSound/ad35b07ad5ebf9c5fec8e4daa4ec04b4https://gist.github.com/MarshallOfSound/ad35b07ad5ebf9c5fec8e4daa4ec04b4
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 12, 2026https://github.com/nodejs/node/pull/63884#issuecomment-4694032872
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 12, 2026https://github.com/nodejs/node/pull/63884#event-26688681749
https://github.com/MarshallOfSound
module: avoid allocating a cache key string for every require()https://github.com/nodejs/node/pull/63884/commits/96860f39728edd36d5efa8483744386196f555f3
96860f3https://github.com/nodejs/node/pull/63884/commits/96860f39728edd36d5efa8483744386196f555f3
https://github.com/MarshallOfSound
MarshallOfSoundhttps://github.com/MarshallOfSound
force-pushedhttps://github.com/nodejs/node/compare/147ca9421a64caeec5d8ff7f17eb39e4dd5b8492..96860f39728edd36d5efa8483744386196f555f3
147ca94https://github.com/nodejs/node/commit/147ca9421a64caeec5d8ff7f17eb39e4dd5b8492
96860f3https://github.com/nodejs/node/commit/96860f39728edd36d5efa8483744386196f555f3
Compare https://github.com/nodejs/node/compare/147ca9421a64caeec5d8ff7f17eb39e4dd5b8492..96860f39728edd36d5efa8483744386196f555f3
June 12, 2026 18:17https://github.com/nodejs/node/pull/63884#event-26688740709
https://github.com/MarshallOfSound
MarshallOfSoundhttps://github.com/MarshallOfSound
June 12, 2026 18:23https://github.com/nodejs/node/pull/63884#event-26688919319
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 12, 2026 https://github.com/nodejs/node/pull/63884#pullrequestreview-4489161961
View reviewed changes https://github.com/nodejs/node/pull/63884/files/96860f39728edd36d5efa8483744386196f555f3
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63884#pullrequestreview-4489161961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Aug 23, 2026 https://github.com/nodejs/node/pull/63884#pullrequestreview-5001695253
View reviewed changes https://github.com/nodejs/node/pull/63884/files/96860f39728edd36d5efa8483744386196f555f3
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/63884/files/96860f39728edd36d5efa8483744386196f555f3#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/63884
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/63884/files/96860f39728edd36d5efa8483744386196f555f3#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/MarshallOfSound
module: create relative resolve cache bucket lazilyhttps://github.com/nodejs/node/pull/63884/commits/a50d67a804e6dfa295ac47b7dd81c7375ef295b7
a50d67ahttps://github.com/nodejs/node/pull/63884/commits/a50d67a804e6dfa295ac47b7dd81c7375ef295b7
https://github.com/MarshallOfSound
MarshallOfSoundhttps://github.com/MarshallOfSound
trivikrhttps://github.com/trivikr
September 25, 2026 00:21https://github.com/nodejs/node/pull/63884#event-31799995137
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Sep 25, 2026https://github.com/nodejs/node/pull/63884#issuecomment-5825489612
Please reload this pagehttps://github.com/nodejs/node/pull/63884
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63884?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
141a504https://app.codecov.io/gh/nodejs/node/commit/141a504680555848f9d5378f1c08f9047701954d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a50d67ahttps://app.codecov.io/gh/nodejs/node/commit/a50d67a804e6dfa295ac47b7dd81c7375ef295b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63884?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/modules/cjs/loader.jshttps://app.codecov.io/gh/nodejs/node/pull/63884?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fcjs%2Floader.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvY2pzL2xvYWRlci5qcw==
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63884?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63884?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/modules/cjs/loader.jshttps://app.codecov.io/gh/nodejs/node/pull/63884?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fcjs%2Floader.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvY2pzL2xvYWRlci5qcw==
667 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63884/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Sep 28, 2026 https://github.com/nodejs/node/pull/63884#pullrequestreview-5343558695
View reviewed changes https://github.com/nodejs/node/pull/63884/files/a50d67a804e6dfa295ac47b7dd81c7375ef295b7
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Sep 28, 2026https://github.com/nodejs/node/pull/63884#event-32021650667
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 28, 2026https://github.com/nodejs/node/pull/63884#event-32022207772
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2026https://github.com/nodejs/node/pull/63884#issuecomment-5877026126
https://ci.nodejs.org/job/node-test-pull-request/78059/https://ci.nodejs.org/job/node-test-pull-request/78059/
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 28, 2026https://github.com/nodejs/node/pull/63884#event-32036421018
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
471fe81https://github.com/nodejs/node/commit/471fe813bb38c687a1bde205d98f7750c23a664e
Sep 28, 2026https://github.com/nodejs/node/pull/63884#event-32036617219
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 28, 2026https://github.com/nodejs/node/pull/63884#issuecomment-5880645385
471fe81https://github.com/nodejs/node/commit/471fe813bb38c687a1bde205d98f7750c23a664e
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 28, 2026https://github.com/nodejs/node/pull/63884#event-32036620668
HoonDongKanghttps://github.com/HoonDongKang
Sep 29, 2026 https://github.com/nodejs/node/pull/63884#ref-commit-b209773
https://github.com/MarshallOfSound
https://github.com/HoonDongKang
module: avoid allocating a cache key string for every require()https://github.com/HoonDongKang/node/commit/b209773cdd4e80d5b6efd412faf6135eb92f3291
b209773https://github.com/HoonDongKang/node/commit/b209773cdd4e80d5b6efd412faf6135eb92f3291
nodejs#63884https://github.com/nodejs/node/pull/63884
aduh95https://github.com/aduh95
Oct 3, 2026 https://github.com/nodejs/node/pull/63884#ref-commit-f36efeb
https://github.com/MarshallOfSound
https://github.com/aduh95
module: avoid allocating a cache key string for every require()https://github.com/nodejs/node/commit/f36efeb350250efe2b1d5ea6c1ef543b4f11c316
f36efebhttps://github.com/nodejs/node/commit/f36efeb350250efe2b1d5ea6c1ef543b4f11c316
#63884https://github.com/nodejs/node/pull/63884
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Oct 5, 2026 https://github.com/nodejs/node/pull/63884#ref-pullrequest-5720654094
2026-10-07, Version 26.11.0 (Current) #66546 https://github.com/nodejs/node/pull/66546
aduh95https://github.com/aduh95
Oct 23, 2026 https://github.com/nodejs/node/pull/63884#ref-commit-128d28c
https://github.com/MarshallOfSound
https://github.com/aduh95
module: avoid allocating a cache key string for every require()https://github.com/nodejs/node/commit/128d28c515a1ceaa93927c6c731ccdf6b7ea5731
128d28chttps://github.com/nodejs/node/commit/128d28c515a1ceaa93927c6c731ccdf6b7ea5731
#63884https://github.com/nodejs/node/pull/63884
aduh95https://github.com/aduh95
Oct 28, 2026 https://github.com/nodejs/node/pull/63884#ref-commit-79c5dae
https://github.com/MarshallOfSound
https://github.com/aduh95
module: avoid allocating a cache key string for every require()https://github.com/nodejs/node/commit/79c5dae634a3bbfed84105fde2ead627151d9516
79c5daehttps://github.com/nodejs/node/commit/79c5dae634a3bbfed84105fde2ead627151d9516
#63884https://github.com/nodejs/node/pull/63884
https://github.com/apps/leapmux-renovate
leapmux-renovatehttps://github.com/apps/leapmux-renovate
Nov 1, 2026 https://github.com/nodejs/node/pull/63884#ref-pullrequest-6152716313
chore(deps): Update Node.js to v26 leapmux/leapmux#578 https://github.com/leapmux/leapmux/pull/578
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63884
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63884/files/96860f39728edd36d5efa8483744386196f555f3
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/63884/files/a50d67a804e6dfa295ac47b7dd81c7375ef295b7
Please reload this pagehttps://github.com/nodejs/node/pull/63884
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63884
https://github.com/MarshallOfSound
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.