René's URL Explorer Experiment


Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node · GitHub

Open Graph Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node

X Title: stream: check done before backpressure in stream reader by watilde · Pull Request #63699 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Opengraph URL: https://github.com/nodejs/node/pull/63699

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1104c4c6-302d-a3a4-6c1e-500427e5ca20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E64:4F55F:1778D2B:1FD8D51:6A4C8D76
html-safe-nonce14f430fce699bb128138f2bc0fbe08a51ecbae8d7cdff916ecfa842327ce601e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTY0OjRGNTVGOjE3NzhEMkI6MUZEOEQ1MTo2QTRDOEQ3NiIsInZpc2l0b3JfaWQiOiIyMjgzMTk3NTAyNzQxOTA3MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f69e2eb81688ab28d04033b743e2bfe3b5a74fbdf44d8b12698eee380586edb
hovercard-subject-tagpull_request:3782454801
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63699/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2edfc9cad58a022691e7de969b649d50151dd98c2a305946ff0e1fabd7e583aa/nodejs/node/pull/63699
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2edfc9cad58a022691e7de969b649d50151dd98c2a305946ff0e1fabd7e583aa/nodejs/node/pull/63699
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatilde
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63699#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63699
Reloadhttps://github.com/nodejs/node/pull/63699
Reloadhttps://github.com/nodejs/node/pull/63699
Please reload this pagehttps://github.com/nodejs/node/pull/63699
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63699
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
watilde:stream-readhttps://github.com/watilde/node/tree/stream-read
Conversationhttps://github.com/nodejs/node/pull/63699
Commits1 (1)https://github.com/nodejs/node/pull/63699/commits
Checkshttps://github.com/nodejs/node/pull/63699/checks
Files changedhttps://github.com/nodejs/node/pull/63699/files
stream: check done before backpressure in stream readerhttps://github.com/nodejs/node/pull/63699#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
watilde:stream-readhttps://github.com/watilde/node/tree/stream-read
https://github.com/watilde
watildehttps://github.com/watilde
Jun 1, 2026https://github.com/nodejs/node/pull/63699#issue-4564878602
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/watilde
stream: check done before backpressure in stream readerhttps://github.com/nodejs/node/pull/63699/commits/af459814ef0c5e30b0572000746af2ff7069b56c
af45981https://github.com/nodejs/node/pull/63699/commits/af459814ef0c5e30b0572000746af2ff7069b56c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63699#issuecomment-4594721743
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jun 1, 2026https://github.com/nodejs/node/pull/63699#event-26198344899
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 1, 2026https://github.com/nodejs/node/pull/63699#issuecomment-4595363580
Please reload this pagehttps://github.com/nodejs/node/pull/63699
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
39b481bhttps://app.codecov.io/gh/nodejs/node/commit/39b481b5c510d3a12b6eea15a17681e6773d0b5d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
af45981https://app.codecov.io/gh/nodejs/node/commit/af459814ef0c5e30b0572000746af2ff7069b56c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/compose.jshttps://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fcompose.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvY29tcG9zZS5qcw==
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63699?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/compose.jshttps://app.codecov.io/gh/nodejs/node/pull/63699?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fcompose.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvY29tcG9zZS5qcw==
479 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63699/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jun 7, 2026 https://github.com/nodejs/node/pull/63699#pullrequestreview-4445159925
View reviewed changes https://github.com/nodejs/node/pull/63699/files/af459814ef0c5e30b0572000746af2ff7069b56c
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63699#pullrequestreview-4445159925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 7, 2026https://github.com/nodejs/node/pull/63699#event-26440557367
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 7, 2026https://github.com/nodejs/node/pull/63699#event-26441210413
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 7, 2026https://github.com/nodejs/node/pull/63699#issuecomment-4643962068
https://ci.nodejs.org/job/node-test-pull-request/73950/https://ci.nodejs.org/job/node-test-pull-request/73950/
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 9, 2026https://github.com/nodejs/node/pull/63699#event-26503451592
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 9, 2026https://github.com/nodejs/node/pull/63699#event-26505270768
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
5498337https://github.com/nodejs/node/commit/549833792e416e6a127f209f5cae3b459e5e1251
Jun 9, 2026https://github.com/nodejs/node/pull/63699#event-26505273490
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 9, 2026https://github.com/nodejs/node/pull/63699#issuecomment-4656260130
5498337https://github.com/nodejs/node/commit/549833792e416e6a127f209f5cae3b459e5e1251
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/watilde
watildehttps://github.com/watilde
June 16, 2026 07:07https://github.com/nodejs/node/pull/63699#event-26795060440
aduh95https://github.com/aduh95
Jun 18, 2026 https://github.com/nodejs/node/pull/63699#ref-commit-10272a9
https://github.com/watilde
https://github.com/aduh95
stream: check done before backpressure in stream readerhttps://github.com/nodejs/node/commit/10272a94b62780c33082f528c54218e2408370d0
10272a9https://github.com/nodejs/node/commit/10272a94b62780c33082f528c54218e2408370d0
#63699https://github.com/nodejs/node/pull/63699
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63699#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
luanmunizhttps://github.com/luanmuniz
Jun 25, 2026 https://github.com/nodejs/node/pull/63699#ref-commit-335835b
https://github.com/watilde
https://github.com/luanmuniz
stream: check done before backpressure in stream readerhttps://github.com/luanmuniz/node/commit/335835b7cb668a339f0ed8cb6a4d75604ac1a6d2
335835bhttps://github.com/luanmuniz/node/commit/335835b7cb668a339f0ed8cb6a4d75604ac1a6d2
nodejs#63699https://github.com/nodejs/node/pull/63699
aduh95https://github.com/aduh95
Jun 25, 2026 https://github.com/nodejs/node/pull/63699#ref-commit-97590e8
https://github.com/watilde
https://github.com/aduh95
stream: check done before backpressure in stream readerhttps://github.com/nodejs/node/commit/97590e8680e6ebc7edc0824c2977ec7d153dd002
97590e8https://github.com/nodejs/node/commit/97590e8680e6ebc7edc0824c2977ec7d153dd002
#63699https://github.com/nodejs/node/pull/63699
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63699
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63699/files/af459814ef0c5e30b0572000746af2ff7069b56c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/63699
https://github.com/watilde
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.