René's URL Explorer Experiment


Title: fs: ignore deleted dirs in recursive watch scan by trivikr · Pull Request #63686 · nodejs/node · GitHub

Open Graph Title: fs: ignore deleted dirs in recursive watch scan by trivikr · Pull Request #63686 · nodejs/node

X Title: fs: ignore deleted dirs in recursive watch scan by trivikr · Pull Request #63686 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes a race in the non-native recursive fs.watch() implementation. When a directory is removed recursively, the watcher can observe the child directory from the parent watcher and then attempt to ...

X Description: Fixes a race in the non-native recursive fs.watch() implementation. When a directory is removed recursively, the watcher can observe the child directory from the parent watcher and then attempt to ...

Opengraph URL: https://github.com/nodejs/node/pull/63686

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:24b18351-a2d1-c696-33aa-24a766e74986
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99EE:19F979:1E7422:29724A:6A4C6B4D
html-safe-nonceecf02abca4db9aeb732d55a8fa77cdaff27e7f3a6ca266ae969789616f201b18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUVFOjE5Rjk3OToxRTc0MjI6Mjk3MjRBOjZBNEM2QjREIiwidmlzaXRvcl9pZCI6IjgxNDY5NTI0NzAwMzI4Mzc0NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf29c6ffa3eadba2f92cf3bcc70df935cf42d2a12914db90b4f56fa813ec068bc
hovercard-subject-tagpull_request:3778558912
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63686/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b43d9ddc73dd18d29d1a83835353d9d5cebec4e598b7a98437451eb70103de3b/nodejs/node/pull/63686
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b43d9ddc73dd18d29d1a83835353d9d5cebec4e598b7a98437451eb70103de3b/nodejs/node/pull/63686
og:image:altFixes a race in the non-native recursive fs.watch() implementation. When a directory is removed recursively, the watcher can observe the child directory from the parent watcher and then attempt to ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14099438da5379150f15a2892474c7c7e6c0e55e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63686#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63686
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63686
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63686
Reloadhttps://github.com/nodejs/node/pull/63686
Reloadhttps://github.com/nodejs/node/pull/63686
Please reload this pagehttps://github.com/nodejs/node/pull/63686
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63686
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:test-fs-watch-recursive-deletehttps://github.com/trivikr/node/tree/test-fs-watch-recursive-delete
Conversationhttps://github.com/nodejs/node/pull/63686
Commits1 (1)https://github.com/nodejs/node/pull/63686/commits
Checkshttps://github.com/nodejs/node/pull/63686/checks
Files changedhttps://github.com/nodejs/node/pull/63686/files
fs: ignore deleted dirs in recursive watch scanhttps://github.com/nodejs/node/pull/63686#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:test-fs-watch-recursive-deletehttps://github.com/trivikr/node/tree/test-fs-watch-recursive-delete
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jun 1, 2026https://github.com/nodejs/node/pull/63686#issue-4560309920
https://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failurehttps://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failure
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/trivikr
fs: ignore deleted dirs in recursive watch scanhttps://github.com/nodejs/node/pull/63686/commits/a80cd4982536d03acc7fd5ad422b362773624b9c
a80cd49https://github.com/nodejs/node/pull/63686/commits/a80cd4982536d03acc7fd5ad422b362773624b9c
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 1, 2026https://github.com/nodejs/node/pull/63686#event-26170872137
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jun 1, 2026 https://github.com/nodejs/node/pull/63686#pullrequestreview-4398506867
View reviewed changes https://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c
lib/internal/fs/recursive_watch.jshttps://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c#diff-406861532da381e920c0704ad59e85c3a7dbe5a83919593d4cb596259857c890
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Jun 1, 2026 https://github.com/nodejs/node/pull/63686#pullrequestreview-4398580018
View reviewed changes https://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 1, 2026https://github.com/nodejs/node/pull/63686#event-26172377267
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 1, 2026https://github.com/nodejs/node/pull/63686#issuecomment-4589869331
Please reload this pagehttps://github.com/nodejs/node/pull/63686
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63686?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9e58d9dhttps://app.codecov.io/gh/nodejs/node/commit/9e58d9d244126ebd6f086e0dc2dab63719ff1bc6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
a80cd49https://app.codecov.io/gh/nodejs/node/commit/a80cd4982536d03acc7fd5ad422b362773624b9c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63686?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/recursive_watch.jshttps://app.codecov.io/gh/nodejs/node/pull/63686?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Frecursive_watch.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3JlY3Vyc2l2ZV93YXRjaC5qcw==
3 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63686?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/recursive_watch.jshttps://app.codecov.io/gh/nodejs/node/pull/63686?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Frecursive_watch.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL3JlY3Vyc2l2ZV93YXRjaC5qcw==
33 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63686/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 1, 2026https://github.com/nodejs/node/pull/63686#event-26179324374
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63686#issuecomment-4591082146
https://ci.nodejs.org/job/node-test-pull-request/73847/https://ci.nodejs.org/job/node-test-pull-request/73847/
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 1, 2026 https://github.com/nodejs/node/pull/63686#pullrequestreview-4403886562
View reviewed changes https://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 3, 2026https://github.com/nodejs/node/pull/63686#event-26269498651
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 3, 2026https://github.com/nodejs/node/pull/63686#event-26269745477
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
4d7996fhttps://github.com/nodejs/node/commit/4d7996fb5629e79d8183e4db015cc2b35d65cfdd
Jun 3, 2026https://github.com/nodejs/node/pull/63686#event-26269811279
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 3, 2026https://github.com/nodejs/node/pull/63686#issuecomment-4609407007
4d7996fhttps://github.com/nodejs/node/commit/4d7996fb5629e79d8183e4db015cc2b35d65cfdd
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/trivikr
trivikrhttps://github.com/trivikr
June 4, 2026 05:02https://github.com/nodejs/node/pull/63686#event-26320886412
https://github.com/trivikr
trivikrhttps://github.com/trivikr
June 4, 2026 05:03https://github.com/nodejs/node/pull/63686#event-26320907795
aduh95https://github.com/aduh95
Jun 18, 2026 https://github.com/nodejs/node/pull/63686#ref-commit-14d829c
https://github.com/trivikr
https://github.com/aduh95
fs: ignore deleted dirs in recursive watch scanhttps://github.com/nodejs/node/commit/14d829cb3c8f6d508ab8cfbf4f7d3f7244633622
14d829chttps://github.com/nodejs/node/commit/14d829cb3c8f6d508ab8cfbf4f7d3f7244633622
#63686https://github.com/nodejs/node/pull/63686
https://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failurehttps://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failure
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63686#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
aduh95https://github.com/aduh95
Jun 25, 2026 https://github.com/nodejs/node/pull/63686#ref-commit-b4037ae
https://github.com/trivikr
https://github.com/aduh95
fs: ignore deleted dirs in recursive watch scanhttps://github.com/nodejs/node/commit/b4037ae2fd84b00e92d31ef2cb0b1c36dc570872
b4037aehttps://github.com/nodejs/node/commit/b4037ae2fd84b00e92d31ef2cb0b1c36dc570872
#63686https://github.com/nodejs/node/pull/63686
https://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failurehttps://github.com/nodejs/reliability/blob/main/reports/2026-06-01.md#jstest-failure
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63686
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/63686/files/a80cd4982536d03acc7fd5ad422b362773624b9c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/63686
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/MoLow
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.