René's URL Explorer Experiment


Title: crypto: deduplicate X509 subject matching logic by tniessen · Pull Request #63644 · nodejs/node · GitHub

Open Graph Title: crypto: deduplicate X509 subject matching logic by tniessen · Pull Request #63644 · nodejs/node

X Title: crypto: deduplicate X509 subject matching logic by tniessen · Pull Request #63644 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: CheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.

X Description: CheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.

Opengraph URL: https://github.com/nodejs/node/pull/63644

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a5b3706a-3e23-d956-6343-562a316746ff
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1AC:92B80:7B3402:B1F0A4:6A4CE31B
html-safe-noncec23e6322bf5c4a60360f202a66b4f6b5c658679310ab27a7d7fad875fa7eae9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUFDOjkyQjgwOjdCMzQwMjpCMUYwQTQ6NkE0Q0UzMUIiLCJ2aXNpdG9yX2lkIjoiMzExNjU3NzAxMDc3MzQ1MTU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca67ec5fc96894905697c8e61721b9fa3da391772acbff98bebca5fd92f7f480d
hovercard-subject-tagpull_request:3768983161
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/addb33ea8609eabb61a6dd7e3b8ff120d2d1c6c72e2642b31da4806b2acea869/nodejs/node/pull/63644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/addb33ea8609eabb61a6dd7e3b8ff120d2d1c6c72e2642b31da4806b2acea869/nodejs/node/pull/63644
og:image:altCheckHost(), CheckEmail(), and CheckIP() all do very similar things. Extract the common logic into a helper function CheckX509Subject() to avoid duplication.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec5a57f04eeb310f57c73fd6d751d957e2ca27ed2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63644#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63644
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63644
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63644
Reloadhttps://github.com/nodejs/node/pull/63644
Reloadhttps://github.com/nodejs/node/pull/63644
Please reload this pagehttps://github.com/nodejs/node/pull/63644
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63644
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:x509-dedup-subject-matchhttps://github.com/tniessen/node/tree/x509-dedup-subject-match
Conversationhttps://github.com/nodejs/node/pull/63644
Commits1 (1)https://github.com/nodejs/node/pull/63644/commits
Checkshttps://github.com/nodejs/node/pull/63644/checks
Files changedhttps://github.com/nodejs/node/pull/63644/files
crypto: deduplicate X509 subject matching logichttps://github.com/nodejs/node/pull/63644#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:x509-dedup-subject-matchhttps://github.com/tniessen/node/tree/x509-dedup-subject-match
https://github.com/tniessen
tniessenhttps://github.com/tniessen
May 29, 2026https://github.com/nodejs/node/pull/63644#issue-4548565350
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 29, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4575210939
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 29, 2026https://github.com/nodejs/node/pull/63644#event-26109831037
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 29, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4576134224
Please reload this pagehttps://github.com/nodejs/node/pull/63644
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63644?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
79def6dhttps://app.codecov.io/gh/nodejs/node/commit/79def6d897b09cc3bfc9dd0f870fed3498ccf323?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
0f3664chttps://app.codecov.io/gh/nodejs/node/commit/0f3664c9135e28c87e07eb3be256d572ea2d9924?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63644?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/crypto/crypto_x509.cchttps://app.codecov.io/gh/nodejs/node/pull/63644?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_x509.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9feDUwOS5jYw==
0 Missing and 3 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63644?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63644?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/crypto/crypto_x509.cchttps://app.codecov.io/gh/nodejs/node/pull/63644?src=pr&el=tree&filepath=src%2Fcrypto%2Fcrypto_x509.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NyeXB0by9jcnlwdG9feDUwOS5jYw==
42 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63644/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
May 29, 2026 https://github.com/nodejs/node/pull/63644#pullrequestreview-4391888233
View reviewed changes https://github.com/nodejs/node/pull/63644/files/0f3664c9135e28c87e07eb3be256d572ea2d9924
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 29, 2026https://github.com/nodejs/node/pull/63644#event-26122874654
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 29, 2026https://github.com/nodejs/node/pull/63644#event-26123653111
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 29, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4578713214
https://ci.nodejs.org/job/node-test-pull-request/73829/https://ci.nodejs.org/job/node-test-pull-request/73829/
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/tniessen
crypto: deduplicate X509 subject matching logichttps://github.com/nodejs/node/pull/63644/commits/0f3664c9135e28c87e07eb3be256d572ea2d9924
0f3664chttps://github.com/nodejs/node/pull/63644/commits/0f3664c9135e28c87e07eb3be256d572ea2d9924
https://github.com/tniessen
tniessenhttps://github.com/tniessen
force-pushedhttps://github.com/nodejs/node/compare/2815b819fd8312e1695e7942eb5942a46154f175..0f3664c9135e28c87e07eb3be256d572ea2d9924
2815b81https://github.com/nodejs/node/commit/2815b819fd8312e1695e7942eb5942a46154f175
0f3664chttps://github.com/nodejs/node/commit/0f3664c9135e28c87e07eb3be256d572ea2d9924
Compare https://github.com/nodejs/node/compare/2815b819fd8312e1695e7942eb5942a46154f175..0f3664c9135e28c87e07eb3be256d572ea2d9924
May 30, 2026 15:03https://github.com/nodejs/node/pull/63644#event-26143386391
https://github.com/tniessen
tniessenhttps://github.com/tniessen
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 30, 2026https://github.com/nodejs/node/pull/63644#event-26143486897
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 1, 2026https://github.com/nodejs/node/pull/63644#event-26183697903
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4591931700
https://ci.nodejs.org/job/node-test-pull-request/73856/https://ci.nodejs.org/job/node-test-pull-request/73856/
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4594472588
https://ci.nodejs.org/job/node-test-pull-request/73869/https://ci.nodejs.org/job/node-test-pull-request/73869/
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/tniessen
tniessenhttps://github.com/tniessen
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Jun 2, 2026https://github.com/nodejs/node/pull/63644#event-26229448081
https://github.com/panva
panvahttps://github.com/panva
Jun 2, 2026 https://github.com/nodejs/node/pull/63644#pullrequestreview-4411755203
View reviewed changes https://github.com/nodejs/node/pull/63644/files/0f3664c9135e28c87e07eb3be256d572ea2d9924
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 2, 2026https://github.com/nodejs/node/pull/63644#event-26259050746
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 2, 2026https://github.com/nodejs/node/pull/63644#event-26259714299
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
a0423e2https://github.com/nodejs/node/commit/a0423e2e29f1c1f7033974580a519e889d3c2d90
Jun 2, 2026https://github.com/nodejs/node/pull/63644#event-26259786520
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 2, 2026https://github.com/nodejs/node/pull/63644#issuecomment-4607420852
a0423e2https://github.com/nodejs/node/commit/a0423e2e29f1c1f7033974580a519e889d3c2d90
Please reload this pagehttps://github.com/nodejs/node/pull/63644
aduh95https://github.com/aduh95
Jun 18, 2026 https://github.com/nodejs/node/pull/63644#ref-commit-5551e8f
https://github.com/tniessen
https://github.com/aduh95
crypto: deduplicate X509 subject matching logichttps://github.com/nodejs/node/commit/5551e8f773186401447cdf6c26b2bc11a2ccfd66
5551e8fhttps://github.com/nodejs/node/commit/5551e8f773186401447cdf6c26b2bc11a2ccfd66
#63644https://github.com/nodejs/node/pull/63644
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63644#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
aduh95https://github.com/aduh95
Jun 25, 2026 https://github.com/nodejs/node/pull/63644#ref-commit-12986ba
https://github.com/tniessen
https://github.com/aduh95
crypto: deduplicate X509 subject matching logichttps://github.com/nodejs/node/commit/12986ba26e253475916345378952746f8c660d43
12986bahttps://github.com/nodejs/node/commit/12986ba26e253475916345378952746f8c660d43
#63644https://github.com/nodejs/node/pull/63644
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63644
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/63644/files/0f3664c9135e28c87e07eb3be256d572ea2d9924
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/63644/files/0f3664c9135e28c87e07eb3be256d572ea2d9924
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
Please reload this pagehttps://github.com/nodejs/node/pull/63644
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/panva
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.