René's URL Explorer Experiment


Title: sqlite: fix undefined behaviour in `Session::Changeset()` by ndossche · Pull Request #63637 · nodejs/node · GitHub

Open Graph Title: sqlite: fix undefined behaviour in `Session::Changeset()` by ndossche · Pull Request #63637 · nodejs/node

X Title: sqlite: fix undefined behaviour in `Session::Changeset()` by ndossche · Pull Request #63637 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: If nChangeset == 0, the pointer pChangeset may be nullptr. Passing a nullptr to memcpy() is undefined behaviour. This can be triggered by running the test suite under UBSAN. ../src/node_sqlite.cc:3...

X Description: If nChangeset == 0, the pointer pChangeset may be nullptr. Passing a nullptr to memcpy() is undefined behaviour. This can be triggered by running the test suite under UBSAN. ../src/node_sqlite.cc:3...

Opengraph URL: https://github.com/nodejs/node/pull/63637

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c38d1402-b5d4-d52e-0760-335dd20a7511
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBDA:257BEE:6DA846:91CE1A:6AED21DF
html-safe-nonce2c68f2b3364c04b4792ddf16839a514d3d2598dbdf96f5699c8b84ee0ee5977f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkRBOjI1N0JFRTo2REE4NDY6OTFDRTFBOjZBRUQyMURGIiwidmlzaXRvcl9pZCI6IjgzNjE3NjQwNDM4NzcwNjUxODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2f375fef173231096654085d51c80296052e382dd000d7d6df363f5ada9e0cc3
hovercard-subject-tagpull_request:3767890775
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63637/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0bf6875a76a2cde2d2e727283cc8a8b47cb1a15480b56e9ce628c01f897e207/nodejs/node/pull/63637
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0bf6875a76a2cde2d2e727283cc8a8b47cb1a15480b56e9ce628c01f897e207/nodejs/node/pull/63637
og:image:altIf nChangeset == 0, the pointer pChangeset may be nullptr. Passing a nullptr to memcpy() is undefined behaviour. This can be triggered by running the test suite under UBSAN. ../src/node_sqlite.cc:3...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamendossche
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63637#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63637
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63637
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63637
Reloadhttps://github.com/nodejs/node/pull/63637
Reloadhttps://github.com/nodejs/node/pull/63637
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
ndossche:sqlite-ubsan-1https://github.com/ndossche/node/tree/sqlite-ubsan-1
Conversationhttps://github.com/nodejs/node/pull/63637
Commits1 (1)https://github.com/nodejs/node/pull/63637/commits
Checkshttps://github.com/nodejs/node/pull/63637/checks
Files changedhttps://github.com/nodejs/node/pull/63637/files
sqlite: fix undefined behaviour in Session::Changeset()https://github.com/nodejs/node/pull/63637#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
ndossche:sqlite-ubsan-1https://github.com/ndossche/node/tree/sqlite-ubsan-1
https://github.com/ndossche
ndosschehttps://github.com/ndossche
May 29, 2026https://github.com/nodejs/node/pull/63637#issue-4547295574
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/ndossche
sqlite: fix undefined behaviour in Session::Changeset()https://github.com/nodejs/node/pull/63637/commits/6600a2e5e052579ef067d647ddc9349338564d18
6600a2ehttps://github.com/nodejs/node/pull/63637/commits/6600a2e5e052579ef067d647ddc9349338564d18
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4573102281
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
May 29, 2026https://github.com/nodejs/node/pull/63637#event-26102507319
https://github.com/louwers
louwershttps://github.com/louwers
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4574043037
https://sqlite.org/session/sqlite3session_changeset.htmlhttps://sqlite.org/session/sqlite3session_changeset.html
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4574116587
Please reload this pagehttps://github.com/nodejs/node/pull/63637
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63637?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
40dc5a1https://app.codecov.io/gh/nodejs/node/commit/40dc5a1dc465ebb27002c996bbf1d00cbf74b8fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6600a2ehttps://app.codecov.io/gh/nodejs/node/commit/6600a2e5e052579ef067d647ddc9349338564d18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63637?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/63637?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63637?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63637?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/63637?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63637/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/ndossche
ndosschehttps://github.com/ndossche
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4574318887
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://sqlite.org/session/sqlite3session_changeset.htmlhttps://sqlite.org/session/sqlite3session_changeset.html
https://github.com/sqlite/sqlite/blob/6a8e887a64798221b633068f882b2ac2c48a3cbb/ext/session/sqlite3session.c#L3191-L3194https://github.com/sqlite/sqlite/blob/6a8e887a64798221b633068f882b2ac2c48a3cbb/ext/session/sqlite3session.c#L3191-L3194
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
May 29, 2026 https://github.com/nodejs/node/pull/63637#pullrequestreview-4389683650
View reviewed changes https://github.com/nodejs/node/pull/63637/files/6600a2e5e052579ef067d647ddc9349338564d18
Renegade334https://github.com/Renegade334
https://github.com/nodejs/node/pull/63637#pullrequestreview-4389683650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/ndossche
ndosschehttps://github.com/ndossche
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4575608801
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/louwers
louwershttps://github.com/louwers
May 29, 2026https://github.com/nodejs/node/pull/63637#issuecomment-4576562730
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 25, 2026https://github.com/nodejs/node/pull/63637#event-28487050507
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 26, 2026https://github.com/nodejs/node/pull/63637#event-28487304803
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63637
https://github.com/TrevorBurnham
TrevorBurnhamhttps://github.com/TrevorBurnham
Aug 4, 2026 https://github.com/nodejs/node/pull/63637#ref-issue-2917995678
stabilization of node:sqlite module #57445 https://github.com/nodejs/node/issues/57445
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63637
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/63637#issuecomment-5199293880
https://ci.nodejs.org/job/node-test-pull-request/75546/https://ci.nodejs.org/job/node-test-pull-request/75546/
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 6, 2026https://github.com/nodejs/node/pull/63637#event-29044602661
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Aug 6, 2026https://github.com/nodejs/node/pull/63637#event-29045325228
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c18fd90https://github.com/nodejs/node/commit/c18fd9060bf62bf79baa4894adee2c69887c5b34
Aug 6, 2026https://github.com/nodejs/node/pull/63637#event-29045384657
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 6, 2026https://github.com/nodejs/node/pull/63637#issuecomment-5199990594
c18fd90https://github.com/nodejs/node/commit/c18fd9060bf62bf79baa4894adee2c69887c5b34
Please reload this pagehttps://github.com/nodejs/node/pull/63637
aduh95https://github.com/aduh95
Aug 13, 2026 https://github.com/nodejs/node/pull/63637#ref-commit-5754b49
https://github.com/ndossche
https://github.com/aduh95
sqlite: fix undefined behaviour in Session::Changeset()https://github.com/nodejs/node/commit/5754b49157131f936b1e93bb5d74967f8aac7a21
5754b49https://github.com/nodejs/node/commit/5754b49157131f936b1e93bb5d74967f8aac7a21
#63637https://github.com/nodejs/node/pull/63637
aduh95https://github.com/aduh95
Aug 25, 2026 https://github.com/nodejs/node/pull/63637#ref-commit-09d0da9
https://github.com/ndossche
https://github.com/aduh95
sqlite: fix undefined behaviour in Session::Changeset()https://github.com/nodejs/node/commit/09d0da99e9c1707f6096bdd69917997c00c57d32
09d0da9https://github.com/nodejs/node/commit/09d0da99e9c1707f6096bdd69917997c00c57d32
#63637https://github.com/nodejs/node/pull/63637
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026 https://github.com/nodejs/node/pull/63637#ref-pullrequest-5251528519
2026-08-26, Version 26.8.0 (Current) #65551 https://github.com/nodejs/node/pull/65551
aduh95https://github.com/aduh95
Aug 27, 2026 https://github.com/nodejs/node/pull/63637#ref-commit-cdb732b
https://github.com/ndossche
https://github.com/aduh95
sqlite: fix undefined behaviour in Session::Changeset()https://github.com/nodejs/node/commit/cdb732beb5f8bce66cdd0f98c46393e039d82be2
cdb732bhttps://github.com/nodejs/node/commit/cdb732beb5f8bce66cdd0f98c46393e039d82be2
#63637https://github.com/nodejs/node/pull/63637
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 7, 2026 https://github.com/nodejs/node/pull/63637#ref-pullrequest-5371695467
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873 https://github.com/nodejs/node/pull/65873
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63637
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/63637/files/6600a2e5e052579ef067d647ddc9349338564d18
Please reload this pagehttps://github.com/nodejs/node/pull/63637
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Please reload this pagehttps://github.com/nodejs/node/pull/63637
https://github.com/ndossche
https://github.com/nodejs-github-bot
https://github.com/louwers
https://github.com/Renegade334
https://github.com/trivikr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.