René's URL Explorer Experiment


Title: stream: switch to internal `sleep` binding by aduh95 · Pull Request #63611 · nodejs/node · GitHub

Open Graph Title: stream: switch to internal `sleep` binding by aduh95 · Pull Request #63611 · nodejs/node

X Title: stream: switch to internal `sleep` binding by aduh95 · Pull Request #63611 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: I don't think there was any reason to maintain two duplicate implementations, my guess is that we simply forgot about the existing util. node/lib/internal/util.js ...

X Description: I don't think there was any reason to maintain two duplicate implementations, my guess is that we simply forgot about the existing util. node/lib/internal/util.js ...

Opengraph URL: https://github.com/nodejs/node/pull/63611

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f0d18caf-e740-7e9e-5a0a-41840e4e4eba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB1A:327072:E7C9F0:1379646:6A4C64F6
html-safe-nonce1755e445a0634e89f66f71b320ef77310b48cf4d1aefdd691ab5d88022d96c06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjFBOjMyNzA3MjpFN0M5RjA6MTM3OTY0Njo2QTRDNjRGNiIsInZpc2l0b3JfaWQiOiI2NDg0ODY2OTA4OTI3MzIxMzM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacef8f23ef0ff3323eef3af02e94bf0168c4fcafa8bab13d6d0444aaeb345b641b
hovercard-subject-tagpull_request:3760700170
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63611/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8bd26dcf2687e50c6d5af50d12de9f0520eb1fe465630f814cdf766669c65b14/nodejs/node/pull/63611
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8bd26dcf2687e50c6d5af50d12de9f0520eb1fe465630f814cdf766669c65b14/nodejs/node/pull/63611
og:image:altI don't think there was any reason to maintain two duplicate implementations, my guess is that we simply forgot about the existing util. node/lib/internal/util.js ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14099438da5379150f15a2892474c7c7e6c0e55e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63611#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63611
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63611
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63611
Reloadhttps://github.com/nodejs/node/pull/63611
Reloadhttps://github.com/nodejs/node/pull/63611
Please reload this pagehttps://github.com/nodejs/node/pull/63611
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63611
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:sleephttps://github.com/aduh95/node/tree/sleep
Conversationhttps://github.com/nodejs/node/pull/63611
Commits2 (2)https://github.com/nodejs/node/pull/63611/commits
Checkshttps://github.com/nodejs/node/pull/63611/checks
Files changedhttps://github.com/nodejs/node/pull/63611/files
stream: switch to internal sleep bindinghttps://github.com/nodejs/node/pull/63611#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:sleephttps://github.com/aduh95/node/tree/sleep
https://github.com/aduh95
aduh95https://github.com/aduh95
May 28, 2026https://github.com/nodejs/node/pull/63611#issue-4538929212
node/lib/internal/util.jshttps://github.com/nodejs/node/blob/8d0a3b84ff4b1e5bb1b0d54265ebd553bb29930e/lib/internal/util.js#L610-L617
8d0a3b8https://github.com/nodejs/node/commit/8d0a3b84ff4b1e5bb1b0d54265ebd553bb29930e
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/aduh95
stream: switch to internal sleep bindinghttps://github.com/nodejs/node/pull/63611/commits/28e0ebacfdf925b0204a83456e64c98e1696ba21
28e0ebahttps://github.com/nodejs/node/pull/63611/commits/28e0ebacfdf925b0204a83456e64c98e1696ba21
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4562128897
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 28, 2026https://github.com/nodejs/node/pull/63611#event-26053181321
https://github.com/aduh95
fixup! stream: switch to internal sleep bindinghttps://github.com/nodejs/node/pull/63611/commits/c5f908891c736e072e4faa21f39801df62e9db69
c5f9088https://github.com/nodejs/node/pull/63611/commits/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/MattiasBuelens
May 28, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4562485926
SonicBoomhttps://github.com/pinojs/sonic-boom
atomic-sleephttps://github.com/davidmarkclements/atomic-sleep
The atomic-sleep implementationhttps://github.com/davidmarkclements/atomic-sleep/blob/b8149d3ca276c84a54fa8fa1478f9cc79aabc15a/index.js
the original PRhttps://github.com/nodejs/node/pull/58897
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/MattiasBuelens
May 28, 2026 https://github.com/nodejs/node/pull/63611#pullrequestreview-4379577229
View reviewed changes https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/MattiasBuelens
MattiasBuelenshttps://github.com/MattiasBuelens
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2026https://github.com/nodejs/node/pull/63611#event-26054906590
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
May 28, 2026https://github.com/nodejs/node/pull/63611#event-26054967842
https://github.com/panva
panvahttps://github.com/panva
May 28, 2026 https://github.com/nodejs/node/pull/63611#pullrequestreview-4379730690
View reviewed changes https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 28, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4562998383
Please reload this pagehttps://github.com/nodejs/node/pull/63611
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63611?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8d0a3b8https://app.codecov.io/gh/nodejs/node/commit/8d0a3b84ff4b1e5bb1b0d54265ebd553bb29930e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
c5f9088https://app.codecov.io/gh/nodejs/node/commit/c5f908891c736e072e4faa21f39801df62e9db69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63611?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/fast-utf8-stream.jshttps://app.codecov.io/gh/nodejs/node/pull/63611?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Ffast-utf8-stream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvZmFzdC11dGY4LXN0cmVhbS5qcw==
47 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63611/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2026https://github.com/nodejs/node/pull/63611#event-26057914593
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4563174383
https://ci.nodejs.org/job/node-test-pull-request/73809/https://ci.nodejs.org/job/node-test-pull-request/73809/
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
May 28, 2026 https://github.com/nodejs/node/pull/63611#pullrequestreview-4382750413
View reviewed changes https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 28, 2026 https://github.com/nodejs/node/pull/63611#pullrequestreview-4383598438
View reviewed changes https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4567316824
https://ci.nodejs.org/job/node-test-pull-request/73819/https://ci.nodejs.org/job/node-test-pull-request/73819/
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 28, 2026https://github.com/nodejs/node/pull/63611#event-26081175315
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 30, 2026https://github.com/nodejs/node/pull/63611#event-26139527784
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
27199eehttps://github.com/nodejs/node/commit/27199ee1901c2c42cb618e688cc325cdbc121919
May 30, 2026https://github.com/nodejs/node/pull/63611#event-26139552198
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 30, 2026https://github.com/nodejs/node/pull/63611#issuecomment-4582350906
27199eehttps://github.com/nodejs/node/commit/27199ee1901c2c42cb618e688cc325cdbc121919
Please reload this pagehttps://github.com/nodejs/node/pull/63611
aduh95https://github.com/aduh95
May 30, 2026 https://github.com/nodejs/node/pull/63611#ref-commit-0c33138
https://github.com/aduh95
stream: switch to internal sleep bindinghttps://github.com/nodejs/node/commit/0c331384047f91d423be73949995337a551988af
0c33138https://github.com/nodejs/node/commit/0c331384047f91d423be73949995337a551988af
#63611https://github.com/nodejs/node/pull/63611
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 30, 2026 https://github.com/nodejs/node/pull/63611#ref-pullrequest-4555076114
2026-06-01, Version 26.3.0 (Current) #63664 https://github.com/nodejs/node/pull/63664
aduh95https://github.com/aduh95
May 30, 2026 https://github.com/nodejs/node/pull/63611#ref-commit-563db50
https://github.com/aduh95
stream: switch to internal sleep bindinghttps://github.com/nodejs/node/commit/563db50f384260192325b9297357e70adfc377bc
563db50https://github.com/nodejs/node/commit/563db50f384260192325b9297357e70adfc377bc
#63611https://github.com/nodejs/node/pull/63611
sxahttps://github.com/sxa
Jun 18, 2026 https://github.com/nodejs/node/pull/63611#ref-commit-1af8276
https://github.com/aduh95
https://github.com/sxa
stream: switch to internal sleep bindinghttps://github.com/sxa/node/commit/1af82761e7070d4d59921b70ad8c02c9c99c3efa
1af8276https://github.com/sxa/node/commit/1af82761e7070d4d59921b70ad8c02c9c99c3efa
nodejs#63611https://github.com/nodejs/node/pull/63611
sxahttps://github.com/sxa
Jun 18, 2026 https://github.com/nodejs/node/pull/63611#ref-commit-58fa2ee
https://github.com/aduh95
https://github.com/sxa
stream: switch to internal sleep bindinghttps://github.com/nodejs/node/commit/58fa2ee1894af07f230a80e371df8d1c5bd3952c
58fa2eehttps://github.com/nodejs/node/commit/58fa2ee1894af07f230a80e371df8d1c5bd3952c
#63611https://github.com/nodejs/node/pull/63611
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 19, 2026 https://github.com/nodejs/node/pull/63611#ref-pullrequest-4700088884
2026-06-19, Version 24.18.0 'Krypton' (LTS) #64001 https://github.com/nodejs/node/pull/64001
https://github.com/sxa
sxahttps://github.com/sxa
Jun 22, 2026 https://github.com/nodejs/node/pull/63611#ref-pullrequest-4716245129
2026-06-23, Version 24.18.0 'Krypton' (LTS) #64062 https://github.com/nodejs/node/pull/64062
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63611
https://github.com/panva
panva https://github.com/panva
https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/MattiasBuelens
MattiasBuelens https://github.com/MattiasBuelens
https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
https://github.com/Ethan-Arrowood
Ethan-Arrowood https://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/63611/files/c5f908891c736e072e4faa21f39801df62e9db69
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/63611
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/MattiasBuelens
https://github.com/panva
https://github.com/trivikr
https://github.com/Ethan-Arrowood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.