Title: debugger: await initialization after run and restart by trivikr · Pull Request #63607 · nodejs/node · GitHub
Open Graph Title: debugger: await initialization after run and restart by trivikr · Pull Request #63607 · nodejs/node
X Title: debugger: await initialization after run and restart by trivikr · Pull Request #63607 · nodejs/node
Description: Fix a debugger CLI synchronization race after run and restart.
Previously, these commands resolved once the inspector websocket connection
was established and ok was printed. The debugger initialization that enables
domains, restores breakpoints, and calls Runtime.runIfWaitingForDebugger()
was started from the ready event but not awaited.
That allowed the REPL prompt to be displayed before the restarted debuggee had
actually been released from --inspect-brk and reported the initial break. In
slow CI runs, this could make parallel/test-debugger-run-after-quit-restart
time out while waiting for the initial break message.
This changes run and restart to await the same post-connect initialization
path before resolving.
Observed in:
https://github.com/nodejs/node/actions/runs/26499357103/job/78035468302
https://github.com/nodejs/node/actions/runs/26555566216/job/78236783282
https://github.com/nodejs/node/actions/runs/26561872119/job/78246617313
Error Log
Path: parallel/test-debugger-run-after-quit-restart
Error: --- stderr ---
/Users/runner/work/node/node/dir with $unusual"chars?'åß∂ƒ©∆¬…`/test/common/debugger.js:92
const timeoutErr = new Error(`Timeout (${TIMEOUT}) while waiting for ${pattern}`);
^
Error: Timeout (15000) while waiting for /break (?:on start )?in/i
at /Users/runner/work/node/node/dir with $unusual"chars?'åß∂ƒ©∆¬…`/test/common/debugger.js:92:28
at new Promise (
Open Graph Description: Fix a debugger CLI synchronization race after run and restart. Previously, these commands resolved once the inspector websocket connection was established and ok was printed. The debugger initializ...
X Description: Fix a debugger CLI synchronization race after run and restart. Previously, these commands resolved once the inspector websocket connection was established and ok was printed. The debugger initializ...
Opengraph URL: https://github.com/nodejs/node/pull/63607
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d7c56d4d-4a0c-2eb4-07f4-960f194f9db1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8098:320964:14B1476:1C07902:6A4C7F61 |
| html-safe-nonce | feb3ae7859d64d07fa7ecf044c2794f18a111d12465f484f428e7ec66ae416d1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDk4OjMyMDk2NDoxNEIxNDc2OjFDMDc5MDI6NkE0QzdGNjEiLCJ2aXNpdG9yX2lkIjoiNTQyNzc5MDY4NzYxMjIwNjk0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | eca9320937f0b4ef99980a37d7ec516d03370601e2daf42a15212cc8c42903b3 |
| hovercard-subject-tag | pull_request:3760068786 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63607/files |
| twitter:image | https://avatars.githubusercontent.com/u/16024985?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/16024985?s=400&v=4 |
| og:image:alt | Fix a debugger CLI synchronization race after run and restart. Previously, these commands resolved once the inspector websocket connection was established and ok was printed. The debugger initializ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd470457e909b9d062f8002cf438ba870e6acff6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width