Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node · GitHub
Open Graph Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node
X Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node
Description: This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0 and false reject correctly instead of leaving reads pending. Fixes: #63568 Assisted-by: openai:gpt-5.5
Open Graph Description: This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0...
X Description: This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0...
Opengraph URL: https://github.com/nodejs/node/pull/63569
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:262b8d42-1aeb-5029-f7e8-227a1572902b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8256:3FAC1E:11666B:192F03:6A4C92A3 |
| html-safe-nonce | 95697be917c49c12adbd354afaac22897e94b08d4a0a070fcc9cc153689a9a2f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjU2OjNGQUMxRToxMTY2NkI6MTkyRjAzOjZBNEM5MkEzIiwidmlzaXRvcl9pZCI6IjQxMDczMjY3MDQ5NzE0NTMwOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 699325ad23d0f7b35968adce7c3ba52d817026e68b2411792ee5329a80d204fb |
| hovercard-subject-tag | pull_request:3744160723 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/63569/files |
| twitter:image | https://avatars.githubusercontent.com/u/16024985?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/16024985?s=400&v=4 |
| og:image:alt | This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a2dede45637df6b92ddcfe2a557e67d4b5854ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width