René's URL Explorer Experiment


Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node · GitHub

Open Graph Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node

X Title: stream: handle falsy push writer fail reasons by trivikr · Pull Request #63569 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0...

X Description: This fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0...

Opengraph URL: https://github.com/nodejs/node/pull/63569

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5f20c846-b930-86b6-325c-8a8a7ce51999
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id982C:170119:1B5598:255517:6A4C6AFA
html-safe-noncef1ca07528069726a4c04184bed5feda03c1b86e551b2356b66d73889331a4e1f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODJDOjE3MDExOToxQjU1OTg6MjU1NTE3OjZBNEM2QUZBIiwidmlzaXRvcl9pZCI6IjEwNzY2NDk4MTkyOTA0OTU3MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca1427325dba7b457fd41fca5b9aae8ae9cf29fb18bb12694991fdbc0684ad27e
hovercard-subject-tagpull_request:3744160723
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/63569/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4b570644fe6163c6bdd80f0680fde5a708c58ce7bdea859d2296a1b450d5532f/nodejs/node/pull/63569
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b570644fe6163c6bdd80f0680fde5a708c58ce7bdea859d2296a1b450d5532f/nodejs/node/pull/63569
og:image:altThis fixes stream/iter push writer reads after writer.fail() is called with an explicit falsy reason. Reads now use the writer state instead of the truthiness of the stored error, so reasons like 0...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrivikr
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14099438da5379150f15a2892474c7c7e6c0e55e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/63569#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63569
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63569
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/63569
Reloadhttps://github.com/nodejs/node/pull/63569
Reloadhttps://github.com/nodejs/node/pull/63569
Please reload this pagehttps://github.com/nodejs/node/pull/63569
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/63569
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-writer-fail-pendinghttps://github.com/trivikr/node/tree/stream-iter-writer-fail-pending
Conversationhttps://github.com/nodejs/node/pull/63569
Commits1 (1)https://github.com/nodejs/node/pull/63569/commits
Checkshttps://github.com/nodejs/node/pull/63569/checks
Files changedhttps://github.com/nodejs/node/pull/63569/files
stream: handle falsy push writer fail reasonshttps://github.com/nodejs/node/pull/63569#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
trivikr:stream-iter-writer-fail-pendinghttps://github.com/trivikr/node/tree/stream-iter-writer-fail-pending
https://github.com/trivikr
trivikrhttps://github.com/trivikr
May 25, 2026https://github.com/nodejs/node/pull/63569#issue-4519506595
#63568https://github.com/nodejs/node/issues/63568
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 25, 2026https://github.com/nodejs/node/pull/63569#issuecomment-4537202716
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
May 25, 2026https://github.com/nodejs/node/pull/63569#event-25939918874
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 25, 2026https://github.com/nodejs/node/pull/63569#issuecomment-4537650205
Please reload this pagehttps://github.com/nodejs/node/pull/63569
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/63569?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8b88e2chttps://app.codecov.io/gh/nodejs/node/commit/8b88e2c841368887ba650478008d14df5cac324f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
bdda946https://app.codecov.io/gh/nodejs/node/commit/bdda9469ceccbd03efb3209d3060b4274b86b8f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63569?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63569?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/63569?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/63569?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/streams/iter/push.jshttps://app.codecov.io/gh/nodejs/node/pull/63569?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fiter%2Fpush.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvaXRlci9wdXNoLmpz
478 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/63569/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/047dd35e1d8b14392fea829519db58e467c55db2..cf08dca4a698ee7cff96bbaf27a5053720a4974f
047dd35https://github.com/nodejs/node/commit/047dd35e1d8b14392fea829519db58e467c55db2
cf08dcahttps://github.com/nodejs/node/commit/cf08dca4a698ee7cff96bbaf27a5053720a4974f
Compare https://github.com/nodejs/node/compare/047dd35e1d8b14392fea829519db58e467c55db2..cf08dca4a698ee7cff96bbaf27a5053720a4974f
May 27, 2026 15:37https://github.com/nodejs/node/pull/63569#event-26022237025
https://github.com/trivikr
trivikrhttps://github.com/trivikr
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 28, 2026https://github.com/nodejs/node/pull/63569#event-26043044693
https://github.com/trivikr
stream: handle falsy push writer fail reasonshttps://github.com/nodejs/node/pull/63569/commits/bdda9469ceccbd03efb3209d3060b4274b86b8f0
bdda946https://github.com/nodejs/node/pull/63569/commits/bdda9469ceccbd03efb3209d3060b4274b86b8f0
nodejs#63568https://github.com/nodejs/node/issues/63568
https://github.com/trivikr
trivikrhttps://github.com/trivikr
force-pushedhttps://github.com/nodejs/node/compare/cf08dca4a698ee7cff96bbaf27a5053720a4974f..bdda9469ceccbd03efb3209d3060b4274b86b8f0
cf08dcahttps://github.com/nodejs/node/commit/cf08dca4a698ee7cff96bbaf27a5053720a4974f
bdda946https://github.com/nodejs/node/commit/bdda9469ceccbd03efb3209d3060b4274b86b8f0
Compare https://github.com/nodejs/node/compare/cf08dca4a698ee7cff96bbaf27a5053720a4974f..bdda9469ceccbd03efb3209d3060b4274b86b8f0
May 31, 2026 05:25https://github.com/nodejs/node/pull/63569#event-26152688634
https://github.com/mcollina
mcollinahttps://github.com/mcollina
May 31, 2026 https://github.com/nodejs/node/pull/63569#pullrequestreview-4396549649
View reviewed changes https://github.com/nodejs/node/pull/63569/files/bdda9469ceccbd03efb3209d3060b4274b86b8f0
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/63569#pullrequestreview-4396549649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/trivikr
trivikrhttps://github.com/trivikr
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 31, 2026https://github.com/nodejs/node/pull/63569#event-26158710521
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 1, 2026https://github.com/nodejs/node/pull/63569#event-26188367952
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63569#issuecomment-4592852328
https://ci.nodejs.org/job/node-test-pull-request/73860/https://ci.nodejs.org/job/node-test-pull-request/73860/
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/trivikr
trivikrhttps://github.com/trivikr
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 1, 2026https://github.com/nodejs/node/pull/63569#event-26210576751
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 1, 2026https://github.com/nodejs/node/pull/63569#event-26211052618
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
37779fdhttps://github.com/nodejs/node/commit/37779fdf1cbe9c1d95828acb1ec6d6e30d4e38fe
Jun 1, 2026https://github.com/nodejs/node/pull/63569#event-26211109854
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 1, 2026https://github.com/nodejs/node/pull/63569#issuecomment-4597260450
37779fdhttps://github.com/nodejs/node/commit/37779fdf1cbe9c1d95828acb1ec6d6e30d4e38fe
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/trivikr
trivikrhttps://github.com/trivikr
June 4, 2026 05:02https://github.com/nodejs/node/pull/63569#event-26320889430
aduh95https://github.com/aduh95
Jun 20, 2026 https://github.com/nodejs/node/pull/63569#ref-commit-d9967a2
https://github.com/trivikr
https://github.com/aduh95
stream: handle falsy push writer fail reasonshttps://github.com/nodejs/node/commit/d9967a25b226efdfd65d2439bcf46e34b2f84dd8
d9967a2https://github.com/nodejs/node/commit/d9967a25b226efdfd65d2439bcf46e34b2f84dd8
#63568https://github.com/nodejs/node/issues/63568
#63569https://github.com/nodejs/node/pull/63569
#63568https://github.com/nodejs/node/issues/63568
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 22, 2026 https://github.com/nodejs/node/pull/63569#ref-pullrequest-4714405542
2026-06-23, Version 26.4.0 (Current) #64058 https://github.com/nodejs/node/pull/64058
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F63569
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/63569/files/bdda9469ceccbd03efb3209d3060b4274b86b8f0
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream/iter: writer.fail(0) can leave async iterator readers pending forever https://github.com/nodejs/node/issues/63568
Please reload this pagehttps://github.com/nodejs/node/pull/63569
https://github.com/trivikr
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.